Re: [PATCH v2] net: not build PMD AVX library when no IOVA as PA

[Thomas Monjalon <thomas@monjalon.net>]

19/02/2023 13:01, Thomas Monjalon:
> 19/02/2023 12:08, Thomas Monjalon:
> > 19/02/2023 11:04, Thomas Monjalon:
> > > 29/01/2023 13:35, Zhang, Qi Z:
> > > > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > > > > 
> > > > > PMD not announce pmd_supports_disable_iova_as_pa will not be build
> > > > > when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path
> > > > > is not skipped by the build system which cause compile error.
> > > > > 
> > > > > The patch modify i40e, iavf, ice's meson file to skip AVX library build when
> > > > > RTE_IOVA_AS_PA is not defined.
> > > > > 
> > > > > Cc: stable@dpdk.org
> > > > > 
> > > > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > > > 
> > > > Move this for next-net review.
> > > > 
> > > > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> > > 
> > > You ack your own patch?
> > > 
> > > > Applied to dpdk-next-net-intel.
> > > 
> > > Sorry I don't pull this one, as I think there is a better fix:
> > > we should not handle this option in each driver.
> > > Instead the file drivers/meson.build must be fixed.
> > 
> > No sorry, it cannot be handled in drivers/meson.build.
> > 
> > So I suggest disabling the whole driver:
> > 
> > +if not get_option('enable_iova_as_pa')
> > +    subdir_done()
> > +endif
> > 
> > Note: no need to disable ice, as it is enabled in another commit.
> 
> I've sent a patch to better disable more drivers:
> https://patches.dpdk.org/project/dpdk/patch/20230219115529.3260580-1-thomas@monjalon.net/
> 
> I think more patches would be required to enable more drivers
> supporting IOVA as VA. For instance, mempool drivers should be enabled.

I was (stupidly) expecting a review of my patch.