DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Wu, Wenjun1" <wenjun1.wu@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	Shijith Thotton <sthotton@marvell.com>
Cc: "mb@smartsharesystems.com" <mb@smartsharesystems.com>,
	dev@dpdk.org, stable@dpdk.org, david.marchand@redhat.com
Subject: Re: [PATCH v2] net: not build PMD AVX library when no IOVA as PA
Date: Thu, 02 Mar 2023 14:34:03 +0100	[thread overview]
Message-ID: <7733555.iedYuu7f5S@thomas> (raw)
In-Reply-To: <6959633.aoefvbuG5b@thomas>

19/02/2023 13:01, Thomas Monjalon:
> 19/02/2023 12:08, Thomas Monjalon:
> > 19/02/2023 11:04, Thomas Monjalon:
> > > 29/01/2023 13:35, Zhang, Qi Z:
> > > > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > > > > 
> > > > > PMD not announce pmd_supports_disable_iova_as_pa will not be build
> > > > > when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path
> > > > > is not skipped by the build system which cause compile error.
> > > > > 
> > > > > The patch modify i40e, iavf, ice's meson file to skip AVX library build when
> > > > > RTE_IOVA_AS_PA is not defined.
> > > > > 
> > > > > Cc: stable@dpdk.org
> > > > > 
> > > > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > > > 
> > > > Move this for next-net review.
> > > > 
> > > > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> > > 
> > > You ack your own patch?
> > > 
> > > > Applied to dpdk-next-net-intel.
> > > 
> > > Sorry I don't pull this one, as I think there is a better fix:
> > > we should not handle this option in each driver.
> > > Instead the file drivers/meson.build must be fixed.
> > 
> > No sorry, it cannot be handled in drivers/meson.build.
> > 
> > So I suggest disabling the whole driver:
> > 
> > +if not get_option('enable_iova_as_pa')
> > +    subdir_done()
> > +endif
> > 
> > Note: no need to disable ice, as it is enabled in another commit.
> 
> I've sent a patch to better disable more drivers:
> https://patches.dpdk.org/project/dpdk/patch/20230219115529.3260580-1-thomas@monjalon.net/
> 
> I think more patches would be required to enable more drivers
> supporting IOVA as VA. For instance, mempool drivers should be enabled.

I was (stupidly) expecting a review of my patch.





      reply	other threads:[~2023-03-02 13:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12 12:17 [PATCH] net: not compile " Qi Zhang
2022-12-12 14:52 ` [PATCH v2] net: not build " Qi Zhang
2022-12-12 14:55 ` Qi Zhang
2023-01-29 12:35   ` Zhang, Qi Z
2023-02-19 10:04     ` Thomas Monjalon
2023-02-19 11:08       ` Thomas Monjalon
2023-02-19 12:01         ` Thomas Monjalon
2023-03-02 13:34           ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7733555.iedYuu7f5S@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=sthotton@marvell.com \
    --cc=wenjun1.wu@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).