From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A18D41DB5; Thu, 2 Mar 2023 14:34:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E650940EE3; Thu, 2 Mar 2023 14:34:09 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 5AAA740E09; Thu, 2 Mar 2023 14:34:08 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id B751F320077A; Thu, 2 Mar 2023 08:34:06 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 02 Mar 2023 08:34:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1677764046; x=1677850446; bh=HrSkiFNdQlFK0x1lFViUd2mVS3GGAkt2NzD 6PeAUYQ0=; b=TetQjbUSTsEoW0iDBOmLCip96CacNWcSOc6q4ztHfRlgMHYEEjO PxzD7YZmLTybMYsz6IArCPFTOetjToCJkCldnHcwau1Vd6MyWQ8xWMS+Ihockrhx 6uLwS8oLMIQxUmE/Z+raqOVlLXYEsxA4GR5Ea5Z/+pw4EnNRR9qZsdQOBj0ba412 SbPd8g9+xlscrgje7ee3UW1G2qX75OMAwCUPYLnffx6bZXtllg4kgy3WttuPUQMb 4MVbBCxjf5sy+L3jnd82uewgMsrb5a5okv/D/gSRpdUCQ31b6xWB/u3mvn8ZMtza ZHjbFWExZPAaPOj3CAwTyYNRVnHMyUypczA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1677764046; x=1677850446; bh=HrSkiFNdQlFK0x1lFViUd2mVS3GGAkt2NzD 6PeAUYQ0=; b=bQ+P0J1QzMQik/Vgi/Bpp1txSFBE6tWsRR2/ke0W5Nt/aQk7k6S wbwB0We8N8SFZ18DRUzlilMwwGyWSApv/lLWbkPZjAn90bCArM39dhkPHCzPgjJ8 RiRVtgvBdD/6Qn6WeASLIMaXAwMuDJYQs6c/HfnbVeaH6Q+Fd52Sgm/jtNkfSv2n PCmTJWMz8r7KYwiPxAQZu+xDCPT3TIE9jkaKXRh9LPopLTirfftDmIWGHrcwohZM Kr/LS9oBSpWCVJf0bXiu247UXinnBxM1IieLaBQdzUMiJF7XGeh9Uu1LkPuzP8/8 202t503zMaKYTG8KcN3dRq94nOiUASArMUw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeljedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejjefffffgffekfefflefgkeelteejffelledugefhheelffet heevudffudfgvdenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Mar 2023 08:34:04 -0500 (EST) From: Thomas Monjalon To: "Richardson, Bruce" , "Lu, Wenzhuo" , "Wu, Wenjun1" , "Zhang, Qi Z" , Shijith Thotton Cc: "mb@smartsharesystems.com" , dev@dpdk.org, stable@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH v2] net: not build PMD AVX library when no IOVA as PA Date: Thu, 02 Mar 2023 14:34:03 +0100 Message-ID: <7733555.iedYuu7f5S@thomas> In-Reply-To: <6959633.aoefvbuG5b@thomas> References: <20221212121711.857866-1-qi.z.zhang@intel.com> <5705342.1B3tZ46Xf9@thomas> <6959633.aoefvbuG5b@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/02/2023 13:01, Thomas Monjalon: > 19/02/2023 12:08, Thomas Monjalon: > > 19/02/2023 11:04, Thomas Monjalon: > > > 29/01/2023 13:35, Zhang, Qi Z: > > > > From: Zhang, Qi Z > > > > > > > > > > PMD not announce pmd_supports_disable_iova_as_pa will not be build > > > > > when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path > > > > > is not skipped by the build system which cause compile error. > > > > > > > > > > The patch modify i40e, iavf, ice's meson file to skip AVX library build when > > > > > RTE_IOVA_AS_PA is not defined. > > > > > > > > > > Cc: stable@dpdk.org > > > > > > > > > > Signed-off-by: Qi Zhang > > > > > > > > Move this for next-net review. > > > > > > > > Acked-by: Qi Zhang > > > > > > You ack your own patch? > > > > > > > Applied to dpdk-next-net-intel. > > > > > > Sorry I don't pull this one, as I think there is a better fix: > > > we should not handle this option in each driver. > > > Instead the file drivers/meson.build must be fixed. > > > > No sorry, it cannot be handled in drivers/meson.build. > > > > So I suggest disabling the whole driver: > > > > +if not get_option('enable_iova_as_pa') > > + subdir_done() > > +endif > > > > Note: no need to disable ice, as it is enabled in another commit. > > I've sent a patch to better disable more drivers: > https://patches.dpdk.org/project/dpdk/patch/20230219115529.3260580-1-thomas@monjalon.net/ > > I think more patches would be required to enable more drivers > supporting IOVA as VA. For instance, mempool drivers should be enabled. I was (stupidly) expecting a review of my patch.