From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 4/9] net/hns3: adjust the format of RAS related structures
Date: Thu, 11 Mar 2021 18:25:43 +0000 [thread overview]
Message-ID: <773749fe-6420-0729-6cf0-e8aea4c5095c@intel.com> (raw)
In-Reply-To: <1615356985-24722-5-git-send-email-humin29@huawei.com>
On 3/10/2021 6:16 AM, Min Hu (Connor) wrote:
> From: Hongbo Zheng <zhenghongbo3@huawei.com>
>
> Adjust the format of hns3 RAS related structures to resolve
> the static check warnings of reviewbot_c.This patch has no
> impact on function.
>
> The correspond warnings of reviewbot_c:
> When struct and union members are initialized, each member
> is initialized on a separate line.
>
> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
<...>
> static const struct hns3_hw_error ppu_mpf_abnormal_int_st1[] = {
> - { .int_msk = 0xFFFFFFFF,
> - .msg = "rpu_rx_pkt_ecc_mbit_err",
> - .reset_level = HNS3_GLOBAL_RESET },
> - { .int_msk = 0,
> - .msg = NULL,
> - .reset_level = HNS3_NONE_RESET}
> + {
> + .int_msk = 0xFFFFFFFF,
> + .msg = "rpu_rx_pkt_ecc_mbit_err",
> + .reset_level = HNS3_GLOBAL_RESET
> + }, {
> + .int_msk = 0,
> + .msg = NULL,
> + .reset_level = HNS3_NONE_RESET
> + }
> };
Hi Connor,
This looks like just a syntax change, I wonder what is mentioned
'reviewbot_c' that generates a warning?
next prev parent reply other threads:[~2021-03-11 18:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 6:16 [dpdk-dev] [PATCH v2 0/9] features and bugfixes for hns3 Min Hu (Connor)
2021-03-10 6:16 ` [dpdk-dev] [PATCH v2 1/9] net/hns3: support runtime config to select IO burst func Min Hu (Connor)
2021-03-11 17:31 ` Ferruh Yigit
2021-03-12 0:59 ` Min Hu (Connor)
2021-03-11 17:39 ` Ferruh Yigit
2021-03-12 1:01 ` Min Hu (Connor)
2021-03-10 6:16 ` [dpdk-dev] [PATCH v2 2/9] net/hns3: support Tx push quick doorbell to improve perf Min Hu (Connor)
2021-03-11 18:05 ` Ferruh Yigit
2021-03-12 11:02 ` Min Hu (Connor)
2021-03-10 6:16 ` [dpdk-dev] [PATCH v2 3/9] net/hns3: support for outer UDP cksum Min Hu (Connor)
2021-03-10 6:16 ` [dpdk-dev] [PATCH v2 4/9] net/hns3: adjust the format of RAS related structures Min Hu (Connor)
2021-03-11 18:25 ` Ferruh Yigit [this message]
2021-03-12 1:51 ` Min Hu (Connor)
2021-03-12 10:02 ` Ferruh Yigit
2021-03-12 10:51 ` Min Hu (Connor)
2021-03-16 11:32 ` Min Hu (Connor)
2021-03-10 6:16 ` [dpdk-dev] [PATCH v2 5/9] net/hns3: delete redundant xstats RAS statistics Min Hu (Connor)
2021-03-10 6:16 ` [dpdk-dev] [PATCH v2 6/9] net/hns3: support imissed stats for PF/VF Min Hu (Connor)
2021-03-10 6:16 ` [dpdk-dev] [PATCH v2 7/9] net/hns3: support oerrors stats in PF Min Hu (Connor)
2021-03-10 6:16 ` [dpdk-dev] [PATCH v2 8/9] net/hns3: support query Tx descriptor status Min Hu (Connor)
2021-03-10 6:16 ` [dpdk-dev] [PATCH v2 9/9] net/hns3: support query Rx " Min Hu (Connor)
2021-03-12 11:51 ` [dpdk-dev] [PATCH v3 0/8] features and bugfixes for hns3 Min Hu (Connor)
2021-03-12 11:51 ` [dpdk-dev] [PATCH v3 1/8] net/hns3: support runtime config to select IO burst func Min Hu (Connor)
2021-03-16 12:40 ` Ferruh Yigit
2021-03-17 1:14 ` Min Hu (Connor)
2021-03-17 15:28 ` Ferruh Yigit
2021-03-19 1:08 ` Min Hu (Connor)
2021-03-12 11:51 ` [dpdk-dev] [PATCH v3 2/8] net/hns3: support for outer UDP cksum Min Hu (Connor)
2021-03-12 11:51 ` [dpdk-dev] [PATCH v3 3/8] net/hns3: adjust the format of RAS related structures Min Hu (Connor)
2021-03-12 11:51 ` [dpdk-dev] [PATCH v3 4/8] net/hns3: delete redundant xstats RAS statistics Min Hu (Connor)
2021-03-12 11:51 ` [dpdk-dev] [PATCH v3 5/8] net/hns3: support imissed stats for PF/VF Min Hu (Connor)
2021-03-12 11:51 ` [dpdk-dev] [PATCH v3 6/8] net/hns3: support oerrors stats in PF Min Hu (Connor)
2021-03-12 11:51 ` [dpdk-dev] [PATCH v3 7/8] net/hns3: support query Tx descriptor status Min Hu (Connor)
2021-03-12 11:51 ` [dpdk-dev] [PATCH v3 8/8] net/hns3: support query Rx " Min Hu (Connor)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=773749fe-6420-0729-6cf0-e8aea4c5095c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).