From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CF9FA056A; Thu, 11 Mar 2021 19:25:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E505E4014D; Thu, 11 Mar 2021 19:25:57 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 80D6640141 for ; Thu, 11 Mar 2021 19:25:55 +0100 (CET) IronPort-SDR: 9d8kqxB1DJ17suJb4C983PNOdnrTR89UqbwsZs4SF0nZ2vLQne5468YMrxuTCCad1bhn/UFM7I FD+WJ5zVPsCw== X-IronPort-AV: E=McAfee;i="6000,8403,9920"; a="185360300" X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="185360300" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 10:25:54 -0800 IronPort-SDR: TozhVDqM7IIVK4iSNA4U+hNR2hYYQmOcpO2m+04QX7aBAcOs43+O9wYoKbCAnSzdvrbiyXXqGt SANkbPLEQQSg== X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="448368100" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.22.78]) ([10.252.22.78]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 10:25:47 -0800 To: "Min Hu (Connor)" , dev@dpdk.org References: <1615356985-24722-1-git-send-email-humin29@huawei.com> <1615356985-24722-5-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <773749fe-6420-0729-6cf0-e8aea4c5095c@intel.com> Date: Thu, 11 Mar 2021 18:25:43 +0000 MIME-Version: 1.0 In-Reply-To: <1615356985-24722-5-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 4/9] net/hns3: adjust the format of RAS related structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: > From: Hongbo Zheng > > Adjust the format of hns3 RAS related structures to resolve > the static check warnings of reviewbot_c.This patch has no > impact on function. > > The correspond warnings of reviewbot_c: > When struct and union members are initialized, each member > is initialized on a separate line. > > Signed-off-by: Hongbo Zheng > Signed-off-by: Min Hu (Connor) <...> > static const struct hns3_hw_error ppu_mpf_abnormal_int_st1[] = { > - { .int_msk = 0xFFFFFFFF, > - .msg = "rpu_rx_pkt_ecc_mbit_err", > - .reset_level = HNS3_GLOBAL_RESET }, > - { .int_msk = 0, > - .msg = NULL, > - .reset_level = HNS3_NONE_RESET} > + { > + .int_msk = 0xFFFFFFFF, > + .msg = "rpu_rx_pkt_ecc_mbit_err", > + .reset_level = HNS3_GLOBAL_RESET > + }, { > + .int_msk = 0, > + .msg = NULL, > + .reset_level = HNS3_NONE_RESET > + } > }; Hi Connor, This looks like just a syntax change, I wonder what is mentioned 'reviewbot_c' that generates a warning?