DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Beilei Xing <beilei.xing@intel.com>, qi.z.zhang@intel.com
Cc: dev@dpdk.org, jia.guo@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix shifts of 32-bit value
Date: Wed, 23 May 2018 16:49:03 +0100	[thread overview]
Message-ID: <7739db21-a331-55da-5ead-aa656600adbf@intel.com> (raw)
In-Reply-To: <1527061606-10172-1-git-send-email-beilei.xing@intel.com>

On 5/23/2018 8:46 AM, Beilei Xing wrote:
> Cppcheck reports following error,
> (error) Shifting 32-bit value by 36 bits is undefined behaviour
> 
> According to datasheet, there's PHY type and PHY type extension
> in setting PHY config command, should exclude PHY type extension
> when setting PHY type.
> 
> Fixes: 1bb8f661168d ("net/i40e: fix link down and negotiation")
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

Hi Beilei,

This patc was late for rc5, it will be considered for next release.

Thanks,
ferruh

  reply	other threads:[~2018-05-23 15:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23  7:46 Beilei Xing
2018-05-23 15:49 ` Ferruh Yigit [this message]
2018-06-21 14:19 ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7739db21-a331-55da-5ead-aa656600adbf@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jia.guo@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).