From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A22FA0543; Thu, 7 Jul 2022 14:22:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A8E340A7B; Thu, 7 Jul 2022 14:22:35 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2059.outbound.protection.outlook.com [40.107.94.59]) by mails.dpdk.org (Postfix) with ESMTP id 1DB5A406B4 for ; Thu, 7 Jul 2022 14:22:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HDkwX2V2ylTuR0W/1deYi4sUpfAnjJVdJ1n3zQiq/u5YkKktBgLLzDWhcAws6yGDLAEAPWdtntaZeDanEWHz9047rG6sWO3wPpZG2YJPewQA5jqsJSoDLRgZAbinIbtGafVq2lap7DZvBJFvchJlI9QS8XHCQTupsskfpCw7o7gnQ+2IYVnKV+X6ZLLr5AriAn0GUwE8Jh/ffh7oydw3osCNufCZ+OOirIF/62i+iKgaDSNsDQf8Retdnp7OjVMeIIMmflUH8hSMOzZBRghXwP0uMxqdXMab8BUQoByRGhl9DBbEN8GgrAWUSb+FOhOGgWptQlx9shrGIdKDllZOUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a1HfQMegevBDW8LX111+u84fgAn383EWRCbVHYpUIkY=; b=KmW2ShJ12IufODYRVLFFHddyXQ3yG3h3GJtsATub8/Ujf1/lAJxtZUZNnU1935T5CXLFwv9D6pLyWpyr3govVp8RGdm+tLjV8LOnZRFqtPln7AAaoao+yDdl5hnsc0v6F70sx3+It9rskMzRMXb9ZQTBra00lXUu0UtBAcNt3ep3EGqce3XhX4MTXyZxCggdghocXmb2M7Q4qmPYeCkxxqqA3/jUcXTm/3snIGwdrFJlxlgiNWBq0BVx/vssc6MHoAu+9xi0Zy8E5f0IWixBZJOQyuNFTOPF4fmMNUUZMCWeVXe+EqbEo3gCYvunDGuT6Q1dJbex+jplp3y8yPLRHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a1HfQMegevBDW8LX111+u84fgAn383EWRCbVHYpUIkY=; b=BZdoNIm2JrZ7FdD938wyQpiqTSTFuPnDPaHNijSsrPigYxSBm5L3r39U+qrUBfUApeToM652d9vf4z8DouUieEZNl2yse7BUGQdDuI+hahJwBSc0XUn5w74/l9zq4zEHdLrX65SSiZKgGgkzwm4dpg8wxYgFPk3WNhTRCBWdHDk= Received: from BN9PR03CA0416.namprd03.prod.outlook.com (2603:10b6:408:111::31) by BN6PR02MB2212.namprd02.prod.outlook.com (2603:10b6:404:28::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 12:22:31 +0000 Received: from BN1NAM02FT050.eop-nam02.prod.protection.outlook.com (2603:10b6:408:111:cafe::99) by BN9PR03CA0416.outlook.office365.com (2603:10b6:408:111::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Thu, 7 Jul 2022 12:22:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT050.mail.protection.outlook.com (10.13.2.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Thu, 7 Jul 2022 12:22:30 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 7 Jul 2022 13:22:29 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 7 Jul 2022 13:22:29 +0100 Envelope-to: lihuisong@huawei.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, thomas@monjalon.net, weiyuanx.li@intel.com, huangdaode@huawei.com, liudongdong3@huawei.com Received: from [172.21.33.98] (port=64776) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o9QWb-000784-3n; Thu, 07 Jul 2022 13:22:29 +0100 Message-ID: <773cea2b-68e3-ac28-b6cc-dd57377144b1@xilinx.com> Date: Thu, 7 Jul 2022 13:22:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] app/testpmd: fix display types failure when query RSS rule Content-Language: en-US To: Huisong Li , CC: , , , , References: <20220707105044.10567-1-lihuisong@huawei.com> From: Ferruh Yigit In-Reply-To: <20220707105044.10567-1-lihuisong@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d94c00dd-c1b6-48f0-dfbf-08da60135ce1 X-MS-TrafficTypeDiagnostic: BN6PR02MB2212:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: URY/8RB0xO6yEfzvA/PlhJrsrXlxc5G8qHOrW11p7aVqA039WLX4jxbgk3p9I8X8VyFFX/iHNhkB+Ybryd3raGxb5ksQhI3FNec8Yh10Bg9B7ajvnM67oGMi5M/3QlFMSWdiNUMLiKN+x7Wi5hcGlx738pMTD9jMIWrVUV3+X+VUE2jer70BxhTK4tgWDEO2qmUXcSbkAyC+Ga/6sm4FQc0ywF3Ibx2+Sk5RhVHvSrz0/g3JCN5iUEuCXYKJuRe5yUVOfjlm6t1ZQAhwete+ZGRNxHSGJmKcGGip6qRVW2z97K0EGzYpHM4Y7FLNluiQVSYFJrsU3iZJMdn82Z6ZMLsLk5oEP9kkSi/BoPPBdL7C02wj090Im0Al3QKMQIg6ygiX2KDuDdlDihTnTiRMSYNurGGExdwzeo2PgMLNB9qRbPOx4OqbzqLO21eG/5ZqUDxLwSC6KnRdqUKVw1WRXz65g/7xxPX6cyrhrdK0PQ9zz3ubrrFJBWiSkqfYRP7aJjMtIgrFiVF6M7dh/quuWODKGdTgMsIWC4R5yoaC5zGjy9vPaqoiZL07IIqbG5zTlHlr2eTA20uwkCRFSwvN2p+ukX/46sEvgpS/ntVGUZs8cNqitYr5XbQ+VrNxkqyCMgEXuSCAgLgN66XuuS6pxYGPWG8QOyHPlVB9fyxP+faRRB02j/RjiSZrx3zUSUqkEUKf5qfURA+n0tyMvAixnJfpOt7LYBPyE32xUeAipDi6xDKKlh/hmBXDZNR33o6Z2UwuoktWGuh8Qyi6LohVPqjbPN+ECDmUkQPzUvg1n/lUDh72xktp7jBnvSFnXibsxIuSDVCKs/a3n2jgcouj+HsSAqnWNLxsQshycil6wBkhgrDNrzl9LRE+ZEfOiAcJ X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(376002)(136003)(39860400002)(346002)(396003)(36840700001)(40470700004)(46966006)(70586007)(82740400003)(8676002)(7636003)(186003)(2616005)(36756003)(47076005)(70206006)(31686004)(426003)(36860700001)(53546011)(356005)(82310400005)(40480700001)(110136005)(83380400001)(4326008)(26005)(5660300002)(478600001)(54906003)(44832011)(31696002)(41300700001)(9786002)(40460700003)(316002)(2906002)(336012)(8936002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 12:22:30.3579 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d94c00dd-c1b6-48f0-dfbf-08da60135ce1 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT050.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2212 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/7/2022 11:50 AM, Huisong Li wrote: > Now testpmd fails to display types when query RSS rule. The failure is > because the '\n' character is missing at the end of the function > 'rss_config_display()'. > Bugzilla ID: 1048 > Fixes: 534988c490f1 ("app/testpmd: unify RSS types display") > > Signed-off-by: Huisong Li > --- > app/test-pmd/config.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 608bec9796..bcb6d42da3 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1693,6 +1693,7 @@ rss_config_display(struct rte_flow_action_rss *rss_conf) > return; > } > rss_types_display(rss_conf->types, TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE); > + printf("\n"); Thanks Huisong for the fix. What do you think to have '\n' in the 'rss_types_display()' function and update 'port_rss_hash_conf_show()' usage? And can do same change for 'rss_offload_types_display()', having last '\n' in the function. > } > > static struct port_indirect_action *