From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Paul Luse <paul.e.luse@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vdev: free reply.msgs memory for secondary process
Date: Fri, 21 Sep 2018 17:53:50 +0100 [thread overview]
Message-ID: <7758f4c8-ee1f-ae3c-e9ea-7669d3d7f67a@intel.com> (raw)
In-Reply-To: <20180921162557.48249-1-paul.e.luse@intel.com>
On 9/21/2018 5:25 PM, Paul Luse wrote:
> From: paul luse <paul.e.luse@intel.com>
>
> This patch fixes an issue caught with ASAN where a vdev_scan()
> to a secondary bus was failing to free some memory.
>
> Signed-off-by: paul luse <paul.e.luse@intel.com>
Hi Paul,
Is this different from below patch, which seems already acked:
https://patches.dpdk.org/patch/45079/
> ---
> drivers/bus/vdev/vdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
> index 69dee89a8..2566d6c0d 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -423,6 +423,7 @@ vdev_scan(void)
> mp_rep = &mp_reply.msgs[0];
> resp = (struct vdev_param *)mp_rep->param;
> VDEV_LOG(INFO, "Received %d vdevs", resp->num);
> + free(mp_reply.msgs);
> } else
> VDEV_LOG(ERR, "Failed to request vdev from primary");
>
>
next prev parent reply other threads:[~2018-09-21 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 16:25 Paul Luse
2018-09-21 16:53 ` Ferruh Yigit [this message]
2018-09-27 13:28 ` Ferruh Yigit
2018-10-25 7:28 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2018-09-20 23:29 paul luse
2018-09-21 11:07 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7758f4c8-ee1f-ae3c-e9ea-7669d3d7f67a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=paul.e.luse@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).