From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Yogesh Jangra <yogesh.jangra@intel.com>, dev@dpdk.org
Cc: cristian.dumitrescu@intel.com, kamalakannan.r@intel.com,
harshad.suresh.narayane@intel.com, "Mcnamara,
John" <john.mcnamara@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2] app/testpmd: fix closing softnic port before ethdev ports
Date: Thu, 18 Apr 2024 16:29:00 +0100 [thread overview]
Message-ID: <775abdb3-2a94-4e45-b03d-58e9560812ce@amd.com> (raw)
In-Reply-To: <20230309160212.1200403-1-yogesh.jangra@intel.com>
On 3/9/2023 4:02 PM, Yogesh Jangra wrote:
> SoftNIC runs on the service core, it uses the resources from
> the testpmd application. When we run quit command, the testpmd
> application stops ethdev ports first, SoftNIC will try to
> access the port and sometimes that results in segmentation
> error. This fix will first close the SoftNIC port.
>
> Signed-off-by: Yogesh Jangra <yogesh.jangra@intel.com>
> Signed-off-by: Kamalakannan R <kamalakannan.r@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>
I am cleaning up old patches in patchwork.
NACK to this patch as it is, testpmd should not behave different for any
specific driver/device. This can go out of hand if we open the door.
next prev parent reply other threads:[~2024-04-18 15:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 14:42 [PATCH] " Yogesh Jangra
2023-03-09 16:02 ` [PATCH v2] " Yogesh Jangra
2024-04-18 15:29 ` Ferruh Yigit [this message]
2023-03-09 16:31 ` [PATCH] " Stephen Hemminger
2023-03-09 17:19 ` Dumitrescu, Cristian
2023-03-09 19:09 ` Dumitrescu, Cristian
2023-03-09 20:22 ` Stephen Hemminger
2023-03-10 9:09 ` Singh, Aman Deep
2023-03-10 13:45 ` Dumitrescu, Cristian
2023-03-10 12:00 ` Ferruh Yigit
2023-03-10 13:47 ` David Marchand
2023-03-10 13:47 ` Dumitrescu, Cristian
2023-03-10 13:49 ` David Marchand
2023-03-10 14:36 ` Dumitrescu, Cristian
2023-03-10 14:39 ` David Marchand
2023-03-10 14:58 ` Thomas Monjalon
2023-03-10 13:58 ` Ferruh Yigit
2023-03-10 16:44 ` Stephen Hemminger
2023-03-17 7:11 ` Jangra, Yogesh
2023-03-09 19:08 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=775abdb3-2a94-4e45-b03d-58e9560812ce@amd.com \
--to=ferruh.yigit@amd.com \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=harshad.suresh.narayane@intel.com \
--cc=john.mcnamara@intel.com \
--cc=kamalakannan.r@intel.com \
--cc=yogesh.jangra@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).