From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA5BB43EA7; Thu, 18 Apr 2024 17:29:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92A8D40272; Thu, 18 Apr 2024 17:29:08 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2057.outbound.protection.outlook.com [40.107.94.57]) by mails.dpdk.org (Postfix) with ESMTP id 0CF7840689 for ; Thu, 18 Apr 2024 17:29:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MmhWVQq9VfXKJ5v0cUVpw7zUy7V1EbiMmuDKRdaH2t0c+sJvSk4QXeKbllbzHjRwmnFr/eqOKUWXnKXP8TIFiR9v4Yv8AP11Nr3j0GTH3B6YpGZpb80ZWzqGa8YCebv+5JEA3ojm04AYMrgUozGd0KR83sbnjp3XAeLvC3OkOM5QtXHHEqfSDEozSNn2LR8xpQyfB8PrwvzvGpWNPF3msoWyzQeGp/qGnpuaS5N9DaYcNb1NYVBygDWjOb0EIurtqmM2rqMDTH9x80bqI6R14k/ygn++LjsIHDXNd/TVGBW2EhO0BMhlVY0RxFyg6fCs6piKyst33h89MD1zjakSPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uwrM5FhkVfsueAwl3xKH2ogBh8kWaqlOTVaEgaPDDIU=; b=FTYwk1W6hnfWTB+YDHQXD4Pt5GmCfRa1E4Wetno2jvda4GGREp7eh5fEUkY2zMC2gC/O2ID7BcmGVcqb5t0VHBhsBqtpMCmNLUVxBjoPUZadD6z2WIvQL8LZ7CP3F+sbhN9EbjvIQvaublS4n32vj+xKOBqCJotEyXaAx2IBqADqLMvOg/z+vy3JSH3tLilHXCAvT2rNcRqEsuqj1Hd2b5/dZ7dSefhDVOY464joHFTLmi9z8x4ltMHMK41nf6PnIPTO2v1W06Z4hYEA66rabS7+zCGn3aOmd2Qf/1VD8yqWZy08Dj7l+tVXl8nv9k674f9l1UxcH8vqSwsZaDVKoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uwrM5FhkVfsueAwl3xKH2ogBh8kWaqlOTVaEgaPDDIU=; b=x11SOQ78Wu4dwZxsatFquMQwO5ciDoVcb4g6B5G4BxICb+wdUMU6HzseBlrtAJ4vPLzKa1Xr2ZrhcSQiqDlMP8kMIgqQVbGYNjfQYJ6vDXnfIBAIMbUCb4ZTrQbytA/jwGortQednsdrUG/7YPOl5NEVv4A8Ups+BurjxnsbQ/8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW4PR12MB7238.namprd12.prod.outlook.com (2603:10b6:303:229::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.37; Thu, 18 Apr 2024 15:29:04 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7452.049; Thu, 18 Apr 2024 15:29:04 +0000 Message-ID: <775abdb3-2a94-4e45-b03d-58e9560812ce@amd.com> Date: Thu, 18 Apr 2024 16:29:00 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] app/testpmd: fix closing softnic port before ethdev ports To: Yogesh Jangra , dev@dpdk.org Cc: cristian.dumitrescu@intel.com, kamalakannan.r@intel.com, harshad.suresh.narayane@intel.com, "Mcnamara, John" , Bruce Richardson References: <20230309144249.1199517-1-yogesh.jangra@intel.com> <20230309160212.1200403-1-yogesh.jangra@intel.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20230309160212.1200403-1-yogesh.jangra@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0305.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:391::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW4PR12MB7238:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f99ea9b-3a1a-4693-88ef-08dc5fbc47f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G4eTjCKvYn1gW8a5itxjvVWZ3tMIYbCS0iJ9r0nL4PsCWu5v6px2bMryBj0PTKeHlMjRHyzO5XisNtlcfNki15hijdEFNNaNx+mZr9Ok1/RudubrKwxrvkoqKt90rGfxZbc5PnSd4a+dLECj3PBvWZkc+kJSB4im6WhguvNxGGokLh5h660WaMdxDytS5ZIWC3TeXzsPYfyyCf0ZxlM0ASXi/Z8DD5K4hHUQ4uGnXDBrHR4kormOZ2vIePdM3ZAwayKp6onMbTna2p0limVvtVgpoAax8zIaA7DIYpCiFz+/MWHW2Qydugx62TPLIrq9POZppaa4Z/KjMMPJI15c0BL65idSGbBkb7zhyYf1nY0b6QWtJingwUbKF5mYmcGL3VyT3vA4mfZeTq15hwlDy5wJ3no5+gHjVC+znUsmO9MRVpkT0RMEFm72i7K3J2+rANM1mSZCcmCkqViVIGT4Q46QbMx3Odx0hLpc373+WZQaDPkQZQcDLzruezROwhMYKSkfRZzpKbDusCuKoToiDzGxwasoEjMLtjHtEGbvoeygdbyfzvp4W+8bFtu3WVkmjqpEbtu/pa/OC038AX3ZyKbjvHzOvgly7FHx+iotFRBI8+eMqHSHhlX/n1FpRLZtv3/Ct+/vzo01/EsZGuLvRrvmSwQgcfxp9xd9Qg4rYVE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGhlL2VYUzhKc2ZrVWRKamJsRUx4RllxTmNsMDRoSW92L1haS04xejNSZTNy?= =?utf-8?B?NDkwMjV6R0w4OGJqblYxU1N6bk9PaWRtdjNIM0IwdHNqQmVMdlVqNXh1UHpV?= =?utf-8?B?U0lBUEw1SXdwQ054VnFrbzE3eisxTFExc05XTzRpUTZKZXExRVV6SXpLRkpS?= =?utf-8?B?aTExbk1zSVdZMUEyY2hCdkJRTUE1cmRmcUhzMDZ6bUZXZjFOVjZHK0FHekx3?= =?utf-8?B?aHQxd3RtbmFTVkw0UGFrV1k1RmhQK0JKQ0V2T0VPZDNibUg4VDh0cWV0eldT?= =?utf-8?B?UVRqS0NYalNadGxxbzZweHhJTXZIMUdxSnRUMmRybVd5RDF1bjZEQ3FZTXE3?= =?utf-8?B?QURrb2tKVmc2Z2c0NkZvVXFHNGdVRVE0RUJ3UUozTXBvcnVJSzBkZkZmTTZm?= =?utf-8?B?eldZVFlGOThRTklkaDc3SmVQNUZTeXYrV2h0NUgvL1VWY29RV1lGRXJGamtU?= =?utf-8?B?MkEwSU1tb2hPamV6WTkwdFNDNStOV2dWeDFCVjR4Z2xsbC90T1I3NWtPWGNt?= =?utf-8?B?ZjhpSFAzcHNXd01xUEtWdmdhemtDMEpSWGNPY3RIU1pwcko1eEFobm9NVzRJ?= =?utf-8?B?cVozNTcyVUd3R1o3RVh1UFVNRUhTbXVQRUZMMG8xMFlYdnBZd241SmZPYnJZ?= =?utf-8?B?WVdHbVV4NGpueG5ERTFXWnk1OVBnSVgvKzJ1YUZvOVRmL1AxQ1gxYmdVYlVM?= =?utf-8?B?bVlYVG9ra0pBQTlpaW5vWTdBTEI0RGl6Z2RpcG9HSkVGYjNqbmRkTnFSM0wv?= =?utf-8?B?aUVGWCt5d3kyS3RYVmtieHlpWUMzRGUxRlh1TnNoY1JQYnQyZHpacFFoK29C?= =?utf-8?B?dXRpM2dLOW5DMEJJM1FCejdlM1d1YW5mTWFGR0FuaDIvRjd5ZlFPSVFtQ1Yy?= =?utf-8?B?NnRUUGFJUVg0TnFsTmhzMFdsME1rVnIvZDU0MWZTZ0g4MHVmbWk3ckIySmU2?= =?utf-8?B?SDlYZUt6alo3cWx3SU5idzJUZFBtMEIrd3FOZENGZnFMM1R2WnFwM0lDSlZx?= =?utf-8?B?Nkg3aVJtR3FwMkZXVktYRXBCOGtiTG9MT0VxSHlySjdFK3RTdDFJTDNtWkZi?= =?utf-8?B?TXYvVHladFhQNU1zalorbHV3SmdzdzRHdFRYd0N4eUI4N3RmV1N6TnNGTWhE?= =?utf-8?B?ZDh0b1hhSUo0TkU2QkRiYXRDOXVzdzM4UE03L0llV0x4U21HYXpVQTNnNHBW?= =?utf-8?B?Qmt4eHd4R1JXYmcxcnJ6WVZVZkRlald2YmlNbXZTdjUxR3NmUm1xSWpnTzVP?= =?utf-8?B?aFJJNlI1enNaWER0Wk56Y1N3azFxaGlndTlNMEhobnRNVWk4ZnNQcElrSDBN?= =?utf-8?B?ZlAraHdBRGUyVzd6MWp5amlVTGZUNFAvVFNQRWw0aDlBTWtYLzhabGVvRlNX?= =?utf-8?B?VE5KTkh0aGVEZ0RGS05IczJoUDF4YThKU2lNRlQ5V3ZOTW1GSENjcXQ5SU9p?= =?utf-8?B?aHIvQXZHNXhGbmRUTGtqelcvc2FRbDVNWHo0TDBCdXY4bW9ISkcwMGJWK3No?= =?utf-8?B?L3JDbVY4VHE3Um9hT3ZXRm03djRtM2Z4WHlaT05WdnFjVlNhQ2taSndRaE5k?= =?utf-8?B?RmgvZTg0THN4bExXVThaNVo2K2gwOFhIdUwwZUdoKzVqY1ZqQmxiUUNYcG5h?= =?utf-8?B?M25NSEphMnRBNjUxQngrc1NuRGRxUjg1NThQVUdENkJQazlEaGtsY3VsL1Ax?= =?utf-8?B?cjhRYk1IQUdmaTBPZUJ5d2U1emtlMUoyc1VBSFpWVEhsRURZNmRjYTBVd1BV?= =?utf-8?B?aDlieU41cHpBcUJ5dWhVYXB1QkEzYWlHWHI3b3ZDTU9WdGg2Q0xsSlY1Ty9x?= =?utf-8?B?amVFUDk2UmhBY1BEWitKU3dSbk9uZ293MHdQaXFWc2lRRXEzVWxlaHVWOS8x?= =?utf-8?B?WDlxYWM4VGtmN0tvSFN5UW9UUjNpSDMxMC91Ulc4bGl1RlRMRzZYeFQ5OEhE?= =?utf-8?B?NTRsZGRCWllhVEg5R1NHbHpVQWV5MTlqMm9mQVIzZkp5N0p5WHN5M3M1YmlC?= =?utf-8?B?eS9UeGRjdXgrSnpsRitITnNQczNlODM5RDQ0Q1dtNERvVm42TlNwSlhOMlJV?= =?utf-8?B?VFdkYXFJVUd6MVVrdkVkV21tMHZ1K0ROVXVmVXFRVGRRRGZpaE41RGQvemhC?= =?utf-8?Q?PzcJH0MLi/8Ukj1DyZQGTZWLG?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f99ea9b-3a1a-4693-88ef-08dc5fbc47f6 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 15:29:04.7859 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bLPA+Q8M24cVdDnugA3LK5RigjeNdCzfJ6EgamIHMsd5tD8GRwZwUpfBwdE0msUy X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7238 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/9/2023 4:02 PM, Yogesh Jangra wrote: > SoftNIC runs on the service core, it uses the resources from > the testpmd application. When we run quit command, the testpmd > application stops ethdev ports first, SoftNIC will try to > access the port and sometimes that results in segmentation > error. This fix will first close the SoftNIC port. > > Signed-off-by: Yogesh Jangra > Signed-off-by: Kamalakannan R > Acked-by: Cristian Dumitrescu > I am cleaning up old patches in patchwork. NACK to this patch as it is, testpmd should not behave different for any specific driver/device. This can go out of hand if we open the door.