From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54])
by dpdk.org (Postfix) with ESMTP id F2444DE0
for <dev@dpdk.org>; Tue, 2 Dec 2014 12:29:28 +0100 (CET)
Received: by mail-wg0-f54.google.com with SMTP id l2so16834655wgh.27
for <dev@dpdk.org>; Tue, 02 Dec 2014 03:29:28 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
:user-agent:in-reply-to:references:mime-version
:content-transfer-encoding:content-type;
bh=IL18lX4Ri9YJPFndN+bA5OM6sqyv20bLhWw3fCwXhlM=;
b=VeVUyq3e8DrRZQyagWk59/syqPo+q9ErZVvxpNXC9AGecXsH25EYqDKxlMMulnZIO4
Yuvcff4bn7oQdcTeHKYAU5OnlS+wOvI4sn2x6fx3p9/Zo8F10XpfVvqPj/KXQVQ/zXTm
f9y1tDSw33rJzYM+hg4uuUpGBFwv8+GrZ6SPXSKjJIb4XqnRL3dXYw3IdDKnn1/d7j9G
sK9v0mhH4NdcnxATWXYArVQT0Ow7YUS02lIBCzWv45iMjkM1sj74Vx6ip1/JNe8h4wyG
zhd0eDYRSLk2zdJHFI78IR5bi0W2e3rZelwIa3HOH5JE7+L86cA73MDUVHz2IO3t/R8n
xL3A==
X-Gm-Message-State: ALoCoQn8sSEXpJl98YxcHRG5f2clEQI07VNSvLEov/FkhdFWdoKPxClSqzbXuhmZ29zXpsryIkEy
X-Received: by 10.194.61.168 with SMTP id q8mr94689694wjr.53.1417519768753;
Tue, 02 Dec 2014 03:29:28 -0800 (PST)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
[82.239.227.177])
by mx.google.com with ESMTPSA id h13sm46026006wiw.4.2014.12.02.03.29.27
for <multiple recipients>
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Tue, 02 Dec 2014 03:29:27 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>
Date: Tue, 02 Dec 2014 12:28:59 +0100
Message-ID: <7774520.abWCdkbC7k@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <CALwxeUu3w1nJbKedtwSbqZzDvfG8kO5xEEUkSd0Rk13pSjdmWA@mail.gmail.com>
References: <1417455659-24854-1-git-send-email-thomas.monjalon@6wind.com>
<CALwxeUu3w1nJbKedtwSbqZzDvfG8kO5xEEUkSd0Rk13pSjdmWA@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix build with bypass and debug
enabled
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Dec 2014 11:29:29 -0000
> > Since commit aae1047905621 ("use the right debug macro"),
> > DEBUGOUT was replaced by PMD_DRV_LOG which requires at least
> > 2 arguments. But the level argument was missing.
> >
> > Commit 7a10de5e27 fixed the logs but not the macros FUNC_PTR_OR_*
> > which are not preprocessed if RTE_LIBRTE_IXGBE_DEBUG_DRIVER is disabled.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>
> Argh ... good catch.
> Looks like these were the only places with this error (I did some grep and
> only found those).
> And ok with the ERR level, it looks fine to me.
>
> Ack.
Applied
--
Thomas