DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ixgbe: fix RX queue vector fields are not reset properly
@ 2015-07-27 13:28 Konstantin Ananyev
  2015-07-27 13:55 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Konstantin Ananyev @ 2015-07-27 13:28 UTC (permalink / raw)
  To: dev

As Steve pointed out, "ixgbe: fix release queue mbufs" is not complete.
As at queue stop we don't reset vector related rx queue fields to their
initial values.

Reported-by: Cunming Liang <cunming.liang@intel.com>
Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index cbb16b6..a0c8847 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -2400,6 +2400,11 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq)
 	rxq->nb_rx_hold = 0;
 	rxq->pkt_first_seg = NULL;
 	rxq->pkt_last_seg = NULL;
+
+#ifdef RTE_IXGBE_INC_VECTOR
+	rxq->rxrearm_start = 0;
+	rxq->rxrearm_nb = 0;
+#endif
 }
 
 int __attribute__((cold))
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: fix RX queue vector fields are not reset properly
  2015-07-27 13:28 [dpdk-dev] [PATCH] ixgbe: fix RX queue vector fields are not reset properly Konstantin Ananyev
@ 2015-07-27 13:55 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2015-07-27 13:55 UTC (permalink / raw)
  To: Konstantin Ananyev; +Cc: dev

> As Steve pointed out, "ixgbe: fix release queue mbufs" is not complete.
> As at queue stop we don't reset vector related rx queue fields to their
> initial values.
> 
> Reported-by: Cunming Liang <cunming.liang@intel.com>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-27 13:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-27 13:28 [dpdk-dev] [PATCH] ixgbe: fix RX queue vector fields are not reset properly Konstantin Ananyev
2015-07-27 13:55 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).