From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBE5A45A78; Tue, 1 Oct 2024 12:19:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C95B4027E; Tue, 1 Oct 2024 12:19:02 +0200 (CEST) Received: from fhigh-a8-smtp.messagingengine.com (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) by mails.dpdk.org (Postfix) with ESMTP id 0E8064027C for <dev@dpdk.org>; Tue, 1 Oct 2024 12:19:01 +0200 (CEST) Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id 62DA011418A9; Tue, 1 Oct 2024 06:19:00 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Tue, 01 Oct 2024 06:19:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1727777940; x=1727864340; bh=jnHzn4sSD8FdfdaRksZwlPkRmihPHSu8A1WUwGSIx4I=; b= I0Pye8pgfXVXfKFR80udOqyUpfs1aeBYe0OzlFkBiNepccybTedzFaKNs8YXFYxT QqIovc7qTOWrEl0ijYtP0bJEzSzloEu0Nnj26tosJ/j10vCuNAGNjYUboo6Ap+w4 WF2SpSn+gIOjyFpY9LuIOTDgATMEpKaWhwKDQlUjXLzCiQ9Pu0NAX3erKLCZO5KC e/5sLBcWMAAyYGp97OGaux812C6bwQ31gMiBMYuTOm9Muyu7WTcWXeDyanDhp8Kc otvL0Pg+h8pN/plSq+3u7pGq7nvqG/tgcjV0ZsTebjDjr3H/860ZVTDMwCY8CLiS OEjVHL5ad2/rtEofmkqarw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1727777940; x= 1727864340; bh=jnHzn4sSD8FdfdaRksZwlPkRmihPHSu8A1WUwGSIx4I=; b=a hgjvOARJao+dk9JnKVnhE49W76w6Y09SOJtjY5EwpI0H6Rzm03vE75h7S79WOzbz sFGmn3blv4yE6/aA1p4zssXxiVBsoLBpnAR65ynmSj8uzDPIGjAaaAP7snrN438T wPzI0khqfQZhFL3IfBbHtb6jo92RFyXJkTp2HD3gtGkChxNWoqprEIXnhK/+I5hv IMwdY+WDBDZl8R9yIuYNDWD/j08xfHzvp796jtE7qeHLK0tfBNT9DMKVjXnAGOWV VvoiR9gLjE97Dyzcn2+CDINUtXvHa1U0nBu6bUiAC7yE4GNMpdZ4t8tlLtwUduHQ 9ld70FW2ScJ+uRPSN/7LQ== X-ME-Sender: <xms:k8z7ZsVb3nziqEa7WB5t_KU7ZhJZkigg44-3PHzB48GltFfs_Wp15A> <xme:k8z7Zgktsqg9-bkKqrEVaDiXqThML-KyUetOn4w8FmCOo-bZ-rRlpV56LsTeTL2Nl Muut3XCdmSkhzHXPQ> X-ME-Received: <xmr:k8z7Zgab_zGkF4DSODwM3Or4wx53_zqiS7qLGv8rbMQKNbEKVGjiADwxbF6mtdxjBxdmk19YROXaCX85ofW_jMdMyg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddujedgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegurghvih gurdhmrghrtghhrghnugesrhgvughhrghtrdgtohhmpdhrtghpthhtohepuggvvhesughp ughkrdhorhhgpdhrtghpthhtohephhgvmhgrnhhtrdgrghhrrgifrghlsehngihprdgtoh hmpdhrtghpthhtohepshgrtghhihhnrdhsrgigvghnrgesnhigphdrtghomh X-ME-Proxy: <xmx:lMz7ZrXRh1Gfzk6YPBc6yT_3FMF48Ty0vKXAdknXfjQI8lFf09fFsA> <xmx:lMz7ZmmsXEJomfR4-UF23edxn82XbtolpSjLC3aY2iB5wjCB1OZiMA> <xmx:lMz7ZgdbDgTP-M93sB87-gHmzaXZUGu3GJxfKVe7yTEFZYjONTkHWw> <xmx:lMz7ZoGd9g4zTTMD_JtxWlt4Ch3Vfg_5Gv3JwBTVC6U6u1QWLpd7gQ> <xmx:lMz7ZnD7M1FeODv8TZL_euj5ot9XOaH2TTajNmrlNC9zQYSaDd2Ca1tD> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Oct 2024 06:18:59 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: David Marchand <david.marchand@redhat.com> Cc: dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena <sachin.saxena@nxp.com> Subject: Re: [PATCH v2 03/14] net/dpaa: remove broken debug macros Date: Tue, 01 Oct 2024 12:18:57 +0200 Message-ID: <7782369.EvYhyI6sBW@thomas> In-Reply-To: <20240912082643.1532679-4-david.marchand@redhat.com> References: <20240907145433.1479091-1-david.marchand@redhat.com> <20240912082643.1532679-1-david.marchand@redhat.com> <20240912082643.1532679-4-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 12/09/2024 10:26, David Marchand: > Those debug macros never worked as existing callers never passed a > 'level' argument. > Remove them. > > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > drivers/net/dpaa/fmlib/fm_ext.h | 21 ++------------------- > 1 file changed, 2 insertions(+), 19 deletions(-) > > diff --git a/drivers/net/dpaa/fmlib/fm_ext.h b/drivers/net/dpaa/fmlib/fm_ext.h > index 8e7153bdaf..4666fa3b0b 100644 > --- a/drivers/net/dpaa/fmlib/fm_ext.h > +++ b/drivers/net/dpaa/fmlib/fm_ext.h > @@ -15,25 +15,8 @@ > #define MODULE_FM 0x00010000 > #define __ERR_MODULE__ MODULE_FM > > -/* #define FM_LIB_DBG */ > - > -#if defined(FM_LIB_DBG) > - #define _fml_dbg(fmt, args...) \ > - rte_log(RTE_LOG_ ## level, dpaa_logtype_pmd, "fmlib:%s(): " fmt "\n", \ > - __func__, ##args) > -#else > - #define _fml_dbg(arg...) > -#endif > - > -/*#define FM_IOCTL_DBG*/ > - > -#if defined(FM_IOCTL_DBG) > - #define _fm_ioctl_dbg(fmt, args...) \ > - rte_log(RTE_LOG_ ## level, dpaa_logtype_pmd, "fmioc:%s(): " fmt "\n", \ > - __func__, ##args) > -#else > - #define _fm_ioctl_dbg(arg...) > -#endif > +#define _fml_dbg(...) > +#define _fm_ioctl_dbg(...) Why not removing the calls to these macros?