From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by dpdk.org (Postfix) with ESMTP id C6F655901 for ; Wed, 12 Nov 2014 10:21:03 +0100 (CET) Received: by mail-ee0-f44.google.com with SMTP id e49so1775eek.31 for ; Wed, 12 Nov 2014 01:30:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Wv91YU8jB2D3MVjV0CMBhEePuHrFpKXTKkGIiVcKeYs=; b=eEkYoZ7ToQrHuETCOnJg0ciGLRv1C0Xxus7cOBUVcgvXebESLD/0HMD+gGoE8QEP5S Szhmf2/UznjpkwQ7FTBou3uAg/ep7sVMHUFdrLf3iT1sjL3i4/aYdzhaLlGuzZExExQA HIqyTvazLcRp4BlNvhjqvGA/8NHINYjonNf5zfz+i/sYDqOKZhd6KXFWEpqoPUTg2LdX btxMgaWEQQjYZQp4Q1H8AVA4K9v93xIAphtsEKXIWnZ85N/RdMxLpRVgGCriJu6cuSKl lMyX/0gsk/5oqJ1XKeU9WaJhn/1rD39PGV0hAEZF1Lf8uYtAz9QauL2DWstIW0TgLsJy ZWOQ== X-Gm-Message-State: ALoCoQkMXTsATbjLKDxOa0mOaSLvs9Lewgqiz8UhyaEy/8N/RdbP8IQ2XafV7WBjgvIysx+hnMeD X-Received: by 10.180.95.201 with SMTP id dm9mr47158294wib.27.1415784657221; Wed, 12 Nov 2014 01:30:57 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id gs9sm30627158wjc.47.2014.11.12.01.30.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Nov 2014 01:30:56 -0800 (PST) From: Thomas Monjalon To: "Zhang, Helin" Date: Wed, 12 Nov 2014 10:30:39 +0100 Message-ID: <7782514.0Lq6O9Rqxb@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <1413180766-12211-1-git-send-email-helin.zhang@intel.com> <1639194.lo0Mfvn8hI@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 2/5] ethdev: add enum type and relevant structures for hash filter control X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Nov 2014 09:21:04 -0000 2014-11-12 05:52, Zhang, Helin: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Actually you use ETH_FLOW_TYPE_IPV4 for ixgbe and > > ETH_FLOW_TYPE_FRAG_IPV4 or ETH_FLOW_TYPE_NONFRAG_IPV4_* for i40e. > > It's not consistent and clearly shows that you stick to the hardware definitions. > > > > Something really generic could be a set of flags like this: > > IPV4 > > IPV6 > > NONFRAG > > UDP > > TCP > > SCTP > > Good conclusion! We could think of it in a new patch set. > I don't want to put everything into this patch. :) If you agree flags must be used, the old defines must be removed. So no need to rename the defines. I think you should directly change to flags (in this patchset or another). Thanks -- Thomas