From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arybchenko@solarflare.com>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 8B9F76D45
 for <dev@dpdk.org>; Mon, 11 Sep 2017 15:10:15 +0200 (CEST)
Received: from pure.maildistiller.com (dispatch1.mdlocal [10.7.20.164])
 by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with
 ESMTP id E49A86007D; Mon, 11 Sep 2017 13:10:14 +0000 (UTC)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from mx4-us4.ppe-hosted.com (filterqueue.mdlocal [10.7.20.246])
 by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
 B871710006D; Mon, 11 Sep 2017 13:10:13 +0000 (UTC)
Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx4-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
 77A06B8009C; Mon, 11 Sep 2017 13:10:13 +0000 (UTC)
Received: from [192.168.38.17] (84.52.114.114) by ocex03.SolarFlarecom.com
 (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 11 Sep
 2017 06:10:10 -0700
To: Shahaf Shuler <shahafs@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>
References: <cover.1504508374.git.shahafs@mellanox.com>
 <cover.1505044395.git.shahafs@mellanox.com>
 <ce7981e06173fc681d5fdf165eef22c602211a5d.1505044395.git.shahafs@mellanox.com>
 <7d33e540-1b42-2200-56e0-039504083419@solarflare.com>
 <VI1PR05MB314976D2480161781C4DE273C3680@VI1PR05MB3149.eurprd05.prod.outlook.com>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <778534f1-b707-97b1-884d-9afd57fbdbfb@solarflare.com>
Date: Mon, 11 Sep 2017 16:10:07 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <VI1PR05MB314976D2480161781C4DE273C3680@VI1PR05MB3149.eurprd05.prod.outlook.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
X-Originating-IP: [84.52.114.114]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ocex03.SolarFlarecom.com (10.20.40.36)
X-MDID: 1505135414-WZKwtFayC7ye
Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads
	API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Sep 2017 13:10:15 -0000

On 09/11/2017 03:27 PM, Shahaf Shuler wrote:
>
> September 11, 2017 11:03 AM, Andrew Rybchenko:
>
>     +/**
>
>     + * A conversion function from txq_flags API.
>
>     + */
>
>     +static void
>
>     +rte_eth_convert_txq_flags(const uint32_t txq_flags, uint64_t *tx_offloads)
>
>
> Maybe tx_offlaods should be simply return value of the function 
> instead of void.
> Similar comment is applicable to rte_eth_convert_txq_offloads().
>
> Can you elaborate why it would be better?
>

It is a pure converter function and it would avoid questions like:
Is tx_offloads an output only or input/output parameter?
Yes, the function is tiny and it is easy to find the answer, but still.

Also it would make it possible to pass the result to other function
call without extra variables etc.
Yes, right now usage of the function is very limited and hopefully
it will not live long, so it is not that important. Definitely up to you.