From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BC7FA0A0A; Tue, 23 Mar 2021 19:38:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CEE6040683; Tue, 23 Mar 2021 19:38:55 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 9AA0C4014D for ; Tue, 23 Mar 2021 19:38:54 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 6619BFDE; Tue, 23 Mar 2021 14:38:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 23 Mar 2021 14:38:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 0H5YIWp0QYmhFScPEQOmxdc+itT0Wr8vnAsMbSX69Ro=; b=hsmx/6Fozh6eAgFa FTls/BY90XsH4HsCSVJ2DKYR5W+v2ZHT/NNq3NyqWQ+drpmn0vjymLuJpWyiMxZT A3uKa3mk0clLJR923lTx1zNzY11xFtUEkHLPzQb+CfZD2xbJPUZjYxOO6v6M24pY yf1jSjqLZ+X90gHRqHf2o4hpy5OKzqY5sMpA/oiUEpjajEtuuWQ8bDdel2EAcXOO KNVbQqjkCwRLQ1zRqHrQ3NJ/a/we6hiY4G2oGq606e5Sg2IVkXVzYQALBLOY1o1p B48el1tEtPUKdrjltA4avkTCwaDXhOzKQBfWMbSAimG/eRm52Jm8n4kTZlFgJSlJ TDPtYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=0H5YIWp0QYmhFScPEQOmxdc+itT0Wr8vnAsMbSX69 Ro=; b=VYq4W83wSADdOjCh+a13iI3H4K3u6Tc7xl1i7OlgFHly//iN3l96JonJ5 Nqt/KvzxjwqDAYJnrqK+dCCsLT2Ji/KEqkkQYUZGIMlo3uHxOC1l+8k98Mb1ku6t xw4Z9RjHd/XWCJTo7N0h0oc0ifsBm2+MbPdHp51kguogEKq5wkKN+hmVHXhKE0Xw 4SPrOFGG326cWnzXEolJxjBX4g1nSSyVp/VyG1Uz7dZ6AnT3x7B7LqRe9vveJxVr neDauNrwoIFfkZfo+qfQQFja0+52ug6QKoiT3It4XndAv+JeRMO/Mh/Qe2Tk+44x 4Tw9vXzS8XsvHRoqxhYsxBsmBe2DA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegiedgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0A7C3240423; Tue, 23 Mar 2021 14:38:51 -0400 (EDT) From: Thomas Monjalon To: "P, Venkata Suresh Kumar" , "Dumitrescu, Cristian" Cc: "dev@dpdk.org" , "Khangar, Churchill" , "Jangra, Yogesh" Date: Tue, 23 Mar 2021 19:38:50 +0100 Message-ID: <7787288.vlQI503CXK@thomas> In-Reply-To: References: <1616155326-2639-1-git-send-email-venkata.suresh.kumar.p@intel.com> <6532294.cV1ATAUDhe@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/03/2021 19:07, P, Venkata Suresh Kumar: > Thanks a lot for reviewing the code and providing your comments. > > I have addressed below comments in V2 patch. OK thanks. What about the question about rte_trace? Opinions? > From: Thomas Monjalon > 19/03/2021 13:02, Venkata Suresh Kumar P: > > Add the file descriptor input/output port type for the SWX pipeline. > > I think it deserves a bit more explanation about what is FD I/O port. -- [Suresh] - Addressed in V2 patch > > > /* > > + * tap > > + */ > > +#define TAP_DEV "/dev/net/tun" > > Spaces are free :) -- [Suresh] - Addressed in V2 patch > > > > +#ifndef TRACE_LEVEL > > +#define TRACE_LEVEL 0 > > +#endif > > + > > +#if TRACE_LEVEL > > +#define TRACE(...) printf(__VA_ARGS__) #else #define TRACE(...) > > +#endif > > Would you consider rte_trace? > > > --- /dev/null > > +++ b/lib/librte_port/rte_swx_port_fd.h > > @@ -0,0 +1,57 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2016 Intel Corporation > > I guess you did not create it in 2016. -- [Suresh] - Addressed in V2 patch > > > + */ > > + > > +#ifndef __INCLUDE_RTE_SWX_PORT_FD_H__ #define > > +__INCLUDE_RTE_SWX_PORT_FD_H__ > > + > > +#ifdef __cplusplus > > +extern "C" { > > +#endif > > + > > +/** > > + * @file > > + * RTE SWX FD Input and Output Ports > > + * > > + ***/ > > Useless blank line. -- [Suresh] - Addressed in V2 patch > > [...] > > + > > +#ifdef __cplusplus > > +} > > +#endif > > + > > +#endif > > A comment after such a far #endif is better: -- [Suresh] - Addressed in V2 patch > /* __INCLUDE_RTE_SWX_PORT_FD_H__ */ > > > --- a/lib/librte_port/version.map > > +++ b/lib/librte_port/version.map > > @@ -48,4 +48,6 @@ EXPERIMENTAL { > > #added in 21.02 > > In 21.05 > > > rte_swx_port_ring_reader_ops; > > rte_swx_port_ring_writer_ops; > > + rte_swx_port_fd_reader_ops; > > + rte_swx_port_fd_writer_ops; > > Please sort in alphabetical order. -- [Suresh] - Addressed in V2 patch