From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Nicolas Chautru <nicolas.chautru@intel.com>, dev@dpdk.org
Cc: hernan.vargas@intel.com, stable@dpdk.org
Subject: Re: [PATCH v1 1/1] baseband/acc: fix queue setup failure clean up
Date: Wed, 12 Mar 2025 16:27:56 +0100 [thread overview]
Message-ID: <7798878e-8eab-44ba-a95e-9365fd180ec0@redhat.com> (raw)
In-Reply-To: <5a54acd0-1cee-46c2-8b94-37a2bbd581bd@redhat.com>
On 3/12/25 2:48 PM, Maxime Coquelin wrote:
>
>
> On 3/5/25 7:27 PM, Nicolas Chautru wrote:
>> Incomplete clean up for vrb2 variant when queue setup fails
>> to complete successfully.
>>
>> Fixes: fc65d3dcabe01 ("baseband/acc: refactor queue allocation")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
>> ---
>> drivers/baseband/acc/rte_vrb_pmd.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/
>> acc/rte_vrb_pmd.c
>> index 27620ccc10..2c10ef2c94 100644
>> --- a/drivers/baseband/acc/rte_vrb_pmd.c
>> +++ b/drivers/baseband/acc/rte_vrb_pmd.c
>> @@ -1156,6 +1156,8 @@ vrb_queue_setup(struct rte_bbdev *dev, uint16_t
>> queue_id,
>> free_q:
>> rte_free(q);
>> q = NULL;
>> + if (d->device_variant == VRB2_VARIANT)
>> + d->queue_index[conf->op_type]--;
>> return ret;
>> }
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> Thanks,
> Maxime
>
Applied to next-baseband.
Thanks,
Maxime
prev parent reply other threads:[~2025-03-12 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 18:27 [PATCH v1 0/1] " Nicolas Chautru
2025-03-05 18:27 ` [PATCH v1 1/1] " Nicolas Chautru
2025-03-06 2:59 ` Patrick Robb
2025-03-12 13:48 ` Maxime Coquelin
2025-03-12 15:27 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7798878e-8eab-44ba-a95e-9365fd180ec0@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).