From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52B75A04DD; Thu, 19 Nov 2020 18:48:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 10AB8DED; Thu, 19 Nov 2020 18:48:47 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id EF64E2AB for ; Thu, 19 Nov 2020 18:48:44 +0100 (CET) IronPort-SDR: ysPSA+L6ettv6RYBn11hxiLI727F03qRIMsClH1hMWJgOSRQA/09jjO1MNZLYaRo9SqdA/l6q8 XsdN0cIUW2Bg== X-IronPort-AV: E=McAfee;i="6000,8403,9810"; a="159103003" X-IronPort-AV: E=Sophos;i="5.78,353,1599548400"; d="scan'208";a="159103003" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2020 09:48:42 -0800 IronPort-SDR: RgrD0VXPYZqk9heum1zAkrAPOuZhAdoLedQ62bGdaGEEmjlMXr/1trZRRpF8ehqqs8yPXeK8ZY v4lkrEV9FruQ== X-IronPort-AV: E=Sophos;i="5.78,353,1599548400"; d="scan'208";a="360094732" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.20.82]) ([10.252.20.82]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2020 09:48:40 -0800 To: Raslan Darawsheh , matan@nvidia.com Cc: viacheslavo@nvidia.com, thomas@monjalon.net, =?UTF-8?Q?Beno=c3=aet_Ganne?= , dev@dpdk.org References: <20200327172449.6514-1-bganne@cisco.com> <20201119142018.25277-1-rasland@nvidia.com> From: Ferruh Yigit Message-ID: <77998079-5ad7-edc4-1153-c318e11c25d0@intel.com> Date: Thu, 19 Nov 2020 17:48:37 +0000 MIME-Version: 1.0 In-Reply-To: <20201119142018.25277-1-rasland@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/19/2020 2:20 PM, Raslan Darawsheh wrote: > From: Benoît Ganne > > mlx5 PMD refuses to update link state if link speed is defined but > status is down or if link speed is undefined but status is up, even if > the ioctl() succeeded. > This prevents application to detect link up/down event, especially when > the link speed is not correctly detected. > As link speed is nice to have whereas link status is mandatory for > operations, always update link state regardless of link speed. The > application can then check link speed if needs be. > Hi Raslan, Matan, Can you please provide the Fixes tag? Also should this fix backported? > Signed-off-by: Benoît Ganne > Signed-off-by: Raslan Darawsheh <...>