From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6151FA0524; Tue, 1 Jun 2021 13:12:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CDAE40689; Tue, 1 Jun 2021 13:12:31 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 6E7B140041 for ; Tue, 1 Jun 2021 13:12:29 +0200 (CEST) IronPort-SDR: cQrk54xfqwv+0T1OhqDneyznTL5S6VIgIlGoIlwzxrTybAuWqgCWQIokr9UZdBxXfLaYT7Qv64 PntpcRpKMoAg== X-IronPort-AV: E=McAfee;i="6200,9189,10001"; a="201656225" X-IronPort-AV: E=Sophos;i="5.83,239,1616482800"; d="scan'208";a="201656225" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2021 04:12:26 -0700 IronPort-SDR: t1Lj/qbYhcIqZ/18bzqxw9D1pdY33FAk2wWGZ/58v0FOphy9bGmO8c8VyS2eUsGmFtNhDu22uu L2gXYqoiW0WQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,239,1616482800"; d="scan'208";a="411200214" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga007.fm.intel.com with ESMTP; 01 Jun 2021 04:12:26 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 1 Jun 2021 04:12:26 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 1 Jun 2021 19:12:24 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.008; Tue, 1 Jun 2021 19:12:24 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Yang, SteveX" , "dev@dpdk.org" Thread-Topic: [PATCH v1] net/i40e: fix flow director does not work Thread-Index: AQHXUE2AkU+cTbAxRkO/47LVRgof/ar/DVGA Date: Tue, 1 Jun 2021 11:12:23 +0000 Message-ID: <77a465750fe547be9845e08f47e47a01@intel.com> References: <20210519032745.707639-1-stevex.yang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: fix flow director does not work X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Xing, Beilei > Sent: Monday, May 24, 2021 11:33 AM > To: Yang, SteveX ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: fix flow director does not w= ork >=20 >=20 >=20 > > -----Original Message----- > > From: Yang, SteveX > > Sent: Wednesday, May 19, 2021 11:28 AM > > To: dev@dpdk.org > > Cc: Xing, Beilei ; Yang, SteveX > > > > Subject: [PATCH v1] net/i40e: fix flow director does not work > > > > When user configured the flow rule with raw packet via command > > "flow_director_filter", it would reset all previous fdir input set > > flags with "i40e_flow_set_fdir_inset()". > > > > Ignore to configure the flow input set with raw packet rule used. > > > > Fixes: ff04964ea6d5 ("net/i40e: fix flow director for common pctypes") > > > > Signed-off-by: Steve Yang > > --- > > drivers/net/i40e/i40e_fdir.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_fdir.c > > b/drivers/net/i40e/i40e_fdir.c index > > ac0e09bfdd..3c7cf1ba90 100644 > > --- a/drivers/net/i40e/i40e_fdir.c > > +++ b/drivers/net/i40e/i40e_fdir.c > > @@ -1768,7 +1768,8 @@ i40e_flow_add_del_fdir_filter(struct rte_eth_dev > > *dev, > > > > if (add) { > > /* configure the input set for common PCTYPEs*/ > > - if (!filter->input.flow_ext.customized_pctype) { > > + if (!filter->input.flow_ext.customized_pctype && > > + !filter->input.flow_ext.pkt_template) { > > ret =3D i40e_flow_set_fdir_inset(pf, pctype, > > filter->input.flow_ext.input_set); > > if (ret < 0) > > -- > > 2.27.0 >=20 > Acked-by: Beilei Xing Applied to dpdk-next-net-intel. Thanks Qi