From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A78D02B95 for ; Tue, 15 Jan 2019 17:08:52 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2019 08:08:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,481,1539673200"; d="scan'208";a="138488701" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.251.85.93]) ([10.251.85.93]) by fmsmga001.fm.intel.com with ESMTP; 15 Jan 2019 08:08:50 -0800 To: Xiaolong Ye , dev@dpdk.org, Ferruh Yigit References: <20190115154626.34516-1-xiaolong.ye@intel.com> From: "Burakov, Anatoly" Message-ID: <77b04e1c-e4e1-1b34-910e-c1655b8d0f8e@intel.com> Date: Tue, 15 Jan 2019 16:08:49 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190115154626.34516-1-xiaolong.ye@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove out-of-date comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 16:08:53 -0000 On 15-Jan-19 3:46 PM, Xiaolong Ye wrote: > The comment for igbuio_pci_irqhandler is out of date as the code evolves, > remove it to avoid misleading. > > Signed-off-by: Xiaolong Ye > --- > kernel/linux/igb_uio/igb_uio.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c > index 3cf394bdf..7e69b4498 100644 > --- a/kernel/linux/igb_uio/igb_uio.c > +++ b/kernel/linux/igb_uio/igb_uio.c > @@ -185,11 +185,6 @@ igbuio_pci_irqcontrol(struct uio_info *info, s32 irq_state) > return 0; > } > > -/** > - * This is interrupt handler which will check if the interrupt is for the right device. > - * If yes, disable it here and will be enable later. > - */ > -static irqreturn_t > igbuio_pci_irqhandler(int irq, void *dev_id) > { > struct rte_uio_pci_dev *udev = (struct rte_uio_pci_dev *)dev_id; > I think you removed one extra line there... -- Thanks, Anatoly