From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: haiyue.wang@intel.com, Anoob Joseph <anoobj@marvell.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Liron Himi <lironh@marvell.com>,
Harman Kalra <hkalra@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] drivers/common: mark symbols as internal
Date: Wed, 2 Sep 2020 15:34:27 +0100 [thread overview]
Message-ID: <77bac50b-7d3d-efab-116b-721f9c0c6822@intel.com> (raw)
In-Reply-To: <20200902095957.19121-1-david.marchand@redhat.com>
On 9/2/2020 10:59 AM, David Marchand wrote:
> Now that we have the internal tag, let's avoid confusion with exported
> symbols in common drivers that were using the experimental tag as a
> workaround.
> There is also no need to put internal API symbols in the public stable
> ABI.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Note: I noticed a patch from Haiyue for iavf.
> I am fine with reposting per driver, but it seems worth a tree-wide
> change from my pov.
>
> ---
> drivers/common/cpt/cpt_pmd_ops_helper.h | 8 +++++---
> drivers/common/cpt/rte_common_cpt_version.map | 13 +++----------
> drivers/common/iavf/iavf_prototype.h | 8 ++++++++
> drivers/common/iavf/rte_common_iavf_version.map | 2 +-
iavf one sent as separate patch [1] and applied to next-net [2].
[1]
https://patches.dpdk.org/patch/75564/
[2]
https://git.dpdk.org/next/dpdk-next-net/commit/?h=main&id=f59221bda2ad1f7aa118dc41d6bac4bd3a3d4654
> drivers/common/mvep/rte_common_mvep_version.map | 2 +-
> drivers/common/mvep/rte_mvep_common.h | 3 +++
> drivers/common/octeontx/octeontx_mbox.h | 5 +++++
> .../common/octeontx/rte_common_octeontx_version.map | 2 +-
> 8 files changed, 27 insertions(+), 16 deletions(-)
<...>
next prev parent reply other threads:[~2020-09-02 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 9:59 David Marchand
2020-09-02 10:10 ` [dpdk-dev] [EXT] " Anoob Joseph
2020-09-02 14:34 ` Ferruh Yigit [this message]
2020-10-01 7:55 ` [dpdk-dev] [PATCH v2] drivers/common: mark all " David Marchand
2020-10-01 8:00 ` Kinsella, Ray
2020-10-05 23:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77bac50b-7d3d-efab-116b-721f9c0c6822@intel.com \
--to=ferruh.yigit@intel.com \
--cc=anoobj@marvell.com \
--cc=beilei.xing@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=hkalra@marvell.com \
--cc=jingjing.wu@intel.com \
--cc=lironh@marvell.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).