From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E854637B3; Wed, 12 Oct 2016 18:24:57 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP; 12 Oct 2016 09:24:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,336,1473145200"; d="scan'208";a="18884765" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.83]) ([10.237.220.83]) by fmsmga005.fm.intel.com with ESMTP; 12 Oct 2016 09:24:56 -0700 To: "John W. Linville" , dev@dpdk.org References: <1475090404-20707-1-git-send-email-linville@tuxdriver.com> <1475170776-10130-1-git-send-email-linville@tuxdriver.com> <1475170776-10130-2-git-send-email-linville@tuxdriver.com> Cc: dpdk stable From: Ferruh Yigit Message-ID: <77c1db16-d7cb-7f93-c498-565029b6a0b6@intel.com> Date: Wed, 12 Oct 2016 17:24:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1475170776-10130-2-git-send-email-linville@tuxdriver.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] net/ena: improve safety of string handling in ena_config_host_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 16:24:58 -0000 On 9/29/2016 6:39 PM, John W. Linville wrote: > Use sizeof dest rather than sizeof src for limiting copy length, > and replace strncpy with snprintf to ensure NULL termination. > > Coverity issue: 127795 > Fixes: 372c1af5ed8f ("net/ena: add dedicated memory area for extra device info") > > Signed-off-by: John W. Linville > --- Acked-by: Ferruh Yigit