From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id 6CD929161 for ; Fri, 1 Sep 2017 10:07:57 +0200 (CEST) Received: by mail-wr0-f174.google.com with SMTP id 40so4354346wrv.5 for ; Fri, 01 Sep 2017 01:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=Xv1bEt7l5iMvtthcMLKHWukQ/74O2vVY75Cr8JxulU8=; b=vbrqZt41D1HR3ZWUc+DKzYqM2lvNAL+sRfVWYwZ8vtFNQZwtGZepNKR8oWl/ditaY4 QYscKAEjZxZvCjU0UYbBDjgvIFldswjpWR65+/C9hYK5T0MmUH3/lbjDJFMZTDXwM66G LT1gx82RubEW7HakbPUwyQIZymREnsmWeCee2yGICmZJ0aRlXVTNSsRIYNlrXHnBikIq 9c3f9XFIPQUQ2MSqY3K+q4qHTeeYT5sRZFd02PDRw2P+1xBCs7qP2jr9wUPlsKvjmSnN UzqFKm1d49V9bo7IVu2gCi3b2i3BVjSV0v8hYyxuwYQylxUWmu0iHMj/JZOl3RF9hF10 O0wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=Xv1bEt7l5iMvtthcMLKHWukQ/74O2vVY75Cr8JxulU8=; b=U4sboRtyXVUYpjuRwqdEBvag1z0I65S0xULUz45WpS5pO5xYRZj+Erk1sLAnV76Qct R37IxU3AS4WaIxDGKnQXFgfCObjMsSxws0xhZ98ZTkY1NJu+n8ZgkrwciM/k1ZIDbO5j jyetrvHXKdaRHGaC0uZ4EJzk0C96oM2+9x6oVe8OAf18XBEJ4qT2ZINQXFDTOOQdi15h 8jMcNIYtlbQNJtQt9p70jnJosQjK7LOqJbmYl1ZTrqVpFe8QUXQ5jJB+olSTLTAi1JR6 dYGOj+JEAJ10DVod7znLb8e9tcNUvaNJOidOcGQJw3kTK1itk9vJqkHqV88cwAGDSoW7 j2Lw== X-Gm-Message-State: AHPjjUjhIbBxysgECk4c7J+pJgHT34hpiPEqzatiPJ47fJ1xqoysZv8h 2ZGMlEFmT2lcEvyx43M= X-Google-Smtp-Source: ADKCNb5ztt53NsYy1SoyACjzG6S58/mancNK21CPUgrqUI/PlXX54E28GOhOl1bobSqol9OfzQdqRw== X-Received: by 10.223.129.200 with SMTP id 66mr53336wra.25.1504253276979; Fri, 01 Sep 2017 01:07:56 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l9sm1287049wre.48.2017.09.01.01.07.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Sep 2017 01:07:56 -0700 (PDT) From: Adrien Mazarguil To: dev@dpdk.org Date: Fri, 1 Sep 2017 10:06:42 +0200 Message-Id: <77d39386243f16a21701c2ec899b42968f860b2a.1504252977.git.adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2 27/51] net/mlx4: simplify link update function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 08:07:57 -0000 Returning a different value when the current link status differs from the previous one was probably useful at some point in the past but is now meaningless; this value is ignored both internally (mlx4 PMD) and externally (ethdev wrapper). Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index 1208e7a..9694170 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -2476,13 +2476,8 @@ mlx4_link_update(struct rte_eth_dev *dev, int wait_to_complete) ETH_LINK_HALF_DUPLEX : ETH_LINK_FULL_DUPLEX); dev_link.link_autoneg = !(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); - if (memcmp(&dev_link, &dev->data->dev_link, sizeof(dev_link))) { - /* Link status changed. */ - dev->data->dev_link = dev_link; - return 0; - } - /* Link status is still the same. */ - return -1; + dev->data->dev_link = dev_link; + return 0; } /** -- 2.1.4