From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0051.outbound.protection.outlook.com [104.47.2.51]) by dpdk.org (Postfix) with ESMTP id 9003B1B1D0 for ; Tue, 13 Feb 2018 04:46:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GP8nH+NYqzYs4HOw2PXZT4TkHVZlQkvit79W6azFwZE=; b=EFixQbYxc6iYmsuXNrQ9EIUTh6TW/yXY+AsDTmnxDfh169R+yQj2eaUgUSkajeqsVmWt1PA6WLbd0JssOD13bSq7lPrJRHtonC78Etm3CpaxHYJOtc7RxEKUicAzjlCn8JPQibwkrbFGNXyB6nGNyTGvLYfKFHn759wXy+AiCXU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from [192.168.1.3] (122.180.38.90) by AM2PR04MB0753.eurprd04.prod.outlook.com (2a01:111:e400:8411::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Tue, 13 Feb 2018 03:46:36 +0000 To: Pavan Nikhilesh , ferruh.yigit@intel.com, cristian.dumitrescu@intel.com, harry.van.haaren@intel.com, nhorman@tuxdriver.com, jerin.jacob@caviumnetworks.com, thomas.monjalon@6wind.com Cc: dev@dpdk.org References: <20180212142305.18557-1-pbhagavatula@caviumnetworks.com> From: Hemant Agrawal Message-ID: <77d5c43b-54c1-6f66-d9c3-103d56473def@nxp.com> Date: Tue, 13 Feb 2018 09:16:21 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180212142305.18557-1-pbhagavatula@caviumnetworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [122.180.38.90] X-ClientProxiedBy: PN1PR0101CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::13) To AM2PR04MB0753.eurprd04.prod.outlook.com (2a01:111:e400:8411::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: e9681d6b-08cb-47f8-323e-08d5729462d4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:AM2PR04MB0753; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0753; 3:oJ7XMETgWwSC3GxGvIqU0JsPboOlc/85rhFzScMuI5L/cQblt9JDYm7fyN+uh/ZTILarDC3Mb5j9Xqyf35RDs8maIyfRBOx8/DHVgsoc67SzRbPOY/4IWFYHRpELtBF4z0wzQS2+x5pu64kO/kCmWu7SDCnaLL9IhATuqZj28WbTy3oggy9u36VE0XjEXqJx95A2ODuc/THlnaPCoU1buxs3zOlQ1bTsB6paYAfT/6BcsY/c2JYlZIG/SdVbca3i; 25:P3C3klV+NvBdZD8Lenw+obuUxqt5Hm/1ZVbEeJ/NcsTw3XIigWkgQaJvlEe3YisWKARdqdmSdXuhuUy4aCUJlf5x0gf9sN+UA2hyWkES8sNtsAgIid/MZahJF7sI6rNKI+yX8ZXi8AdtGMPsG8M/PxoKCD/hTWVXpnKysyAbhmtebdxhQeazdKVWY484ZIPFMFdM/DC/FCsv4LOZgudHLiWM2igU1IDU9LUWxqhLo5BDjD2Ewjst0w65ZImxd0lqjU9bMpUyJT0Zf6qXRkb8bMDWNu9diNYsI/vrvG4nUs31joIVI0i+93/yNHyw2rcnnYMU4sJef8WIhbM//q4d8w==; 31:/esadP3RY4XRtMK+YD7BlSYStWitHFz6IMQx5KD+e/xpAM8XzRMI59+oigc7luYjXLdsw7lY1pXl3jGLjEDsOOyLJAEMj/K4pTdaz6Vf3KqX1AGAKamHlBrL+8t/29/VT/QoTwqucj+HPlRQQSIp/7166uyJdApBTNRz5r04zyk6n0hZ2uhsPpzm2YnyRcYMuiC/8kc5WhEUqnFO+eiEHSnxwMAa/rgastRKHNv6A44= X-MS-TrafficTypeDiagnostic: AM2PR04MB0753: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0753; 20:nXE9MumK7BacAh8jeAu0PQ2xE0MHSVcVPAYuhIjNOnCLK8zVDvunzEUK4yiLUWezh+iPYlNTclCuYtpBdnSzqM3GSrdD/EjyQcUKqk5+JVbtajapPJXs8J+DAGcDlbl3xYtLHF/ebTyRAoc2363ADeNhX3EqnWQ0cNzKN6tsD/Z96uZJrDWq0NqQZ06elKGmcB21w1UJtcZ0x+lZVaU9S90h2XPM5O5qlSUUvDc8Mni+jw1oELsa92e7smO9ximQigmzfTXX2w+haDH1++C0fhtPQfDWai2L2HOlwapseuGYc1tPx/+vdvQMe+x4duHNzPHFp5PabqLHAbtDXvRONUtVyQSyPtXuvboA2MxeK/vGUrVE9jYhre8XjKkOY11qSHCe0wp+afFqGiRGdD7WB0IozHtkPOWmRnvxF6TGI4UrDjwA8PE16KxnWgyHYIFxK8eymwXE4/aMSTbMnwB35xjKvTIgi8/8Wh5CKOnQvYsUb9mdD/eYTMfuV4DBeMm1; 4:vYqz/Z0ee04TzcufDltn7lr/pfk0uw+GHc/IJVTg+jsfKKAfNd2/dXMdxGrEmNe2ES07iBtfWhC1pkC/mT8yfu9Wj0JEeSfL/CCA6sgLnHPCkzYYTpIzisgN5wL4lab7r/Ev0Lzp6ZbQl3Qg4o4I7bxDSpNbrUiNs6H4ECjRmtM2wEG0kVAz6/zk3KQGeFIe8HvN9YuU6lvy3qHqN6JQ8VtodoXw4sR5aAr60S8duXHV8suoVwlIftk2l+XE5h8fuM8E3RHMuhq92HYeANh4vg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231101)(944501161)(6055026)(6041288)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:AM2PR04MB0753; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0753; X-Forefront-PRVS: 0582641F53 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(366004)(396003)(346002)(376002)(39860400002)(39380400002)(189003)(199004)(105586002)(6116002)(2906002)(3846002)(64126003)(86362001)(575784001)(230700001)(47776003)(65956001)(65806001)(66066001)(7736002)(305945005)(50466002)(6486002)(53936002)(4326008)(36756003)(25786009)(6246003)(31686004)(117156002)(106356001)(76176011)(5660300001)(68736007)(53546011)(386003)(77096007)(26005)(16526019)(186003)(52146003)(23676004)(31696002)(67846002)(52116002)(2486003)(83506002)(97736004)(2950100002)(8936002)(65826007)(8676002)(81156014)(81166006)(229853002)(58126008)(6666003)(316002)(478600001)(16576012); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0753; H:[192.168.1.3]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTJQUjA0TUIwNzUzOzIzOkZSR0I1bksxQlc2Z1g3V2hLVjlFSE5nL0Nn?= =?utf-8?B?ZXI0U0lPaGZ0MlpqSVRvZElxSDU2WXROSHIzbFZsYVljSk5nbGVxcmlrVEJF?= =?utf-8?B?Zzg5elFsYWZiZVZiR2wzcDF1YmpQcHVwVTJYaVhkTTI1UnVNa2lsdVV6VStS?= =?utf-8?B?Ly9FU1MzcTlXVDNvbkJPKzJDSytiRjdFb09nZVlUbkkxbExMNFo3cWt0a1JM?= =?utf-8?B?UlAvdDQrL0JXMlkrNy9OSThTanA2bGsvZXRmYlEwVUlGcFo5Q2h2czEyT2o4?= =?utf-8?B?cmtGVUZSbHoyekhyZmx5N1pXVnZnUXNmc2t5dEhoOTNmRUVsZkRWdnpObFAx?= =?utf-8?B?cW5DUFNReWFQd0l6ZHVrWmdMV2VIRVZOTmMvOW8zb3lzaUVUYURCK2FIVWMv?= =?utf-8?B?U3ZxWkdLNy9RRGR3SkJiYjlHZDZoVy9oMUpYQ2xwWm1qaytBd2ZaQy9EZ1pt?= =?utf-8?B?ZzJXZ1VTTzRpbGZtSlBMMkhZL05wcFhnaTV3UmdJbWJRZTRETTNjTUdmdWtX?= =?utf-8?B?OVYrUUpYWnM2bjBGQk5vWjNoaXNLTnJvSWZyQndwVnhSQkM0QWFtRU9hdC9X?= =?utf-8?B?VmZCbS9pempNTDIyQWcyS1paQjBNSytlOWQ0Q0ZOZy8vOENZN0tlMC9JWUN4?= =?utf-8?B?ZllPY0NMSjVMZC9zQ3JMMGs5cXhuQlRCeXJzLy9lZnBoSnVJNjB1QnI0SWpa?= =?utf-8?B?dHdpSjVUOS9VOW05ejh5VTB2a1lYNCtDSjkwWkVqL3RDbVU2clZuNEIvOFRL?= =?utf-8?B?OSt4bndwcmg0cHFJM2pIS1VqUXlVN1dPTWYzOXNCRnNYK1l4SjRGd3dtdS9J?= =?utf-8?B?MVBHZ3RGdDBjbGhXR0xLMVRMZXY1eXBTcXNybE5yRjc0MVhBSUgrcXF6blNX?= =?utf-8?B?V3Nmek9lMy9IUVZJeHBZZS8wT2ozSTNkUDhQVlBsdFI0TDVhZ2V1MS9HdFR1?= =?utf-8?B?WmN6bkFFS0ZXN1RDWnR0SVdidmJ1ZllFdDJnaXg1ekVaQ0c2dkVwb0xuTEE0?= =?utf-8?B?Y2grRE80L0p4V1R3UTExNVorc0JFbG1JVVBlNWZaeGRaSTFKYm5oM2l5WVlE?= =?utf-8?B?UzRaNHQvZnJEa2c2N3FFQ3RBVXhaTEFJRHdITmdWR2dZUkJtWXZ0WkwrWmNp?= =?utf-8?B?VWc4QVhqeEZsUkxJZFhvZUVJV3N6MHJJNTVEbzRTZ1M4dlpvUkl2djdHKzF0?= =?utf-8?B?SnlFZ2VlanRZZTk2dlBmdSt2cXM1OE9lb0VqR2VlaGpOWGk0TmdqMkNZRndz?= =?utf-8?B?SUpESHBWcTlMRjEvRUxtZkxtZjg1MnpHTFZVQzJhWWNmbzl1N1VOL0tkWUNK?= =?utf-8?B?SGhwaUdjNW9kQTdQWGJ3bzdvQjBVcURhcGtMd2MzTGJkTXVDbmFtNDdKcFV5?= =?utf-8?B?MjQyTlMycFJueGV5N3BDQUorMGdGNjBwQm4xU3B3Q2UxdDNiK0tlTmlrZXd4?= =?utf-8?B?dk1yMFdaOGFYaktrZk1GWndpSlF5RUlIbEhQSmRVRTYrTnJFMzhRMnFQM0Zr?= =?utf-8?B?Z0U0MForeFJDcFhjVU9xcjRaQlpCcmNKb01DNndOZlN2K0xXWWo5OHpISHZz?= =?utf-8?B?ZWM4R1pPNTlzWjV2Qkp6b1VnSGtDYnVFN1g3blp5OHc4VFNyUDNScUVYWVFY?= =?utf-8?B?a0d5eGlBSUFPaWk1WTY0T01VdTVZdVBkN0ZYQWxJSjNUVklIcVFRZmNJVW1R?= =?utf-8?B?Q0UwcHovS0l3THBtd3dnYWkycE5wMCs0RDZZcnlKZ25tMmV2dmZzeWcwWUpv?= =?utf-8?B?T29NMnpITUYwU2pyYW9jME52cXloVWtwemt1SGE4VXBPbmh5WFVNOWVsbkly?= =?utf-8?B?MXEyTzJRdS9OTmR1ejVEUGpLVkgwR3VPbkRwTzdLNDFra0V6VjJMRGdHNjdG?= =?utf-8?Q?BUUfuCOL3iDyUFVdTOeRIK2zUFybnwAL?= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0753; 6:z44+HR2SR2LIS35h1pPgcYcAFyJHGE4zHvZtlurz5yd1UDm2yabCOmKL72SdjzonFBcVOViM9XFM5RDWgbNYGtQm2Dc4mFSnt6r+l71wBcjw7qJ7cFZq93U1n2mzsuuVSoFSAL3Mi4EYNABz+YyMEi0KrrSl13Ev7ztC7XjsaTgDdQx29qG1XoOYLr1ngyRUosWH/3Ten3cJb8iC4Ng4M1N8tyB80NtuQNJq95JEsDTGmI95a0jXW1PsRGpIH/eNHZaXb6W29linbjqKO5E15IEW1BP2bA3PPpqTeBvmLvfM2PICAZRFddVtu47x62L3/j9jwTgZC4dzdvd/Og7WICpDCOh+FADruG3+OFICCFA=; 5:DzZRGlJ17P9R6D9cSWJF3p3aoY8A3qlZ1hDIUdwT5s2lWVNxbU0Emtpgzp/1UEHf+4zZ5ukMepM7teNM1egj7bVhKE1uL8gIqNdew6DdBuRMoTzp79+e8W7TOY7qjzmwRkqA1EMVCFsgqKlYXBx2rjlCNca/Ofew94qZc4HZ5iw=; 24:/H9rvlibQSFDY6j4awzvRMwYVYkiXbZTMOpdkM/PFjtuq6k6WmXAmNbJOiEBmfLoWXpFfTBqiEKseG1RZzpz6bto7sZNk+11LoEU9MimUyc=; 7:OqauoYL5NqzlyoxR8bOOljJW7N6ibIRghzd+K1fnbWfxIokEpNEuLzOKJ3d2w4qKDkZi50ZoEd6rLbO0RA0SDrvSwoVF57ZqgMlCawtUUP3Rzz+IU5UOovJYVrB/Xz+n9v3VtPd+vIlOYyVy6ExF9TLxUNZSHB5AhWskMmLdGPb0k8prnLk9eZpK/JSJW9exBxvzNEWKgLKB8SAa9vyyoLAOisSsneNbr/3hgcxsHR4umOzeLMsq5x1xETVvHYnH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2018 03:46:36.4717 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9681d6b-08cb-47f8-323e-08d5729462d4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0753 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: remove unused map symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 03:46:39 -0000 HI Pavan, On 2/12/2018 7:53 PM, Pavan Nikhilesh wrote: > Remove some unused map symbol. > > Signed-off-by: Pavan Nikhilesh > --- > diff --git a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map > index cc635c736..d05f274d0 100644 > --- a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map > +++ b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map > @@ -2,7 +2,6 @@ DPDK_17.11 { > global: > > rte_dpaa_bpid_info; > - rte_dpaa_pool_table; > > local: *; > }; DPAA(x) related changes LGTM > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > index 2e6cbe96e..d12360235 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -248,7 +248,6 @@ EXPERIMENTAL { > rte_service_map_lcore_get; > rte_service_map_lcore_set; > rte_service_probe_capability; > - rte_service_reset; It is not a good idea to remove these APIs form MAP Some of these are external APIs. The existing examples may not be using them in DPDK, but a real app may use that. The same comment apply to other removal for external APIs. Cristian, what is your opinion. > rte_service_run_iter_on_app_lcore; > rte_service_runstate_get; > rte_service_runstate_set; > diff --git a/lib/librte_ether/rte_ethdev_version.map b/lib/librte_ether/rte_ethdev_version.map > index a5cb372b1..87f02fb74 100644 > --- a/lib/librte_ether/rte_ethdev_version.map > +++ b/lib/librte_ether/rte_ethdev_version.map > @@ -156,7 +156,6 @@ DPDK_17.08 { > rte_flow_copy; > rte_flow_isolate; > rte_tm_capabilities_get; > - rte_tm_get_leaf_nodes; > rte_tm_hierarchy_commit; > rte_tm_level_capabilities_get; > rte_tm_mark_ip_dscp; > diff --git a/lib/librte_ring/rte_ring_version.map b/lib/librte_ring/rte_ring_version.map > index 5474b985e..d935efd0d 100644 > --- a/lib/librte_ring/rte_ring_version.map > +++ b/lib/librte_ring/rte_ring_version.map > @@ -7,7 +7,6 @@ DPDK_2.0 { > rte_ring_init; > rte_ring_list_dump; > rte_ring_lookup; > - rte_ring_set_water_mark; > > local: *; > }; >