From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5488A0566; Mon, 8 Mar 2021 17:22:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6A0F22A409; Mon, 8 Mar 2021 17:22:14 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id D31ED22A3EC for ; Mon, 8 Mar 2021 17:22:12 +0100 (CET) IronPort-SDR: BLjJSw+sWqZkivWQbb7+Ufhl9F9skhuQ/2TjbMzS8DCvjIqniuORaZ7UFm5wutJ9vD9BK+0GPT mkWrh2ADxi+Q== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="184696272" X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="184696272" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 08:22:05 -0800 IronPort-SDR: I/fs/arnuIXWllusA99sHGJaWh8NAYXXTvUSCjo3n8FmrCqGvCt6RYwoDHXqaLiEJMCVJ8LxFG 07sLgdc58hrw== X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="409356690" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.195.201]) ([10.213.195.201]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 08:22:02 -0800 To: "Xueming(Steven) Li" , Andrew Rybchenko Cc: "dev@dpdk.org" , Slava Ovsiienko , Asaf Penso , NBU-Contact-Thomas Monjalon , "declan.doherty@intel.com" References: <1608303356-13089-2-git-send-email-xuemingl@nvidia.com> <1614868228-13685-3-git-send-email-xuemingl@nvidia.com> <148a3d4b-425e-ac5f-3d4a-7b04c41e65b8@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <77eadf1b-bd79-b2c0-bb28-d9962b6a60b2@intel.com> Date: Mon, 8 Mar 2021 16:22:00 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v8 2/9] ethdev: support representor port list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/8/2021 3:58 PM, Xueming(Steven) Li wrote: > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Monday, March 8, 2021 10:38 PM >> To: Xueming(Steven) Li ; Andrew Rybchenko >> Cc: dev@dpdk.org; Slava Ovsiienko ; Asaf Penso ; NBU-Contact-Thomas Monjalon >> ; declan.doherty@intel.com >> Subject: Re: [PATCH v8 2/9] ethdev: support representor port list >> >> On 3/4/2021 2:30 PM, Xueming Li wrote: >>> To support extended representor syntax, this patch extends the >>> representor list parsing to support for representor port range in >>> devargs, examples: >>> representor=[1,2,3] - single list >>> representor=[1,3-5,7,9-11] - list with singles and ranges >>> >> >> Isn't above syntax already supported, can you please document what is added? >> >> From documentation, what already supported is: >> -w pci:dbdf,representor=0 >> -w pci:dbdf,representor=[0-3] >> -w pci:dbdf,representor=[0,5-11] >> > > Just a refactor to prepare for the extended representor syntax which need to reuse the value parsing function for controller and pf section. > OK, can you please highlight this is a refactoring, from patch title and commit log it feels like new syntax support is added. >> >>> Signed-off-by: Xueming Li >>> Acked-by: Viacheslav Ovsiienko >>> Acked-by: Thomas Monjalon >>> Acked-by: Andrew Rybchenko >> >> >> <...> >> >