From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7932246183;
	Mon,  3 Feb 2025 17:51:04 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2F06B40265;
	Mon,  3 Feb 2025 17:51:04 +0100 (CET)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id 809DF40264
 for <dev@dpdk.org>; Mon,  3 Feb 2025 17:51:00 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3112C11FB;
 Mon,  3 Feb 2025 08:51:24 -0800 (PST)
Received: from [10.1.32.49] (JR4XG4HTQC.cambridge.arm.com [10.1.32.49])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8AEEF3F58B;
 Mon,  3 Feb 2025 08:50:58 -0800 (PST)
Message-ID: <77ef65b2-3a3d-489a-a4da-474d181193a0@arm.com>
Date: Mon, 3 Feb 2025 16:50:57 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] dts: rework run-time MTU adjustment test case
Content-Language: en-GB
To: Nicholas Pratte <npratte@iol.unh.edu>, Honnappa.Nagarahalli@arm.com,
 stephen@networkplumber.org, thomas.wilks@arm.com, probb@iol.unh.edu,
 thomas@monjalon.net, dmarx@iol.unh.edu, yoan.picchi@foss.arm.com,
 paul.szczepanek@arm.com, ian.stokes@intel.com
Cc: dev@dpdk.org
References: <20250131193803.168498-1-npratte@iol.unh.edu>
 <20250203163850.249461-1-npratte@iol.unh.edu>
 <20250203163850.249461-3-npratte@iol.unh.edu>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <20250203163850.249461-3-npratte@iol.unh.edu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 03/02/2025 16:38, Nicholas Pratte wrote:
> --- a/dts/tests/TestSuite_mtu.py
> +++ b/dts/tests/TestSuite_mtu.py
> @@ -164,22 +164,33 @@ def test_runtime_mtu_updating_and_forwarding(self) -> None:
>               # Configure the new MTU.
>   
>               # Start packet capturing.
> -            testpmd.start()
>   
Sorry!! you forgot to remove the lines above until the docstring I presume.
>               testpmd.set_port_mtu_all(1500, verify=True)
> +

Looks good otherwise!

Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>