From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Sarosh Arif <sarosh.arif@emumba.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/librte_eal/common/rte_malloc: remove redundant check for size and alignment
Date: Fri, 17 Jul 2020 15:49:10 +0100 [thread overview]
Message-ID: <77f077dd-2746-3bd6-66fa-0a7f16d8b7a7@intel.com> (raw)
In-Reply-To: <7378e729-bf93-4abd-9720-e24ee7162ffc@intel.com>
On 17-Jul-20 3:40 PM, Burakov, Anatoly wrote:
> On 15-Jul-20 2:31 PM, Sarosh Arif wrote:
>> Since mallock_socket() always calls malloc_heap_alloc() and
>> this check is present inside malloc_heap_alloc() so there is
>> no need to place it in mallock_socket().
>>
>> Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
>> ---
>
> Technically not a bug, so i don't think backporting this is necessary.
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
Actually, now that i think of it, i agree with Lukasz - while this check
isn't necessary, it's an early exit to avoid memory locking. So, NACK.
--
Thanks,
Anatoly
prev parent reply other threads:[~2020-07-17 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200715133236eucas1p177311544d71d3806b436cf69734ffe08@eucas1p1.samsung.com>
2020-07-15 13:31 ` Sarosh Arif
2020-07-16 22:23 ` Lukasz Wojciechowski
2020-07-17 14:40 ` Burakov, Anatoly
2020-07-17 14:49 ` Burakov, Anatoly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77f077dd-2746-3bd6-66fa-0a7f16d8b7a7@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=sarosh.arif@emumba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).