From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9EDFA053D; Fri, 17 Jul 2020 16:49:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 925981BEDD; Fri, 17 Jul 2020 16:49:13 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B92331BED9 for ; Fri, 17 Jul 2020 16:49:12 +0200 (CEST) IronPort-SDR: 1QebpF1q+hUxXA8i4KwmSwtD9x8rh8IJU2ykZKRLMWPsXOPiL5+F8MVpSjaN10FJsIM1sb0RzM pwNB6TD7FDIw== X-IronPort-AV: E=McAfee;i="6000,8403,9685"; a="234451963" X-IronPort-AV: E=Sophos;i="5.75,362,1589266800"; d="scan'208";a="234451963" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2020 07:49:11 -0700 IronPort-SDR: RCgI9BrjAE7MsaOop4XZSoNyrya3/HuO4m7WWl5d3DqxA4m6qoYIZ2osf99OkuNSDjJRT2hKHn RGaiZX1IVJ/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,362,1589266800"; d="scan'208";a="286832430" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.226.225]) ([10.213.226.225]) by orsmga006.jf.intel.com with ESMTP; 17 Jul 2020 07:49:10 -0700 From: "Burakov, Anatoly" To: Sarosh Arif Cc: dev@dpdk.org References: <20200715133136.31986-1-sarosh.arif@emumba.com> <7378e729-bf93-4abd-9720-e24ee7162ffc@intel.com> Message-ID: <77f077dd-2746-3bd6-66fa-0a7f16d8b7a7@intel.com> Date: Fri, 17 Jul 2020 15:49:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <7378e729-bf93-4abd-9720-e24ee7162ffc@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] lib/librte_eal/common/rte_malloc: remove redundant check for size and alignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 17-Jul-20 3:40 PM, Burakov, Anatoly wrote: > On 15-Jul-20 2:31 PM, Sarosh Arif wrote: >> Since mallock_socket() always calls malloc_heap_alloc() and >> this check is present inside malloc_heap_alloc() so there is >> no need to place it in mallock_socket(). >> >> Signed-off-by: Sarosh Arif >> --- > > Technically not a bug, so i don't think backporting this is necessary. > > Acked-by: Anatoly Burakov > Actually, now that i think of it, i agree with Lukasz - while this check isn't necessary, it's an early exit to avoid memory locking. So, NACK. -- Thanks, Anatoly