From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68649A0542; Mon, 29 Aug 2022 15:37:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09F3B4069D; Mon, 29 Aug 2022 15:37:21 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id D55F34003C for ; Mon, 29 Aug 2022 15:37:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661780240; x=1693316240; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=dH6f5+upGXc/ESmC/FfI3xcIxVt+kDB6hQhnbqqh5Yc=; b=JcuSW8+nNkEbj+gGQzkVPKgAASsUlhj+wACn5w3o36AMuBa6Ji+zbChl iESkW1MROt4HruZSc/4SJBjY/aSE193iNng5dUVEUMkxLON/ALatQKY8a spI8gfGXWA/tSUEzkQ9uVTZBXFy/nt/Npp4GZsdWlI4877TiAK2NqjL6y 3jWyAnlyS+YpK0rUbrq5zD7infc2xjCI1Eg38c68eYzMZi7vzzJdAxXIn UEdCuUzAAT+5sTibyUeF/+3xyyqGk0jkrjqP6wSXQI2cukVUIzfxqCgA8 cJdodTur+0XYgOVBMZndzuNF5u8uEKci1csYpJ4yVQXVmIDTSIs+gnPL0 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="274643857" X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="274643857" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2022 06:37:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="939580548" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 29 Aug 2022 06:37:18 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 29 Aug 2022 06:37:18 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 29 Aug 2022 06:37:18 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 29 Aug 2022 06:37:18 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 29 Aug 2022 06:37:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X2WxHQ+aB09b8D9kEsgDxbJSU7q7QIrmeCoYUjWE1F1/6WWZTY/s/60v39cfaZ1eameQBEz55OjItcWisFxu4ynUg941815LAIxySkb0RAwBQ2hMWa4WO9hmcY62lCBAAf5Zw7QIaCajkL/zIhzeFqm1W0yleR8zHcZfrG9ig1CbKKxUtZikGfmxsRSyzem+L8xmuq/NchFJj94MJ5hwyBLfYJuOV5pOZOMSn/60X3ww0HmKNG7z0mB31OyBWkjw5ZW9jp0StUTEo8zWkFvtVi5mzPX5aYdKUez09AGhO/1Bsm4nhU0BN9l0kBEjmszNfZ66uq6Hct0+1Adn6M31iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M+0NhuTFofRvM8g+qNEXhXg6pYAcMwhrHSgYH0uQ/QQ=; b=klTqujSrbsZahzmi3JR84Alz3gWgm9MVIy3g/sCFTJv1VYzM3Oby0qpt57eols9KamrNMhV+pKWDmRN/GdfJivhYQWh3hzL0H+6M/NUedQ954yleTybDTAlqv8X6hDu6RaU/8NPcFdBbQiB7RL64ro+m8WUL2NyhrKw8DhQ45pVQ2ZhThBNedMyf8J7GmhFkc8V2qEqtFDgV/ztqzpXVk0Vm4ZBcXwLyxp/S4yRnEMqKTeemyO5VVR3GsLzzp8OSkd15ulunztB5gimnH+HYDBVh3lphjTcUgre8yPxWtZ8aFXQi9q5Rv17r9/zVFNvGw5Xv7ql6GBBQ+HaOSP1OIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by BN6PR11MB1890.namprd11.prod.outlook.com (2603:10b6:404:106::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.19; Mon, 29 Aug 2022 13:37:15 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2080:d65f:9c32:7749]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2080:d65f:9c32:7749%4]) with mapi id 15.20.5566.016; Mon, 29 Aug 2022 13:37:15 +0000 Message-ID: <77ff0a3b-7b1b-84c8-36ff-136d2d634e0b@intel.com> Date: Mon, 29 Aug 2022 14:37:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v3 1/3] eal: add lcore poll busyness telemetry Content-Language: en-US To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Thomas Monjalon , Bruce Richardson CC: Jerin Jacob , Anatoly Burakov , dpdk-dev , Conor Walsh , David Hunt , Nicolas Chautru , Fan Zhang , "Ashish Gupta" , Akhil Goyal , Chengwen Feng , Ray Kinsella , Ferruh Yigit , Andrew Rybchenko , Jerin Jacob , "Sachin Saxena" , Hemant Agrawal , Ori Kam , Honnappa Nagarahalli , Konstantin Ananyev References: <24c49429394294cfbf0d9c506b205029bac77c8b.1657890378.git.anatoly.burakov@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D872C4@smartserver.smartshare.dk> <2555175.9Mp67QZiUf@thomas> <98CBD80474FA8B44BF855DF32C47DC35D872CD@smartserver.smartshare.dk> From: Kevin Laatz In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D872CD@smartserver.smartshare.dk> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0304.eurprd04.prod.outlook.com (2603:10a6:10:2b5::9) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dfaef3cb-cc56-4090-a6fe-08da89c39605 X-MS-TrafficTypeDiagnostic: BN6PR11MB1890:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y3wv/4fpFdZilkTneBLbofg+WHSSvd+PHDNfiuWDYP+BfaINqw4cI5yjYpTIIYkjE+Lb9VZVVgolHnpkj/G6MaN+qU4NY60DzjN90/ZcM0MclEUbuL/tqar7fg1z+0IHUNLxtrM4Qte+GUsLHDZcWD5kZEEcwTRMkfCfyYdGIsYzm3V8coLnyOW/AsZMqfbtcDhPadUChLFCe9jqUQa/QfCVs39DmfCV4ZYFrM7x9lvewOH9LojTl87hq8cjKwOholE9srtOKo6uxU20rqKugi/6wY3oVZZjYm0UpnXXO7YkrF07lQMNl94QUa5tZMoRT+91idQ4Oevy9+DGZbpUfsfbqMfzqsEYWLQfw9enUQ6FPDn+LXZGKh782q9IYe7UWie4PhMP4Pm4Rq/k7fyci5IOBmw9dT6lVLygzmAZFBZJulsOCBtXFhLeZB0LyVpylrDLhf5Z82Eo9XeKAQoqugtjyujS6OTDob/MbyT2LNEuoTbGRYHHN+7dZq4Y3O7JmfscHAVzh4vdBESoimtzMaz3845H1xWOqHpBw4W2fV1v+3FFJ3GZJxQWgET+1mk1ktpDYRXBicNwuSekUOXSIRpV8nseN4mzI8n9rzEBXDYreJtM9dCiL/GklKuRunMxCXBzUKoLa/sHJnIms+c3hrk3D18InZjQ3A7ViHRlttHPXRBXbP9fW+ZQbgSZlP/IAjuMdo9D1vGU3o8symutSsMtPEsvlkdsNvdB6DoFOGmlHTovvFsnahHpEyLwokLnfL7qosOGhRqULv5NZPTQv5YxYl56zG4OmFrTqQ8+uyw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(136003)(346002)(376002)(366004)(39860400002)(478600001)(54906003)(4326008)(6636002)(110136005)(66476007)(6486002)(66946007)(8676002)(31696002)(66556008)(38100700002)(41300700001)(36756003)(86362001)(8936002)(82960400001)(5660300002)(7416002)(2906002)(53546011)(6666004)(44832011)(31686004)(83380400001)(66574015)(316002)(6506007)(186003)(26005)(2616005)(6512007)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXVaVXVyUkpvTFVBZGlPcCtrZDZydWNoUlNPQThUQUltK3pkVVdUS2NlSjhZ?= =?utf-8?B?eHc0RUtFbjJtQm13dVFDbkNTVURuek9SOWthZ09jczVIaXhIcitFbHRhWWRv?= =?utf-8?B?VTlLRStsWUNvYS9nUTh6N0hCUjYwUUVHVWtCUldlYmVNUVAzdmJTMllzMGpE?= =?utf-8?B?VTUvRlJidDU1QVNiQXgzVU1DOHJ4a2NZNU4yS2hEMzF0enU4RXhZRWN3cHgz?= =?utf-8?B?Qmw3OGZ1THdDa0pDMXpaQURKZ3AvWHE0YW44ZDQ3UHJwenAxdGxRUzdjaTh4?= =?utf-8?B?Z1liTGxla1M4TFhsRmxodWtuZGFkMzYvRFkrZ01xbUViN3lFRmxxdTIvOGJ5?= =?utf-8?B?aW0xVzdCV3EzR1JiTlBzN011SW9HcWUvN1dqVnZ5bHdrQm9HakV1dnhjMURy?= =?utf-8?B?TkNlYW1DNXdmVStGckFFMWtVS0QzWk1CcXh5MVVncFFONEJVTlJlYlE2NzYy?= =?utf-8?B?cC9yZ05sTFRodk5xSzVlc1FxMDdpZTBYNEp4R3BWeGhYalg3Um0vbGZINWNy?= =?utf-8?B?WGJHZit3MS9lTld3azI4VnRaNTZtTDVidm1zS0VnVVQxbEVCRFpqRm56Zkh4?= =?utf-8?B?b2RXZWxML1FHY3JxaXQxcjJRbEJjWjg4bGwzcFRGaXJaMldRdlovdTdDL3la?= =?utf-8?B?UFNZNjBaTlBSaUpxNGhUZ0NORlV4QTFjNmtZWUpTdEVsN1RaQ0psMWhzblhJ?= =?utf-8?B?SlhVb09qVWplYTFkTzhDTnBHOXhDNG5aaHhoVGlFbmhVZVltSEpselN1Q0p3?= =?utf-8?B?ajlYK3dmbGJyeUZOdng1NEZqUHNmcm5OQ3J5dXZJM1BsUkk5NGpxcGJEQWQ0?= =?utf-8?B?SXl1bGorSXBudXpqMWVrMXdWWUFtR0YrelBlNHFDUGFta3d1ZXFmbWVFQUxR?= =?utf-8?B?eGN2Y2cvR0t3R3crYUl4bEROSVhiczhYSkxXakc3MmRtNWU5Y1pvSUc3dURX?= =?utf-8?B?RmhqQlg4VW1vNjRPTWYyVXo2ZUNzSVJJZ1lnVEZPU1dxYTJiMXpqSjgwd2E3?= =?utf-8?B?aDhGeWluZ0ViWDRpZDhqWjlGMTBWQUpZdmFvL2IwQ2JNZ3NKM2YvVkpPSnQy?= =?utf-8?B?bnlQRFhtOGZsSG9VMXgwQUNqL1BJbkQrUkNsK25hRHNibzREMFBtV0lBVUlF?= =?utf-8?B?WGlLS2x2bVdObTNBRTdDZnlKNzg5MGZQZ0NZWm1ZYnlncUpuTzhKT1kyNUt3?= =?utf-8?B?V255TjZ3MSthT25SNmc5SUsrdTVNa0Z5YTFVdk5GZW1rNzZ3aXFvWCszaG9i?= =?utf-8?B?S0hyMDJLS3ZhOG5tYklyMThYY3l6dXBySWN2L3dISERqaHB3VVVnajhZL0hl?= =?utf-8?B?VTJjYjVJWDRYSXBtb0hOa3IrT201bTJiaHNJM2lvQjlvbDdrUkNYRElWeURu?= =?utf-8?B?ZzM3SGlKRURSb0dhbStxWVMzMkdXbVhmekNuT1lXeGN5aVlZZnJmbXV6VHpt?= =?utf-8?B?OFduREt4MnN3UDlWS1ZMdmxGbC8rR3lybUdUZ01nWFhOcnhoVFFVK2wrdXNa?= =?utf-8?B?QWJybEVLVW9wa0lTVEUvKzNyQTVTbmlUdC9WaFhMZVN1bEc5eFdLT0xUNXFC?= =?utf-8?B?Z281b3FRbmJHR3NyblI2RFhyUVFEdkpxMEl5LzRFUlRXNlQvb2VxYWVsM2lQ?= =?utf-8?B?b09oTWhubGIzZTZkcWcyZ3NwV2I2VjNXWWt3MG5rQ0JlRU8xNGVWNDE2ZGpB?= =?utf-8?B?TzdINnJ5SHdnVnZNSXhrMW1tR3hxU0NLeWFxbW9zQzZ2NXpQVXFUY2UzdHNr?= =?utf-8?B?eDVySVg4M2E4dnY5Y0hZR1Z4SUtuY25QY2lKV1V5T3lRemZLMTRYaTkwa2Ey?= =?utf-8?B?d252eG40YkpPbFJEODEzR0FrbnpKUStPLzVCRHVTRnY1cmdlUTArWk5QZ202?= =?utf-8?B?Y0xsSGJoWm1TeTZKNStBSE5ObFdNUzFhdTBWUWNuaUhhRW1GdXpJUmU3b3A4?= =?utf-8?B?c2YzbkFFcGxOMG13ektCRHVTc0RSN2N3Zm0vWHdUVVZPZG1hYjdVUFY2RENN?= =?utf-8?B?czdKcGlNWHNtN0Rqc2ZGR1V4MzNtZXlqeDJyZFVhWXgrSlAwMDREZVFSSm5s?= =?utf-8?B?MVFTbkd0clVJb3VTbWM2a04yK1R4VTBtSlFNRndhY3FnZFZwc0U3Wjl4Qk1V?= =?utf-8?Q?hzIVZd/M/XRrDDT4JKGa15Ufq?= X-MS-Exchange-CrossTenant-Network-Message-Id: dfaef3cb-cc56-4090-a6fe-08da89c39605 X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 13:37:15.7739 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MUB/yBeu+nsStkHglSv9mbPU2X43ye3TAxBURhL4Or8/XhBADzo4Y2u8QgdJ41VF8KavG8JcgIy0w0EfMe2DPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1890 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 29/08/2022 13:49, Morten Brørup wrote: > From: Kevin Laatz [mailto:kevin.laatz@intel.com] > Sent: Monday, 29 August 2022 14.37 >> The patches currently include runtime options to enable/disable the feature via API and via telemetry endpoints. We have run performance tests and have failed to measure any performance impact with the feature runtime disabled. > Lots of features are added to DPDK all the time, and they all use the same "insignificant performance impact" argument. But the fact is, each added test-and-branch has some small performance impact (and consume some entries in the branch prediction table, which may impact performance elsewhere). If you add a million features using this argument, there will be a significant and measurable performance impact. > > Which is why I keep insisting on the ability to omit non-core features from DPDK at build time. I think there's general consensus in having a buildtime option to disable it. Do we agree that it should be buildtime enabled, and runtime disabled by default (so just the single additional branch by default), with the meson option available to disable it completely at buildtime?