From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
Feifei Wang <feifei.wang2@arm.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
David Christensen <drc@linux.vnet.ibm.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Ruifeng Wang <ruifeng.wang@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "nd@arm.com" <nd@arm.com>,
"Honnappa Nagarahalli" <honnappa.nagarahalli@arm.com>,
Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH v1] net/i40e: remove redundant number of packets check
Date: Thu, 3 Mar 2022 16:43:33 +0000 [thread overview]
Message-ID: <7801f1ec-a501-62d4-48aa-cc2729c78ca9@intel.com> (raw)
In-Reply-To: <c35a064854d84deeb8276ad599ba4d9a@intel.com>
On 3/3/2022 2:28 AM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: Feifei Wang <feifei.wang2@arm.com>
>> Sent: Thursday, March 3, 2022 9:54 AM
>> To: Xing, Beilei <beilei.xing@intel.com>; David Christensen
>> <drc@linux.vnet.ibm.com>; Richardson, Bruce <bruce.richardson@intel.com>;
>> Ananyev, Konstantin <konstantin.ananyev@intel.com>; Ruifeng Wang
>> <ruifeng.wang@arm.com>
>> Cc: dev@dpdk.org; nd@arm.com; Feifei Wang <feifei.wang2@arm.com>;
>> Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>> Subject: [PATCH v1] net/i40e: remove redundant number of packets check
>>
>> For i40e_xmit_pkts_vec_xx function, it checks nb_pkts to ensure nb_pkts does
>> not cross rs_thresh.
>>
>> However, in i40e_xmit_fixed_burst_vec_xx function, this check will be
>> performed again. To improve code, delete this redundant check.
>>
>> Suggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>> Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
>> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
> Applied to dpdk-next-net-intel.
>
Hi Qi,
This patch is not acked by the i40e maintainers.
And this is changing the datapath for the -rc3, two weeks before
the release. Is it tested enough?
What is the gain with this patch, I don't see any numbers
in the commit log.
If the gain is small, can we postpone this patch to next
release instead of getting it for -rc3?
next prev parent reply other threads:[~2022-03-03 16:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 1:53 Feifei Wang
2022-03-03 2:28 ` Zhang, Qi Z
2022-03-03 16:43 ` Ferruh Yigit [this message]
2022-03-04 1:23 ` Zhang, Qi Z
2022-03-04 6:01 ` 回复: " Feifei Wang
2022-03-04 11:10 ` Ferruh Yigit
2022-03-24 8:54 ` Zhang, Qi Z
2022-03-04 1:24 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7801f1ec-a501-62d4-48aa-cc2729c78ca9@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=feifei.wang2@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=qi.z.zhang@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).