From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C949AA04A2; Thu, 3 Mar 2022 17:43:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A10084276B; Thu, 3 Mar 2022 17:43:53 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 2C09740687 for ; Thu, 3 Mar 2022 17:43:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646325831; x=1677861831; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=tYmWA260NJP7Y/HxXw5j2GtsO/j+u35qU8siEz4yQ2A=; b=fiw5X5z9+cCPma13rFS9ha0Emxxd8WSkTPbvzZtERyYrNH2Egm99sEuP s6YklEvXqaO3SMJnJQTQZc0PDZKV7fj1KV/06EVzsTQnV6Q+fDEazCQTb 6P/2QQeLD+D6zYL78o2nEIzOkGpmCKhgn4A7+GP9DRnGZceJbZJOTRgFn Q1+tGxMg0PVK7SymH61zomfsnFmjdSCvelAnVRg7TEBtdVrzx+1GqtXdl sPiv6QHjlOwCK1y38vAlomiWoZSDUaxoCadmYNsiaRS1uSw/xa8qO41iJ vnbKofjE7C0mtoXdCYWJuLlRXsKbTrGsJ22eCo8sbBfg7W59OEh24k4yb A==; X-IronPort-AV: E=McAfee;i="6200,9189,10275"; a="241144815" X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="241144815" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 08:43:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="535900906" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 03 Mar 2022 08:43:47 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 3 Mar 2022 08:43:46 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 3 Mar 2022 08:43:46 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 3 Mar 2022 08:43:46 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Thu, 3 Mar 2022 08:43:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zroku13SAg/SA+C8bg0WzxYjNC5nMAMcixQM8iM3DL+ZmKjhSHGU5tMhu9I7mOYmIC2wEueURMwCqB1sF9evDSdqRT+eAfgebfEN2J9msYL76jkR15cIbOh9yvypkP6w6eTZRdmSF3CwjsvWZ5IpAz7AcSSFUbIZ/prZgA7yx4KNs8kmzMW6moRJ107dxXOWy5283XX4qYe2NFltzqz0pQoQgcuPKdpW14Vg4bS7ACSpUbc0YWNhclxpnUVRIqJZBlCFuQgLL2zsRoXuGSd3B1Y4VmTy1Gee68J+mSsxTADtPZsdZVAEtj9OdHjsOLMBjnNinyBw9m6fNa9vPEPmqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9arb7ZKPIFD+4a0RdI/zfA5HEoiau4ZmLaV1qiO6170=; b=e78VJtQ8EEcquSmFlqpmiCNoXOp/ejGlRdoHp8dfED+jjwXzidKtsdxVdP1EHrNtccKv3qXPVQo4GLsi0jsjpZ+k6uFxAxOYG9em4Y/pdWTadFQE380KtpIZXtdOxG+kf80RXmpSwBfbmwEDyD2rojxkvmLuC9zkJy7wjuoefI4nSVIR74Zq2lh5dHlcMsKF5rImc5tpriBfjMNL4MXegT2KbzNjpNfViSTXdDpUcZFFOLI8J+sRe3z5g5DoSKGV2J8y18yvgAalTwrAZmfNlgUzSjIw6r23sI/uPiQRwcGFYOD6lSvx/G6D9x5b6YsNFM16BDknRGbuibOof6vQ1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BL0PR11MB3265.namprd11.prod.outlook.com (2603:10b6:208:6a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Thu, 3 Mar 2022 16:43:41 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.015; Thu, 3 Mar 2022 16:43:41 +0000 Message-ID: <7801f1ec-a501-62d4-48aa-cc2729c78ca9@intel.com> Date: Thu, 3 Mar 2022 16:43:33 +0000 Content-Language: en-US To: "Zhang, Qi Z" , Feifei Wang , "Xing, Beilei" , David Christensen , "Richardson, Bruce" , "Ananyev, Konstantin" , Ruifeng Wang CC: "dev@dpdk.org" , "nd@arm.com" , "Honnappa Nagarahalli" , Thomas Monjalon , David Marchand References: <20220303015343.1755326-1-feifei.wang2@arm.com> From: Ferruh Yigit Subject: Re: [PATCH v1] net/i40e: remove redundant number of packets check X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR1001CA0017.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::27) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 163b6823-6b0b-4f90-aeb5-08d9fd34f90b X-MS-TrafficTypeDiagnostic: BL0PR11MB3265:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F6FSI0iN8gM4TWtljSdWcWg4/l3M/ZPEqdtD0o4RU1vcr9iy9ufpvRyM1g4UFInlyPJtwNrFXDIcAeOXhXa2pVd25gwyWwHPFDpLRliomTCdWDgaFV9qCxa1GkM9fbTUuXuzK0MybsxTfoj3n8MI+qqIfQvKymgs5YQ/lved3qnHCgOZPzFCFE4KgyzzeJuyfcy4NctDI+uUj11/hU3v4elf9z577qyV4Ur+L9Xe6rNTHH7kFNEh+MxYA386J7bWHZSg4eU/Ro3lZIz0rDfXBAQKxrQK4Gsy2h6OKWwCs6sAXsUW+BkP9h5uBFZSApTzQKuh7x3ZuJbwZ78MzmsoSIh1cyuuQ6Ef6m7GPbITNPd/8M7A4qNrGdeExifFIbKDgHlt1dGaoEq+bSVrmsAKVcFmg1JwcVyV7lGGJ1rUUzoJXYXVpnSt24AaaJBEJUVheVhKP6cehSNPw9ztnfBb5QemV0bMZHVRF5a0ErnwHe9ahfCGedilOExVWVzLAR5+yXA7Qa8+NsGC6kkFCXrx+AiiwzZvLt6KH9Y2ywETf6iD5S8tSVH8JK4v4tX68IpGoJiBoVaEScCFsgM9AYnDk9xiv6HbJo48wZkjtVOruxKSai3EaL71VWbDDG531Lg+rA2/e+iND65G+NP2koZwBDNzKmP3w6BmwM/Xm46z2jXAHFS2EaVeiMUotFcsfGAr994LL7z6TOoZhsOmxF4WTCfdQG+FaXWm15cHfLc9uyA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6486002)(110136005)(54906003)(2616005)(53546011)(6506007)(6666004)(316002)(921005)(31696002)(86362001)(66476007)(82960400001)(508600001)(4326008)(8676002)(6512007)(38100700002)(66946007)(31686004)(66556008)(83380400001)(26005)(8936002)(5660300002)(186003)(36756003)(2906002)(44832011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUxKUy9rbHZvd1RLM2JxditMSkRjOWIvMXl0Wmh3NnR5WVdFMzEyc3krQzlD?= =?utf-8?B?dU4vNXpPV1hrUFgxQVIyamVCOWVzRmlCbDkvVjBhTmZpajQ5ZHJpTXZCMmsz?= =?utf-8?B?dG0rWklSR0doMUlvTTFGdWc3bnFTNGdra3pkRWFHWEtnTjBURVFjSVpQekFx?= =?utf-8?B?aVJDLzhqZEFxUzVqa2dvSGdwSzROZ08wblBwRnhvVHFicXZJZGJYT1JkZDZx?= =?utf-8?B?QjBja2FGSW5JaU5FVWxMZlZERTNvVWtNS2ducHpoaVBHZGp6czh5U0ovc0hp?= =?utf-8?B?MDR5MjVoM09DQUNZdEtDOEdIUHI0YmFrek9Ld2V0WkNJTWM5SnVPRmFiQWYy?= =?utf-8?B?clZxeldBQnZQSHoza201SHVGa1BmY2tHRDB4VG5tcTlwZkhxNVRMYTA1amVx?= =?utf-8?B?c1ZXUHZ5RzdSNklkT2c5WTVWSUJZS3YrWlVsNmdVQ1pUTC9EaUpTc01NNGZR?= =?utf-8?B?alNqdjd1aXNMRnEwbHJXNjNGalJWUUdva2NIelpncGxuQ1J4Uk1SVmt1OWN1?= =?utf-8?B?enVCclNBRnZ1N3NZN0ZXZzhQMkx4TmRqc1Y2ck5PemF1Yzd3RnB6SHl3eWhy?= =?utf-8?B?WE45NThmV0NoK3c1c0ZRcjRTYjQvN1BuNGZYWC9ZKzNtbjIrb0lXNTN5Q0JJ?= =?utf-8?B?TGsxdTNKcWxSdGlzRUhuRnNocWlwVWxabmtoS0Q4NUxtYkhLR0hIbE12U05j?= =?utf-8?B?QkhFOXFMeVpxS3NqaU9hRFJ3S3lNUWUyUG81YWZtK1hpZVdpVHhIbXdKekc0?= =?utf-8?B?bG1aVlNlRWJFS0pWRVNSLzN6N0xkWituZEl2dnVjM004VTg3WTFzdE54V2x1?= =?utf-8?B?N0JwT0s3NEs0N3pka0ViQ3gyUEpzVFVnWmRxK09pWVUxajVhekZMMGJSMmRw?= =?utf-8?B?U1VYRDFZTVh4ZEw3ZHpyVzluUEM4UkF4Yjk5YVNnbTREZWI1Ukh6RGtNRUhx?= =?utf-8?B?NzBmR1owZ01rd1JMaWQyT0xIUVVHRjlRa0ZxeGMxemRIRmtDQmlPZzBHZGRZ?= =?utf-8?B?MVNGalk4dFZPS1NmZVFsVUZTRHF3WnMrL2NBTU9oajZmTDNGdkNwbk5COUp0?= =?utf-8?B?SHZraUpoc2svUHdVQWdTNVQwYVhGTC9OamFDUjhXZVpsbU5rd1h3and0bmQy?= =?utf-8?B?aWFveTdiS0FId0VUTEk0QWFOSStvR1poblRvUzhwbXdiemcvSHJyY1Rhd05X?= =?utf-8?B?WGZnZ3k2a3gxQldvajZTZmE0cVdLd0txeXB0MDJOdFR4RjJuRlVIS3FQck5N?= =?utf-8?B?RWVNK1IvbHVOVXBhZC8rWGNlVWpla1Uva2IrSlpGN0hMQS9FTGwxSEtKTERh?= =?utf-8?B?SzQ2UkRvcWxzY0NJaDZZT1lXZy9pY2pWazhzdDFPMlVGT0tsdWt5R2IxQ1JB?= =?utf-8?B?a3VOSEl1VmtnSnhVQWlnN2tnVWt0ZnhvRlVBbko2WnVYTjRkcFczYUNIZU94?= =?utf-8?B?L3YzdDg2dHdLbzR0d284OU1mM0NpemtVa2NhZlljUFRKRnF4WlM2NElYc1Uw?= =?utf-8?B?aHZ5M0VtcUZhMHBoWldzakc0LzZzVEtENmk4UjNSczVCWlczTUh1Sm9KaWd1?= =?utf-8?B?ZUduNFI4dDZHMkdjTG5UcjdSc2hMZUhCZ2xCN3NvOHkyNjIzMFlTaGdBZkpL?= =?utf-8?B?aHVNVUV6d05keDVEWGxzMjRIaWZ4dnFCTC9DUDcxVGxma2hnV3ZkNmw1bHNj?= =?utf-8?B?eHoyOTY1bFgrUGJHSVVmaEE4bXZaU0wyVzNETndRT0VhVDVBZHp3U2tjaEIz?= =?utf-8?B?RnBJbFd5NytSR1k0VitLTHRQMkJpKzQrVE1DRjhzdklCcGpSYmxBdk50bjF5?= =?utf-8?B?Rm45QkhCVktteDNLNjBVOVhiRThyaDRSazBrK3Izcy9ySTJ2bWJDclYvMll2?= =?utf-8?B?a2I3OGZoaS8zVFBpT0tTSkd2K2NUUXdET09WUW5HZEI3TkN5N3psRng1ZzFE?= =?utf-8?B?a0NkNHBzMTV2M1BiT1BxQS9nRXBUWThOeGpVQXh0VzZraWl0TEw2bE5pbUVv?= =?utf-8?B?QzNDdHJTOHhPaXo5NGJOZ2JWYzZ0RDJOTGVSLzZnZXltRWhIZmxiSkE1SG9Z?= =?utf-8?B?MVJJV1pGa0M4QkxyQVZoM0svS3d4blUxTUxEWi8rbXNXT2xQVTFyNFVEV3RQ?= =?utf-8?B?TEx0S3pTZCs3OVZETzBFd1F4L21EcHR0Vnl6OG1BcUxMYmdmWXNSYkprTExm?= =?utf-8?Q?RHdYdd6ca7kBfFTVOFnI36A=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 163b6823-6b0b-4f90-aeb5-08d9fd34f90b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 16:43:41.1335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CHowMy3MYah6vlPyAWfYnoHh38o6PPNKWJtCtlyON9ptj4tZK/jO8iB5TVpZfB2RUJa9szKqpynBotfg92/C8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3265 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/3/2022 2:28 AM, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Feifei Wang >> Sent: Thursday, March 3, 2022 9:54 AM >> To: Xing, Beilei ; David Christensen >> ; Richardson, Bruce ; >> Ananyev, Konstantin ; Ruifeng Wang >> >> Cc: dev@dpdk.org; nd@arm.com; Feifei Wang ; >> Honnappa Nagarahalli >> Subject: [PATCH v1] net/i40e: remove redundant number of packets check >> >> For i40e_xmit_pkts_vec_xx function, it checks nb_pkts to ensure nb_pkts does >> not cross rs_thresh. >> >> However, in i40e_xmit_fixed_burst_vec_xx function, this check will be >> performed again. To improve code, delete this redundant check. >> >> Suggested-by: Honnappa Nagarahalli >> Signed-off-by: Feifei Wang >> Reviewed-by: Ruifeng Wang > > Applied to dpdk-next-net-intel. > Hi Qi, This patch is not acked by the i40e maintainers. And this is changing the datapath for the -rc3, two weeks before the release. Is it tested enough? What is the gain with this patch, I don't see any numbers in the commit log. If the gain is small, can we postpone this patch to next release instead of getting it for -rc3?