From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id B60F5ADBE for ; Wed, 25 Jun 2014 16:23:32 +0200 (CEST) Received: by mail-wi0-f175.google.com with SMTP id r20so8033527wiv.2 for ; Wed, 25 Jun 2014 07:23:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=9aAaTSMaCdnH7OndP+s49QiOXN3BUNxbEjrTlG1Jrfs=; b=UV6ffpVJ0pWU7YQTNEPTMbxwOsbQRw4AfP4XjL9uvxmMquZlT/FcWExrwRGpLYLEvY o3rj2xQXDAw6gVJKe3FwGloi7qM+pymJcpcwvZpcdCH+ZWhfFCnqthkDoCP4qiCLNoE6 YugtsJqpATMRLIlhvaqpJn+6ZC9cRnVqHB5IjLR+SBqNgFcOELAr4kBNkAW+r1GDtrhE SEDHlzifSE+OX7g1o0J1/WeM8YB/oFYIJuBoLskrrXPQ7K7RHBzo7HPjcC9MqPz/hIWZ e3fzfea3r0ESwWWzRtZfnCBIS8TIxzhCSj83KHoO48d9VdpWUjhDZr5ON+bD0msTykdM FAGg== X-Gm-Message-State: ALoCoQlST2idYn6yyBxzpLUjcPMoeH+lI8PBwU1rLtLJJf9TXayDeyl0h8qHUpbPO/PVVlXI9u+w X-Received: by 10.194.10.69 with SMTP id g5mr4163173wjb.116.1403706229232; Wed, 25 Jun 2014 07:23:49 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id pq9sm7781500wjc.35.2014.06.25.07.23.47 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jun 2014 07:23:48 -0700 (PDT) From: Thomas Monjalon To: "Doherty, Declan" Date: Wed, 25 Jun 2014 16:23:44 +0200 Message-ID: <7807394.hy5mplz48E@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <345C63BAECC1AD42A2EC8C63AFFC3ADC272FA3EA@IRSMSX101.ger.corp.intel.com> References: <1403621531-30487-1-git-send-email-declan.doherty@intel.com> <3664505.WcrJi8fzD3@xps13> <345C63BAECC1AD42A2EC8C63AFFC3ADC272FA3EA@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 6/6] Link Bonding Library doxygen additions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jun 2014 14:23:32 -0000 2014-06-25 14:19, Doherty, Declan: > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Wednesday, June 25, 2014 2:44 PM > > To: Doherty, Declan > > Cc: dev@dpdk.org > > Subject: Re: [PATCH v7 6/6] Link Bonding Library doxygen additions > > > > Hi Declan, > > > > Since bonding library is a PMD, there should have no need of integrate it > > in the API documentation. > > I hadn't time to review it yet, so I would miss something. > > Do you mean it can be used directly by the application with a specific > > API? > > In this case, you could explain it in the commit log. > > Hi Thomas, the bonding library has a API which supports creation and > management of bonded devices directly from within applications, but more > importantly provides the APIs required to dynamically add and remove slaves > from a bonded device, this functionality will be required to support live > migration of VMs using bonded ports in a future releases. OK. Could I suggest to split rte_eth_bond.c in 2 files? 1 file for the library matching the API and 1 file for the PMD layer? I feel it would be easier to read and maintain. Thanks -- Thomas