From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92743A00C2; Tue, 8 Mar 2022 14:29:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E2864068E; Tue, 8 Mar 2022 14:29:36 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 8928F4068B; Tue, 8 Mar 2022 14:29:34 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 457553201E00; Tue, 8 Mar 2022 08:29:33 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 08 Mar 2022 08:29:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=5qpJV549rJSJfM cM5sGcE1znFMIl4ogaMz2eZwKi4ks=; b=rDcnF1pGGE6zmlUoJfSqYRb9npxkxa fQIZ8xcyVMvc9xjD3/zjSMLjkjKPAdNQb3Tz6vwpOQE3KQflKUcpm43CVdNAB3It xM45IyTyoSYwgX83n5wK02bOwbqeKrLD8aiRG14gFUJmmrjUTaJ0GeF07oCRD07o WhhkkeokZjqGlOLt0PxN4pETx1hyOW/2qt5Mm8pm0yHmrs+bGY1yVYHR499qMW4v ejhAcu0uw2IgI18tmvb005dC/tcaXi1TufmwkelmJnOmpWzQoIWF7lw+Yqvv1Tpw zhPLvAlAjcdrd7q/9Uh4CxW/KKY35RSn3OOpOFvQDSlWySwcXFXqYmIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=5qpJV549rJSJfMcM5sGcE1znFMIl4ogaMz2eZwKi4 ks=; b=KKDse5pxgkKhuWFJowNucw/jngxdw68NNprRA24+Go7jNKnWAEkKgOwk6 6tTrQmXcEdiu2rY3TRn3YCKKSbPF/dZv4G+8tDcGcozOr6/2L7RnUipM63AHTEHR W6Hvs4xfe5p/194N/mMX1P4wEPjNIYZ7YW7aStibnAMXr2JzMgd+QJuITsTtAydd c73v85e0RMO0riE1a6iOjp9kM4BH+wovHKZMW04lrCc/H4HUcSnvrowPraFnpovY fRB94iILlzYM9HFDz/UT9fUZPGJql6HyB6ZYdC9yPptS1TF6mb4cz20WEjsyaBuj +/bOG6CAJJj5zZdLTcuaeyFICYvtw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudduiedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Mar 2022 08:29:31 -0500 (EST) From: Thomas Monjalon To: Tianli Lai Cc: dev@dpdk.org, "stable@dpdk.org" , Ivan Dyukov , Ferruh Yigit Subject: Re: [PATCH] examples/kni: add CR character at print log Date: Tue, 08 Mar 2022 14:29:29 +0100 Message-ID: <7807989.zQ0Gbyo6oJ@thomas> In-Reply-To: <2784dce5-50da-7a27-856b-05d7d5a7de0c@intel.com> References: <20220307090505.6598-1-laitianli@tom.com> <2784dce5-50da-7a27-856b-05d7d5a7de0c@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/03/2022 15:52, Ferruh Yigit: > On 3/7/2022 9:05 AM, Tianli Lai wrote: > > add CR character at print link state information > > > > Signed-off-by: Tianli Lai > > --- > > examples/kni/main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/examples/kni/main.c b/examples/kni/main.c > > index f5b20a7b62..e99ef5c38a 100644 > > --- a/examples/kni/main.c > > +++ b/examples/kni/main.c > > @@ -719,7 +719,7 @@ log_link_state(struct rte_kni *kni, int prev, struct rte_eth_link *link) > > > > rte_eth_link_to_str(link_status_text, sizeof(link_status_text), link); > > if (prev != link->link_status) > > - RTE_LOG(INFO, APP, "%s NIC %s", > > + RTE_LOG(INFO, APP, "%s NIC %s\n", > > rte_kni_get_name(kni), > > link_status_text); > > } > > Fixes: db4e81351fb8 ("examples: use new link status print format") > Cc: stable@dpdk.org > > Reviewed-by: Ferruh Yigit Applied with title "examples/kni: add missing trailing newline in log"