* [PATCH] examples/kni: add CR character at print log
@ 2022-03-07 9:05 Tianli Lai
2022-03-07 14:52 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Tianli Lai @ 2022-03-07 9:05 UTC (permalink / raw)
To: dev
add CR character at print link state information
Signed-off-by: Tianli Lai <laitianli@tom.com>
---
examples/kni/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/kni/main.c b/examples/kni/main.c
index f5b20a7b62..e99ef5c38a 100644
--- a/examples/kni/main.c
+++ b/examples/kni/main.c
@@ -719,7 +719,7 @@ log_link_state(struct rte_kni *kni, int prev, struct rte_eth_link *link)
rte_eth_link_to_str(link_status_text, sizeof(link_status_text), link);
if (prev != link->link_status)
- RTE_LOG(INFO, APP, "%s NIC %s",
+ RTE_LOG(INFO, APP, "%s NIC %s\n",
rte_kni_get_name(kni),
link_status_text);
}
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] examples/kni: add CR character at print log
2022-03-07 9:05 [PATCH] examples/kni: add CR character at print log Tianli Lai
@ 2022-03-07 14:52 ` Ferruh Yigit
2022-03-08 13:29 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2022-03-07 14:52 UTC (permalink / raw)
To: Tianli Lai, dev; +Cc: stable, Ivan Dyukov
On 3/7/2022 9:05 AM, Tianli Lai wrote:
> add CR character at print link state information
>
> Signed-off-by: Tianli Lai <laitianli@tom.com>
> ---
> examples/kni/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/kni/main.c b/examples/kni/main.c
> index f5b20a7b62..e99ef5c38a 100644
> --- a/examples/kni/main.c
> +++ b/examples/kni/main.c
> @@ -719,7 +719,7 @@ log_link_state(struct rte_kni *kni, int prev, struct rte_eth_link *link)
>
> rte_eth_link_to_str(link_status_text, sizeof(link_status_text), link);
> if (prev != link->link_status)
> - RTE_LOG(INFO, APP, "%s NIC %s",
> + RTE_LOG(INFO, APP, "%s NIC %s\n",
> rte_kni_get_name(kni),
> link_status_text);
> }
Fixes: db4e81351fb8 ("examples: use new link status print format")
Cc: stable@dpdk.org
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] examples/kni: add CR character at print log
2022-03-07 14:52 ` Ferruh Yigit
@ 2022-03-08 13:29 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2022-03-08 13:29 UTC (permalink / raw)
To: Tianli Lai; +Cc: dev, stable, Ivan Dyukov, Ferruh Yigit
07/03/2022 15:52, Ferruh Yigit:
> On 3/7/2022 9:05 AM, Tianli Lai wrote:
> > add CR character at print link state information
> >
> > Signed-off-by: Tianli Lai <laitianli@tom.com>
> > ---
> > examples/kni/main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/examples/kni/main.c b/examples/kni/main.c
> > index f5b20a7b62..e99ef5c38a 100644
> > --- a/examples/kni/main.c
> > +++ b/examples/kni/main.c
> > @@ -719,7 +719,7 @@ log_link_state(struct rte_kni *kni, int prev, struct rte_eth_link *link)
> >
> > rte_eth_link_to_str(link_status_text, sizeof(link_status_text), link);
> > if (prev != link->link_status)
> > - RTE_LOG(INFO, APP, "%s NIC %s",
> > + RTE_LOG(INFO, APP, "%s NIC %s\n",
> > rte_kni_get_name(kni),
> > link_status_text);
> > }
>
> Fixes: db4e81351fb8 ("examples: use new link status print format")
> Cc: stable@dpdk.org
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied with title "examples/kni: add missing trailing newline in log"
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-08 13:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-07 9:05 [PATCH] examples/kni: add CR character at print log Tianli Lai
2022-03-07 14:52 ` Ferruh Yigit
2022-03-08 13:29 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).