From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 845ED41D3C; Wed, 22 Feb 2023 12:01:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6527F40693; Wed, 22 Feb 2023 12:01:50 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 55B6940689 for ; Wed, 22 Feb 2023 12:01:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677063708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cYiJBeX3p3elYNCnoC9TIvz/fI+yzQGpIgKu+RHARHo=; b=Gc0JGtT4XTTqOevae2WOzOMimqPQTVPpF67zW50yNVp3R88dFGom8maTM4vyAZ1I8U8JYx eAsrZI5KrnamuPwbrzQh6J0cPIcEWExSeLFwqVCxunhhp38V/3dr58+Hb9t73YynePf9N6 1O92ORQVKmYtC3hTdaHOhkfJzkrJGkg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-247-x4Hl7e7cPS6hbpY4z9Zvdw-1; Wed, 22 Feb 2023 06:01:47 -0500 X-MC-Unique: x4Hl7e7cPS6hbpY4z9Zvdw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6A36C857D07; Wed, 22 Feb 2023 11:01:47 +0000 (UTC) Received: from [10.39.208.21] (unknown [10.39.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1132D18EC1; Wed, 22 Feb 2023 11:01:45 +0000 (UTC) Message-ID: <784eab4a-7f48-4278-7111-c8750c5efe52@redhat.com> Date: Wed, 22 Feb 2023 12:01:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 16/16] test/bbdev: remove iter count from bler test To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20230215170949.60569-1-hernan.vargas@intel.com> <20230215170949.60569-17-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230215170949.60569-17-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/23 18:09, Hernan Vargas wrote: > iter_count doesn't need to be set equal to iter_max for bler tests. This > is only needed in throughput and latency tests because early termination > is disabled for those tests. > > Signed-off-by: Hernan Vargas > --- > app/test-bbdev/test_bbdev_perf.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index 2baa2a0e62..621feee42b 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -3714,12 +3714,10 @@ bler_pmd_lcore_ldpc_dec(void *arg) > TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", num_ops); > > /* For BLER tests we need to enable early termination */ > - if (!check_bit(ref_op->ldpc_dec.op_flags, > - RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE)) > - ref_op->ldpc_dec.op_flags += > - RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE; > + if (!check_bit(ref_op->ldpc_dec.op_flags, RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE)) > + ref_op->ldpc_dec.op_flags += RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE; > + > ref_op->ldpc_dec.iter_max = get_iter_max(); > - ref_op->ldpc_dec.iter_count = ref_op->ldpc_dec.iter_max; > > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_ldpc_dec_op(ops_enq, num_ops, 0, bufs->inputs, > @@ -3838,12 +3836,10 @@ bler_pmd_lcore_turbo_dec(void *arg) > TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", num_ops); > > /* For BLER tests we need to enable early termination */ > - if (!check_bit(ref_op->turbo_dec.op_flags, > - RTE_BBDEV_TURBO_EARLY_TERMINATION)) > - ref_op->turbo_dec.op_flags += > - RTE_BBDEV_TURBO_EARLY_TERMINATION; > + if (!check_bit(ref_op->turbo_dec.op_flags, RTE_BBDEV_TURBO_EARLY_TERMINATION)) > + ref_op->turbo_dec.op_flags += RTE_BBDEV_TURBO_EARLY_TERMINATION; > + > ref_op->turbo_dec.iter_max = get_iter_max(); > - ref_op->turbo_dec.iter_count = ref_op->turbo_dec.iter_max; > > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_dec_op(ops_enq, num_ops, 0, bufs->inputs, Reviewed-by: Maxime Coquelin Thanks, Maxime