DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Shiqi Liu <835703180@qq.com>
Cc: bruce.richardson@intel.com, dev@dpdk.org
Subject: Re: [PATCH] raw/ioat: Check for the NULL pointer after calling malloc
Date: Tue, 05 Jul 2022 21:43:34 +0200	[thread overview]
Message-ID: <7856744.uz5P2jW1tq@thomas> (raw)
In-Reply-To: <tencent_1793202DABFB8619F43A098D8CD0CA4FBA07@qq.com>

27/06/2022 19:52, 835703180@qq.com:
> From: Shiqi Liu <835703180@qq.com>
> 
> As the possible failure of the malloc(), the not_checked and
> checked could be NULL pointer.
> Therefore, it should be better to check it in order to avoid
> the dereference of the NULL pointer.
> 
> Fixes: b7aaf417f93 ("raw/ioat: add bus driver for device scanning automatically")
> 
> Signed-off-by: Shiqi Liu <835703180@qq.com>
> ---
> --- a/drivers/raw/ioat/idxd_bus.c
> +++ b/drivers/raw/ioat/idxd_bus.c
> @@ -301,6 +301,10 @@ dsa_scan(void)
>  		IOAT_PMD_DEBUG("%s(): found %s/%s", __func__, path, wq->d_name);
>  
>  		dev = malloc(sizeof(*dev));
> +		if (dev == NULL) {
> +			closedir(dev_dir);
> +			return ENOMEM;

Isn't it supposed to be a negative value?




  parent reply	other threads:[~2022-07-05 19:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-27 17:52 835703180
2022-07-05 10:14 ` Bruce Richardson
2022-07-05 19:43 ` Thomas Monjalon [this message]
2022-07-06  9:05   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7856744.uz5P2jW1tq@thomas \
    --to=thomas@monjalon.net \
    --cc=835703180@qq.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).