From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 3AF295917 for ; Tue, 28 Oct 2014 13:04:44 +0100 (CET) Received: by mail-wg0-f47.google.com with SMTP id a1so663922wgh.18 for ; Tue, 28 Oct 2014 05:13:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=xbmjwlXvw6YS5YatroQKajvfiv6OsIAXmQgeNo1iVMI=; b=M1LF3+HfDLIWso2rB8YhewVEHCTxUam63tmEJxFluBxYA4iRS1FP2RrSxyKzEG57fr Q/BlpXyrnkn4sa/cIeJjpRwrK0AtPj9yqryfudq9mBfZNDOjURREMhYTASAiwChZdnjB Vz0u1uMgVHrzY/H/uYPsC/Jily7gwQuSvoRt+fzf3Zvr5wX1qY0ccPGIBaPWgHxwJkEI 1pNfKwbp2+d9IOH82Xi3e/v1We+VUrCK1uGSUU6RaGenGJw2SWCauzHLpgZWIQslxlYZ /hWQ2bWepoAGVWgtltFHOW37u4ObVelRqS51syEx/+8gIKv3CoyyO+9fV+HkhG2BaX9T L8Cg== X-Gm-Message-State: ALoCoQmNK5IyLoyDnMnvdE57CJ0FGWxfnWnEo6b8tMeAbDJYd3cUmIRP32+zwEKcr7opAKYgZFw8 X-Received: by 10.180.101.102 with SMTP id ff6mr28149585wib.34.1414498411187; Tue, 28 Oct 2014 05:13:31 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fx2sm1615253wjb.37.2014.10.28.05.13.30 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Oct 2014 05:13:30 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" Date: Tue, 28 Oct 2014 13:13:12 +0100 Message-ID: <78583890.WXH3mxH3Sc@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <1411634427-746-1-git-send-email-helin.zhang@intel.com> <3230077.QOtjOU5lvA@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2014 12:04:44 -0000 2014-10-28 12:00, Zhang, Helin: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2014-10-28 00:33, Zhang, Helin: > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > 2014-09-25 16:40, Helin Zhang: > > > > > /* Definitions used for redirection table entry size */ > > > > > -#define ETH_RSS_RETA_NUM_ENTRIES 128 > > > > > -#define ETH_RSS_RETA_MAX_QUEUE 16 > > > > > +#define ETH_RSS_RETA_SIZE_64 64 > > > > > +#define ETH_RSS_RETA_SIZE_128 128 > > > > > +#define ETH_RSS_RETA_SIZE_512 512 [...] > > By the way, why only these values are allowed? > > It depends on hardware, 1G/10G hardware supports 128 reta size only, 40G > hardware supports 512 or 128 depends on hardware configuration, 40G VF > hardware supports 64. If more is introduced in the future, more values can be > added later. It will return with errors if reta size is not supported for specific hardware. So maybe it should be the responsibility of the driver to use the right value. This kind of hardware differences should be abstracted for the application. If the application need to know the size, a "get" function could be provided. -- Thomas