From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6E7EEA0547;
Mon, 21 Jun 2021 17:54:25 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id EE71641158;
Mon, 21 Jun 2021 17:54:24 +0200 (CEST)
Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com
[209.85.128.54]) by mails.dpdk.org (Postfix) with ESMTP id 02F6740040
for <dev@dpdk.org>; Mon, 21 Jun 2021 17:54:23 +0200 (CEST)
Received: by mail-wm1-f54.google.com with SMTP id
m41-20020a05600c3b29b02901dcd3733f24so3776463wms.1
for <dev@dpdk.org>; Mon, 21 Jun 2021 08:54:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;
h=subject:to:cc:references:from:message-id:date:user-agent
:mime-version:in-reply-to:content-language:content-transfer-encoding;
bh=Hx9beCJTHbhVkTW8pKd83qAtWF/7WQqhjntpTkNFj0Q=;
b=RMOoP66ho7cNzuqgLKIyZswyjDJ2i660ew7bn9U/CeNv+xXS31C/NbzWw7LWYUzT9n
rAFoHx++8fN5OC7FBDTNuv2w37k37OIITmgOQGIfBLMve3L1tpSmZR4t3SQa5N+VkRVJ
VrRCX1eCu2KqQelPC02JChfXSdsQX2GKZWZfp8I/Va8Nz7lQU5vrLD7Sxf/lWN42v515
7r5USZ03cTZM13zYZBeohSR8yWRmtlrr/cIrsCsBK/gfzCQJ57nG3q3rCr1GjkUC3yuD
9sIUY7OfKQy6Oxx5Z+FjRLhlZsXcHi9YTu3WxQSsmJmUMfKlKHlf5JpU2Q/xCbrIGKK5
bzVQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:subject:to:cc:references:from:message-id:date
:user-agent:mime-version:in-reply-to:content-language
:content-transfer-encoding;
bh=Hx9beCJTHbhVkTW8pKd83qAtWF/7WQqhjntpTkNFj0Q=;
b=eZ3eHqIAw2tu06y9Qw5Lr0w/7kby0Xo6iOfOWLd5p3fR/+SkW7gtZ/ZBOdjk2PS5TG
Ki4Jgkpx1cZcZD7gKHtOv7gqbFGwP1rwbF3azb8hEYVWZH3nuL0GSDV9MwwmZzcp+TsK
Ci8Lffh7QwmS7Wgf/rpfEr0OSQiwkN4EtY5mU/9o7SBPp5EKghZPQqXXtPshbklGSDzM
jHUxRST0BpA2S9ZBDfM9dKb/Lc/OW2ZDDsiQnvKjqyDb2ND9vkKUEnPYtgTYD6rIfgtT
V6qAxh3wvacwpSk7X5ajNCYHZWqFhVpKG101Mmz5q6tbQLx4LQlQPHEPifJnZFzI7FEx
RwjQ==
X-Gm-Message-State: AOAM532sjKOtFDj06MzXGI5OEaprCBxQnxZhVmWiZ8Gr++sx1MnwMOm4
wscp//mMEW/lFdQt/fJf8+kW
X-Google-Smtp-Source: ABdhPJzn0z0oLOD3120xlyGM2TQfZHuooTZZadcCBcXs4RpXjfYXL4hYuCC9w3Lp8kI4bEoohMfrQw==
X-Received: by 2002:a05:600c:3ba0:: with SMTP id
n32mr28145441wms.107.1624290863613;
Mon, 21 Jun 2021 08:54:23 -0700 (PDT)
Received: from [10.16.0.39] (host.78.145.23.62.rev.coltfrance.com.
[62.23.145.78])
by smtp.gmail.com with ESMTPSA id f12sm21827021wru.81.2021.06.21.08.54.23
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Mon, 21 Jun 2021 08:54:23 -0700 (PDT)
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
References: <20210524085341.15184-1-thierry.herbelot@6wind.com>
<20210524112836.28224-1-thierry.herbelot@6wind.com>
<DM6PR11MB2796DFFBE747C8B9A66D2818EB269@DM6PR11MB2796.namprd11.prod.outlook.com>
<2876434.PSW51Ridbg@thomas> <b9711987-d5e9-46eb-61f7-8f50234d80f3@6wind.com>
<DM8PR11MB5670F7F6B9578261D48FAEEDEB0A9@DM8PR11MB5670.namprd11.prod.outlook.com>
From: Thierry Herbelot <thierry.herbelot@6wind.com>
Message-ID: <786a1730-37eb-8f22-7812-74a8a7096dd9@6wind.com>
Date: Mon, 21 Jun 2021 17:54:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <DM8PR11MB5670F7F6B9578261D48FAEEDEB0A9@DM8PR11MB5670.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
>
>
>> -----Original Message-----
>> From: Thierry Herbelot <thierry.herbelot@6wind.com>
>> Sent: Thursday, June 17, 2021 8:12 AM
>> To: Thomas Monjalon <thomas@monjalon.net>; Dumitrescu, Cristian
>> <cristian.dumitrescu@intel.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo
>>
>> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
>>>>> Check Bucket key for all possible indices.
>>>>>
>>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
>>>>> Cc: stable@dpdk.org
>>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>>>>
>>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
>>> [...]
>>>>> - return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
>>>>> + return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
>>>>
>>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>>>
>>>> Thierry, thanks again, you could have actually added my ack from V1 :)
>>>
>>> The root cause looks to be a typo indeed,
>>> but the impact or the scope of the issue
>>> should stated in few words in the title please.
>>> No need to send a v3, please suggest a title and I will apply.
>>
>> table: check a bucket is empty for all bucket keys
>>
>> Thierry
>>
>
> Hi Thierry,
>
> I think Thomas is asking for you to send a new version of this patch with the title updated. Is this OK with you?
>
Hello Cristian
Sure !
What do you think of this title:
"table: check a bucket is empty for all bucket keys"
Best regards
Thierry
> Thanks,
> Cristian
>
>>>
>>>
>>
>> --
>> Thierry Herbelot
>> Senior Software Engineer
>> Tel: +33 1 39 30 92 61
>> http://www.6wind.com/
>>
>> Follow us:
>> https://www.linkedin.com/company/6wind/
>> https://twitter.com/6WINDsoftware
>> https://www.youtube.com/user/6windsoftware
--
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/
Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware