From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
by dpdk.org (Postfix) with ESMTP id F136A256
for <dev@dpdk.org>; Sun, 1 Nov 2015 15:28:56 +0100 (CET)
Received: by wmeg8 with SMTP id g8so41145526wme.0
for <dev@dpdk.org>; Sun, 01 Nov 2015 06:28:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind_com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:organization:user-agent
:in-reply-to:references:mime-version:content-transfer-encoding
:content-type; bh=PVGjaMjqS6i9Ymm11iW0XGV1Gbb8CB88FlhXLuqG/ZY=;
b=cm6OjYi4541D2jtm1T8Jmdtkl+qTOAYLFj/1i3Ieagnn4ShTqz1Rg9DdojdzodPZf8
1sqejGzREBXJMQCyfGscCi+nHNGtGWwxo34YlEOW+YyoW5uzAMceulpmgN+EH7bGtLZ2
pfNxmXq9+li4JdTrCJanSL4RwSfIsWTrChKW5OyA1B4b1nRvokUX1atQ1gtN4MfCo2Kp
pZZ4/r7vcsMae47jvF5gN2gPKw9Hy8aAyU87FPMlzOnSe4rRSN7PI8cSsefRx61NrsTR
2wK1meTC3yCOfhwXZz4i/DmNBv+RGCfiGqX+cagdUU7941MNEpziSpiz3xeGyvZpyyob
wvUA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
:user-agent:in-reply-to:references:mime-version
:content-transfer-encoding:content-type;
bh=PVGjaMjqS6i9Ymm11iW0XGV1Gbb8CB88FlhXLuqG/ZY=;
b=Z9xzofRatwNt93mQpg4xOaFBpIpKIA34TkFM1TBr/m4d/3+2ZkEPpXBhq20jussbn8
I5Ty/UTnEzeZI2e9hs7jEUNPOAr3BBN4uStfNuFrUNEgruFJ4Q4WKndgpPkABjvTh9GK
dlfsGcWjASpClcEOlb1ZgvIGsfHDqpyqoDDDWOa1eN38RBmQ7rWcA8ivcrMOl9eGOjiz
y/sHUpDPFPC0Ns8yHXbc9DTUklm9Mbfesm9SORdu+zBQShMOIATCDGdvDH7o5YJtYK/5
nk64Bg0qT93vhL8z2mxXIsZPBvxlQhBVeZJxl+1xDkbQ+cOTVmIIgRFa40XOwDcRQQhh
vCeg==
X-Gm-Message-State: ALoCoQk7xy1C73ORmfnuH5XHLiKBzP98xZufdmPTwoLXcjLOh7LLgwZNc4ugAigH+NF/wUXeTUwZ
X-Received: by 10.28.92.16 with SMTP id q16mr9168279wmb.94.1446388136824;
Sun, 01 Nov 2015 06:28:56 -0800 (PST)
Received: from xps13.localnet (59.26.90.92.rev.sfr.net. [92.90.26.59])
by smtp.gmail.com with ESMTPSA id 197sm13038271wmx.23.2015.11.01.06.28.55
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Sun, 01 Nov 2015 06:28:56 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Date: Sun, 01 Nov 2015 15:27:41 +0100
Message-ID: <7872129.vXpfkMljjd@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1446308653-2378-2-git-send-email-jingjing.wu@intel.com>
References: <1446021688-17544-1-git-send-email-jingjing.wu@intel.com>
<1446308653-2378-1-git-send-email-jingjing.wu@intel.com>
<1446308653-2378-2-git-send-email-jingjing.wu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 1/3] ethdev: extend struct to support flow
director in VFs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Nov 2015 14:28:57 -0000
2015-11-01 00:24, Jingjing Wu:
> This patch extends struct rte_eth_fdir_flow_ext to support flow
> director in VFs.
[...]
> --- a/lib/librte_ether/rte_eth_ctrl.h
> +++ b/lib/librte_ether/rte_eth_ctrl.h
> @@ -426,6 +426,8 @@ struct rte_eth_fdir_flow_ext {
> uint16_t vlan_tci;
> uint8_t flexbytes[RTE_ETH_FDIR_MAX_FLEXLEN];
> /**< It is filled by the flexible payload to match. */
> + uint8_t is_vf; /**< 1 for VF, 0 for port dev */
> + uint16_t dst_id; /**< VF ID, available when is_vf is 1*/
> };
Why adding these parameters in an input struct?
Shouldn't it be in rte_eth_fdir_action along with rx_queue?