From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FE96428BF; Mon, 3 Apr 2023 17:18:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B7E740ED7; Mon, 3 Apr 2023 17:18:02 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 21E3740A7E for ; Mon, 3 Apr 2023 17:18:01 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 609705C012C; Mon, 3 Apr 2023 11:18:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 03 Apr 2023 11:18:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1680535080; x=1680621480; bh=uksa/40LCpfxa+f2le6jlayyOZaEYfng49h kKOENi4o=; b=xYG5kmfMMxakZBLBCflYqgemmaWMPiDYLtHRF3Z3jiwOChvyNYZ pUl0UP6BmPwKVh2K0BhnKcLwz1WyC++ncTzeX+JKDmD86rS6pzPurSP+1Z2LlKJj i5pIuoKRRzkAatDMNTPJGLz97zW4LHhCRs0HKsruU7+LzWpSEmAsWJ+kyEyLHF8F wOuAQ6Jp78A6+GG+I2b12OmnY3Z2gj8yehnClCXIDoSnYpCd3t0I3D9A9EeitgMa TG6yNUpcwXcqjK7Oe4vOLNWzyPnJxBEZY57c1R16tuKXkLwvj8uoRM1VyU1LBrhY 8KncskomnELze1GPIRGiY+8zLU5e/WuRMSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1680535080; x=1680621480; bh=uksa/40LCpfxa+f2le6jlayyOZaEYfng49h kKOENi4o=; b=XnqsIY9ghRvoHXOZSaFTaOtr6pw0itvS6802mLOtM4KWo9q0Xxd rzAue42sJuuuUzun0Lm8bW4PqwYQQHSWTOkf0rO1sPmNVQa2eRb4Bm6hDqPi1f0/ VxEnQpDK7JVgIDBpJsgmT2SDZbGTyo9E6W1kMBpwvixMQXiLB+nHlSFmuDzNDuts qyU3+RcgIlYtdBKHqoLMaBFwF7z2+rfqEY4JhR9bIRcMF1F04rtgs2bg3TOEBAwd GHouwGa+mRNaPNYdz5DpDrYHsilZmyufo2OtuvALFlw00klVn8jt2JRW5HSxJTcu Kx/Q12s8FfnFg0uEA7X4ojZBO9NtO89Pz5Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeijedgkeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 3 Apr 2023 11:17:59 -0400 (EDT) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= Cc: wathsala.vithanage@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, Honnappa.Nagarahalli@arm.com, lijuan.tu@intel.com, bruce.richardson@intel.com, dev@dpdk.org Subject: Re: [PATCH v1 1/2] dts: fabric requirements Date: Mon, 03 Apr 2023 17:17:57 +0200 Message-ID: <7872319.mogB4TqSGs@thomas> In-Reply-To: References: <20230403114608.1423020-1-juraj.linkes@pantheon.tech> <5831673.1BCLMh4Saa@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 03/04/2023 16:56, Juraj Linke=C5=A1: > On Mon, Apr 3, 2023 at 2:33=E2=80=AFPM Thomas Monjalon wrote: >=20 > > 03/04/2023 13:46, Juraj Linke=C5=A1: > > > Replace pexpect with Fabric. > > > > You should squash these lines with the move to Fabric. > > > > > Signed-off-by: Juraj Linke=C5=A1 > > > --- > > > dts/poetry.lock | 553 +++++++++++++++++++++++++++++++++++++++----= =2D- > > > > Do we really need *all* these lines? > > I see a lot of lines about Windows and MacOSX which are not supported in > > DTS. > > It is so long that it looks impossible to review. > > > > > This is a generated file and doesn't need to be reviewed. In general, I don't like storing generated files. > I separated the > dependencies part so that the code part is easier to review. If you want,= I > can squash the two commits. What happens if we manually remove the useless lines?