From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE755A053B; Fri, 17 Jul 2020 15:01:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 938DC1C11F; Fri, 17 Jul 2020 15:01:53 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 064F51C113 for ; Fri, 17 Jul 2020 15:01:51 +0200 (CEST) IronPort-SDR: UJAp73qfK8LlHsF1ZU+OTTEAyRBAzF/GZ+bxAf1yJXG4ph0YvM0+XX1NP8tNsGTV4CLtJajfYJ hxdNLrgBsy6w== X-IronPort-AV: E=McAfee;i="6000,8403,9684"; a="148741999" X-IronPort-AV: E=Sophos;i="5.75,362,1589266800"; d="scan'208";a="148741999" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2020 06:01:48 -0700 IronPort-SDR: /MP279+UelXczGZjj9mwTjgN+QahIWlhhzm8F6FAadlGxjMf+dmCqQ1YOx37XqtjJbaekklJX/ vNhUlDURa88w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,362,1589266800"; d="scan'208";a="286808756" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.226.225]) ([10.213.226.225]) by orsmga006.jf.intel.com with ESMTP; 17 Jul 2020 06:01:47 -0700 To: Stephen Hemminger , dev@dpdk.org References: <20200604210200.25405-1-stephen@networkplumber.org> <20200701202359.17006-1-stephen@networkplumber.org> <20200701202359.17006-27-stephen@networkplumber.org> From: "Burakov, Anatoly" Message-ID: <78724d56-76d3-f0df-c80c-dab41299d1ba@intel.com> Date: Fri, 17 Jul 2020 14:01:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200701202359.17006-27-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 26/27] memif: replace master/slave with server/client X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: > The names master and slave have no place inside this driver. > It is really a traditional client server model, so use those names. > > Signed-off-by: Stephen Hemminger > --- Isn't this an externally visible change? Or do we not provide any guarantees for PMD devargs working across releases? In any case, i think a release notes mention of this would be nice to have. Otherwise, i took a quick look, LGTM Acked-by: Anatoly Burakov -- Thanks, Anatoly