From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 66D16B6D for ; Tue, 31 Jan 2017 17:41:01 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id r141so86937642wmg.1 for ; Tue, 31 Jan 2017 08:41:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=dhxzAEG0CC+AMX0vlofmZiS6ye+rA5mOnAnEeQOjgYs=; b=snWnLZkfVle9yc42jAZU0eACJ2EBtvslqVnUhivDOaJ8IQLC4B4JVj0dYcpnKmkM30 Eq+Fhy1AzO8W8eiJgz3BTvHyvQUccxCC/eS5x5fRrbRiRr8LahH/JSvZfa5W6bCEkZy+ 1djoyA/Np460Qk2doferpEg/g+mzgANvR/2gSLic6GIX/cFr+E3YHuzNMI14MTQU23gO KS8aUvBw1qDl3nGg4tIzIwgzhRZutQZeuJjko1iMHUPQdoajekRW+p2ikkSfQKJ8J99J 0DLq5X2zC/IgWAGCUihOn3sAJh49ihI4RXk0pkEXlMdKSGqsT01cD384OWpYO3cGZipG mghQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=dhxzAEG0CC+AMX0vlofmZiS6ye+rA5mOnAnEeQOjgYs=; b=DMoI0H9nm4OHLpXgOZX4HATDLM+NIl2o8ry4kOHpgeJPN6SwLsXkFCPbBBeaf5dWlW aE877r0W78QxQuTujfpBnwuGME03GNks4BchGnOBx2Ib76nmvtSnu0lSUut4VobDUf0k 7yVzVYMI+s9yLGg0hzbgajS7Cappaq6QMoLfT6RX7WcJWLgg0DWUmUJXyyNFHo/9e2V2 isTB++7an76PwXpLl1HxUFTXBVqduEs1d4fcfl2RgIwDX3Ylje0ZrbBLf7Vc2KxbbejP 2AXzcpny6HVMaqVUZqzoRGwdKzKrrHDFqCY464ItpIijf0pyMalV3XaFayUY33wndUNR n6yw== X-Gm-Message-State: AIkVDXKEPngEFC8N9jKWP7rqXczNdS8pcWQy7GjoEagvyPEhvG5SB/jq79XfvDUtBnLbL7Ja X-Received: by 10.28.20.209 with SMTP id 200mr19894747wmu.64.1485880861054; Tue, 31 Jan 2017 08:41:01 -0800 (PST) Received: from [10.16.0.184] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k43sm29243259wrc.46.2017.01.31.08.41.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Jan 2017 08:41:00 -0800 (PST) To: "Wiles, Keith" References: <1485855778-15496-1-git-send-email-pascal.mazon@6wind.com> <39a46c11-66c4-d8ed-a2bc-d9421cb4afd0@6wind.com> <9fa2c783-349c-e20c-0e57-0c24e67a4683@intel.com> <9C574760-33CF-4163-94D4-A0C919F4592C@intel.com> <74B7FC24-638D-4A48-A02D-C80B5B4E7E2B@intel.com> Cc: "Yigit, Ferruh" , "dev@dpdk.org" From: Pascal Mazon Message-ID: <78727e66-3588-79ab-6448-9858c19e2361@6wind.com> Date: Tue, 31 Jan 2017 17:39:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <74B7FC24-638D-4A48-A02D-C80B5B4E7E2B@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/6] net/tap: use correct tap name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2017 16:41:01 -0000 On 01/31/2017 05:06 PM, Wiles, Keith wrote:> > Looking at the changes to set the link up/down and the adding the two functions. I noticed in the stop/start routines I was set the link in DPDK and not adjusting the interface link. Should the stop/start routine also do the same thing? > Well, my patch is probably wrong. The best option would probably be to set dev->data->dev_link.link_status appropriately inside tap_link_set() only. I'm not sure it's compulsory to actually set the link UP in tap_dev_start() (respectively DOWN in tap_dev_stop()). If it is, however, it would be best done using tap_link_set() in those functions. -- Pascal Mazon www.6wind.com