From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5305A0032; Tue, 16 Nov 2021 18:21:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC313426F5; Tue, 16 Nov 2021 18:21:49 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id BFC53426F0 for ; Tue, 16 Nov 2021 18:21:47 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10169"; a="297166693" X-IronPort-AV: E=Sophos;i="5.87,239,1631602800"; d="scan'208";a="297166693" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2021 09:16:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,239,1631602800"; d="scan'208";a="567276109" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga004.fm.intel.com with ESMTP; 16 Nov 2021 09:16:14 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 16 Nov 2021 09:16:14 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 16 Nov 2021 09:16:12 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 16 Nov 2021 09:16:12 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 16 Nov 2021 09:16:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h4Hu9dBTy+xLHaEgqmLKqkmHgvy50kX8H9aNaSGOnmmARA1FGCN+RGONXvhULhZ2UD75A4LRbGuAqusmXL3AbAaL3dG+TtFpfbJiCry9c3wA/NCRQRk89a7nuYdwhWYgx9gp7o2fqho8IIQ/SxZZlK9fIvck9Q0uOkda+4BjP2GlNZwV7YXJF+I6JEIYEJFa7CtEUq0tamrn6MZ7lFwfgpkv++5YpMwWi6oQi+EreeqkbZDrQhWUefESOLP5v50giXYddRW9TZtxZ9sUGmlLo6UYFb7FHpWdkilmJLMjakMknncpFj9pTBSwxulw3A0n/w12T6U6+EcQIGF5GwZanQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BrZzd+Af0WlN860jhj+6WGqxp8lAAOzEEa9xYw8iTqs=; b=jGQyJa1XftudcjJuJhLYHCyYEsKZvwMIMKrwYTbhEF5CdNEt9ZuB5UL0h9BGqhRajvvXmZ0YSZyAxXZeTnBBOljzxcu1t0zs7zxOeBfEmBeYMoQ59/PEykuy27UaLC8P79GLq7h8LmAUv5QIvozM4b6T51SG7OlyDnhri/PBljVMjydO0SdsXGclUKnv145MStsB16CmXuGt4pXRdFA0/bfg6/TqYIT8iqeMTLfRXVs9oMeuEEzuH95p2yTBfEKrEKYnN44Ad2SCfT/bhl7jCdGkXbb8nLrQU1VaW6k4gRFHNEycfCgDL2/glPTSxkqSIzTE/qoAKsPcM0wT1iBu7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BrZzd+Af0WlN860jhj+6WGqxp8lAAOzEEa9xYw8iTqs=; b=yrQ6HEc81ebcrv8oNb9Q2YilXYK7JE6TIH7dogWA36vT9q10g1lUzMEQEqxtg+cjWTuUHM3x9gM7W4/N4sDLfKeXAJbHWBDSizNu3VuwfE2s7txD5yxyZkKRMlr85fU1RzeF2kLDSfIUNNQNpwPzZOesm0hjUL8zVR/zs3MG65E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5768.namprd11.prod.outlook.com (2603:10b6:510:131::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Tue, 16 Nov 2021 17:16:11 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.027; Tue, 16 Nov 2021 17:16:11 +0000 Message-ID: <78787fb2-aa55-426a-1bff-29515acec9dc@intel.com> Date: Tue, 16 Nov 2021 17:16:03 +0000 Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: add spinlocks to register command access Content-Language: en-US To: CC: , References: <20211108082331.1407-1-sahithi.singam@oracle.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211108082331.1407-1-sahithi.singam@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0287.eurprd04.prod.outlook.com (2603:10a6:10:28c::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0287.eurprd04.prod.outlook.com (2603:10a6:10:28c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Tue, 16 Nov 2021 17:16:10 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 98cd606e-de5c-4498-4ad9-08d9a924c954 X-MS-TrafficTypeDiagnostic: PH7PR11MB5768: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9kyZDRuf/GmLUFjUNCbHpTYww5u7Ph1wcxaV8KwsbDKU2bs6Oxvb6/ziyvOfM0ISszOBajYOfpqjk2d+ncrSU7uzv2MQh+1jX8p102cNhsFpXCdqBYUNtY5xACNg81rUFKdmdIUhgouwqUroaP1l5eUlZAcefusemHv8QbfyuPzM50aPt3rHL9jbJ3I+gDMP0mVygjKkReSFXYAWOgPtIJ4ZNSyioZ8seBHAzj3XRgcVJmKUaJoqj6szz9K3CHlpu5Wsyk1uOgB5RjIB+CkkNvG7eftbVGeWYWSNGW5bmei4poNIqt8YvzXHWXH2DgkgQowQ23az8k9ZIwDa6wAfsYfkhLJI4n2KrFxJXnw4ocqMukoNMxjc7dz7jK5SzV0lsjJU9G/laMFtJhcBAu2+u05PVDqqfvKF4WR23rSVpQyUSeBBCoy7MqRbl1DKVgEF2wliIDagVYBvQtDtFIo89RVnLi5hub058t0CVWVG3dN2DtRsJ+6rAgtpXvicQcTEFkqLLYd9NunO8Dt/DrCQHv3Bfi8Dj44W+i+VLqD/8TPUhU3KEVRtkVCBO8KzUkNaUPPuQPiIYC5mYXmGuO5jWt8lnBn9H7acYtkTNMldgzI9DDf0kVd+w5WIa90YkmNDEJsOc8saf1VPDlBXW6Dx4WnEl0AJPZSUXcg7Twt7FLuRATUGCRmi3e3JWoSjrJiUGmOkCbDvFBE4ovyCChkYkg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(31686004)(82960400001)(44832011)(316002)(8936002)(186003)(53546011)(26005)(31696002)(16576012)(66476007)(86362001)(2616005)(6666004)(8676002)(2906002)(4326008)(956004)(5660300002)(508600001)(38100700002)(4744005)(36756003)(6486002)(66946007)(83380400001)(66556008)(6916009)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFgvZC96ZmZXWDBIRmVtL0ppZGs1bCt1cHFFTVR4VkZRcCtLd3lwSHZ1TStu?= =?utf-8?B?QmdrMFNjZGVpWFJzblhXd3M2ZEVIalZlbzJnMDhCODZnbFlIemUzYVFGcFYz?= =?utf-8?B?ckJKTkhRVGNEQnJmSmhnbkl0aGcxVTJ2cGRYY1JZSll3V2E0RCtFSHNKendZ?= =?utf-8?B?NTN2b0NiVGNsaGFXSThnK1VvbHIwMnhqODFoaS9NWWNTY1RjcUlZYW15L3du?= =?utf-8?B?a3BRblEreXZMSzBrRmVXNEEvTHVWS3hMRmM2ZzdFVjhZSUlFNEI3bHFFalNv?= =?utf-8?B?V1FpQ2dxMXR4d1ZMeVppOEd5dkxvQUlSNGRGR1dPU0dMODh0RE1rK0MxcE9K?= =?utf-8?B?TG1LcW1pMGpvS1BlOHR5RDVkVlZ4akhleFdWZkNjZ2pHRmIwTFkrUm9IeTNX?= =?utf-8?B?RUdPaXlLK0Voam9pVThGZm5qRER6N3FKL2JXUnFwR3hnYlJNQUFKaXljbUl5?= =?utf-8?B?dnh3SnhBSTQyc3lGRnFzaVhndXZ1Ym5rZlB1UThQcEV0R0pvbjQ4RXNOMTlq?= =?utf-8?B?S2pqeDBKNDJaZGhBR2IwYVk0L1JYUndWRUxYOGtsSUNJYVhmb3FySnF1WTlW?= =?utf-8?B?SG1zWnhmY2xiVVk5Wm5tbFBzUzg5V09TNERxTncvNVQ5ZlBDejRUMzlqYlVX?= =?utf-8?B?V2pYeTNMQ25RdnJHZURDS2FJSXhFY1ptYzE2NTFsRTRGVnZHYTltc0doaVMv?= =?utf-8?B?K0ZLczcxalV4bmRENHlxNkhqLzJzekc0S3FXcGNURjArdnI0TzVTL1Y1QVpk?= =?utf-8?B?YnZKQlQ2ME5hTU9KekJRNXVLQTJRSlpmSGdrclNRYVNpdnJ1c3FEU3MySzJ1?= =?utf-8?B?aEtyUTh3NDNRQW1rTVJVMThkYkJxemhzZHVvdW1jWitOMndkZHVWSUdhNTVa?= =?utf-8?B?YWZjNzBOc2tRREh1ZUNVQ296d3YxQXhOUGpoNStONFh0S2l0aVZpNjVLTEJi?= =?utf-8?B?K3djbUxJUmEyR2ZjQUxxTk11by9oRktTc0kwL2pGUWxaLy80ZGp4TzQxZDdR?= =?utf-8?B?ekZYY3NYQ1BWS0hCdGR6bjM2Yi9wYjcrenN5TzVVamNpQkZGT1hKMHA4N2JT?= =?utf-8?B?RWNnaW5aL0hhbUtXUHBMR2lpT3JmSjFoL1QzSXVseFJYVlNadFFhOUlSeXMz?= =?utf-8?B?d2NCV0tyRGx4UHBaQnoyUXl0cGk5Z2d1VzlFT0VuNGNwRUlRUWt6U25ZNEVM?= =?utf-8?B?dkdQMGRzbUNjVnd5c0lGR2hWV2R4M2lHTFNZSjZNOEhwenhXbnQwbkVHc3Vx?= =?utf-8?B?Tjc3R0s0L1VqTGx6QXRaSG13Q2hTdnltM3F5L1ZXZWdtcktBM2xHYzZMSzBE?= =?utf-8?B?dzBBNENGL290R0pOWEp3d2NMWFZPMHQyZFI1Mi9nbHNNWXhoRmJ6NGt4VFVZ?= =?utf-8?B?Y2tsZ1d5VWZER3ZIV21wNU9Wb3RUd2NjU2pLUW0wUjUrVDdlRHBLZk1ONmxz?= =?utf-8?B?OTh1SFVqMFBPWjZxSHFFNE0wbW1CZ0FoN0oyZVNVRXB0TkhwMHUxd2V1akZJ?= =?utf-8?B?YTdYUm12cmowUjZVVHk0WWFRTE9JWFlpUTZSV2lSLzVER3puTmg1N2RNaVg5?= =?utf-8?B?Yzdhdnh2cDV4eHpFRno2S2lzNjRpMExxUDk1NDlnSGlBTnpVaThhY0o3ekti?= =?utf-8?B?SG85VFpzTkNxWUU2UHYvYVJweVduUHgvOFYvUjFVSjhzWGpKVW1DbEFnQ0FO?= =?utf-8?B?VFZVTUNwc3Z6T3prZ1hJVlFyY3Vidm5yU3ZUYXVzRWVIcDdWdGJCTG43UEYy?= =?utf-8?B?UXMrcHJpTENOQkhtYS9HUEJobEI3Q3UrZFFnVDk2VnU0TlFIQm1Fei9GYmI3?= =?utf-8?B?RS9oYVcyTmVDZERuNmxvZjVBSmltZjJBYm1iWitVV2liNkxLK1l5ejFiVUU0?= =?utf-8?B?VXlURnlpcTdSNE52ZXJ2c0lpbXMvaDc3YUNaYWlmc0VrR3E0WFk3SkpTR3ZF?= =?utf-8?B?TSttNWVKdGhzSFh2NDV3MVF4eFlTUEcwNzlXQVBRZkk4TGI0WDZISXBiSjR5?= =?utf-8?B?SEFrdlFUbHJ4My9OY2dYeXV5a2RtdzVIWnVWMjgwV3cvaVhESE1NL0Q1elJJ?= =?utf-8?B?Y1lwT1lzWHArWTh0MmJsM2E1Y2M4N3ErWElSVkxaYTVmVEVNQlozSUdWZkxM?= =?utf-8?B?MElMMFdVeXVadndDK3o4ZlpORlNzd3ZoU0gxR1hBWXphNU5aOUJ1blFmZTF6?= =?utf-8?Q?ApAML5rKYHUtULQ70LzLMzc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 98cd606e-de5c-4498-4ad9-08d9a924c954 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2021 17:16:11.4463 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v85I1mO07R8wnUTvv6j7dsDgnhR1MCu0Jxf5r3en8TN65ZbfPwM7yCGgRvQsve4AbF9zVG4oggz54s+erXAKOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5768 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/8/2021 8:23 AM, sahithi.singam@oracle.com wrote: > From: Sahithi Singam > > At present, there are no spinlocks around register command access. > This resulted in a race condition when two threads running on > two different cores invoked link_update function at the same time > to get link status. Due to this race condition, one of the threads > reported false link status value. > > Signed-off-by: Sahithi Singam Hi Yong, can you please review this patch?