From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com
 [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id AA2BD5A44
 for <dev@dpdk.org>; Wed,  8 Jul 2015 11:54:01 +0200 (CEST)
Received: by wibdq8 with SMTP id dq8so207282903wib.1
 for <dev@dpdk.org>; Wed, 08 Jul 2015 02:54:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=f/t1KUBCzAoRLEUYzDAHho4DzjsnKt7McKilvRJ/FZc=;
 b=XYX3EtdkiLQYnKMLa8jRonq/TebVzWMXIo/HxXPOl7YJfBlKwZ2nk+RmAYybBsaFVO
 3iTNXFckpoSuc1YAcOerLQzw+07HZvfgbRcJ9kAV1y5pR7GDmM9mXalI6JvcJ+rVVQYE
 dNvGNZNyn8lyLx9M4OZugi+OdUa4Gi+wiWSmsZeUxSeHxp/96eGhQjD1sQxH0GmbYjpa
 sDScCOUu6a7qTj4zVmNcsUE0qXEGw4PKfoypMJZF3a5YFERfPI885/6zWE6lJ8uPlPqY
 UM3y/trcj//NkQCw7caxp99NOfj5UV7A1QzgXeF/FYpfDf7xZVwtXc0liMDb9GNFbuAL
 INvg==
X-Gm-Message-State: ALoCoQmEC3HDhM1hWeaiu5N+pUwO8tAmSE9+5qaeygBj594PWEd4Fh9pVaGXPnixtiX0zay2QrQ7
X-Received: by 10.180.24.65 with SMTP id s1mr68598429wif.66.1436349241560;
 Wed, 08 Jul 2015 02:54:01 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id p2sm2005869wix.11.2015.07.08.02.54.00
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Jul 2015 02:54:00 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>
Date: Wed, 08 Jul 2015 11:52:51 +0200
Message-ID: <7897190.qLvkiMcu3A@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1435586380-1673-1-git-send-email-nhorman@tuxdriver.com>
References: <1435088014-18973-1-git-send-email-nhorman@tuxdriver.com>
 <1435586380-1673-1-git-send-email-nhorman@tuxdriver.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCHv4 1/4] rte_compat.h : Clean up some typos
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2015 09:54:01 -0000

Hi Neil,

2015-06-29 09:59, Neil Horman:
> - *	int __vsym foo_v20(char *string)
> + *	int foo_v20(char *string)
[...]
> -#define BIND_DEFAULT_SYMBOL(b, e, n) __asm__(".symver " RTE_STR(b) RTE_STR(e) ", "RTE_STR(b)"@@DPDK_"RTE_STR(n))
> +#define BIND_DEFAULT_SYMBOL(b, e, n) __asm__(".symver " RTE_STR(b) RTE_STR(e) ", " RTE_STR(b) "@@DPDK_" RTE_STR(n))
>  #define __vsym __attribute__((used))

In this patch, you removed __vsym from the example but the #define still exists.
Should it be removed? or documented?

Thanks