From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBE8CA0548; Tue, 11 Oct 2022 18:49:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BFB8841147; Tue, 11 Oct 2022 18:49:12 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5F8A240F19 for ; Tue, 11 Oct 2022 18:49:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665506950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hu8YIox9k2zFQE85381nvMFg58SVUqqM4Jq5AbIPj5E=; b=QS56gtJa552He3ghkIK347IElzuNF2ULSJLuEX7WBZBVDWKWCmmqESq/oeSDlP2g+KCXtA 9D/QVc/d4fnSrZayE3t41joCcHZQrZglfnZp1Y6/ezKkBfSIyK9/Iw1rxwjs+bn6XNv3P4 592kQCZwziGk9fJgSgWX6MgdTdB6lVQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-177-5wDDCzJtNiOswCbL-pdqFg-1; Tue, 11 Oct 2022 12:49:07 -0400 X-MC-Unique: 5wDDCzJtNiOswCbL-pdqFg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 55AD5803D4B; Tue, 11 Oct 2022 16:49:07 +0000 (UTC) Received: from [10.39.208.19] (unknown [10.39.208.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 146F0404CD98; Tue, 11 Oct 2022 16:49:05 +0000 (UTC) Message-ID: <78aa0fe6-6a50-ee72-c882-8e2b490f41c0@redhat.com> Date: Tue, 11 Oct 2022 18:49:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 1/8] vdpa/ifc: add new device ID for legacy network device To: Andy Pei , dev@dpdk.org Cc: chenbo.xia@intel.com, rosen.xu@intel.com, wei.huang@intel.com, gang.cao@intel.com References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1663308990-621-1-git-send-email-andy.pei@intel.com> <1663308990-621-2-git-send-email-andy.pei@intel.com> From: Maxime Coquelin In-Reply-To: <1663308990-621-2-git-send-email-andy.pei@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/16/22 08:16, Andy Pei wrote: > From: Huang Wei > > Add new device id to support IFCVF_NET_TRANSITIONAL_DEVICE_ID (0x1000). > Rename macro from "IFCVF_BLK_DEVICE_ID" to "IFCVF_SUBSYS_BLK_DEVICE_ID". > > Signed-off-by: Huang Wei > Signed-off-by: Andy Pei > --- > drivers/vdpa/ifc/base/ifcvf.h | 6 ++++-- > drivers/vdpa/ifc/ifcvf_vdpa.c | 13 ++++++++++--- > 2 files changed, 14 insertions(+), 5 deletions(-) > > diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h > index 9d95aac..ef7697a 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.h > +++ b/drivers/vdpa/ifc/base/ifcvf.h > @@ -12,12 +12,14 @@ > #define IFCVF_BLK 1 > > #define IFCVF_VENDOR_ID 0x1AF4 > -#define IFCVF_NET_DEVICE_ID 0x1041 > +#define IFCVF_NET_MODERN_DEVICE_ID 0x1041 > #define IFCVF_BLK_MODERN_DEVICE_ID 0x1042 > +#define IFCVF_NET_TRANSITIONAL_DEVICE_ID 0x1000 > #define IFCVF_BLK_TRANSITIONAL_DEVICE_ID 0x1001 > #define IFCVF_SUBSYS_VENDOR_ID 0x8086 > #define IFCVF_SUBSYS_DEVICE_ID 0x001A > -#define IFCVF_BLK_DEVICE_ID 0x0002 > +#define IFCVF_SUBSYS_NET_DEVICE_ID 0x0001 > +#define IFCVF_SUBSYS_BLK_DEVICE_ID 0x0002 > > #define IFCVF_MAX_QUEUES 1 > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c > index ac42de9..07cc63d 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -1684,23 +1684,30 @@ struct rte_vdpa_dev_info dev_info[] = { > static const struct rte_pci_id pci_id_ifcvf_map[] = { > { .class_id = RTE_CLASS_ANY_ID, > .vendor_id = IFCVF_VENDOR_ID, > - .device_id = IFCVF_NET_DEVICE_ID, > + .device_id = IFCVF_NET_MODERN_DEVICE_ID, > .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID, > .subsystem_device_id = IFCVF_SUBSYS_DEVICE_ID, > }, > > { .class_id = RTE_CLASS_ANY_ID, > .vendor_id = IFCVF_VENDOR_ID, > + .device_id = IFCVF_NET_TRANSITIONAL_DEVICE_ID, > + .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID, > + .subsystem_device_id = IFCVF_SUBSYS_NET_DEVICE_ID, > + }, > + > + { .class_id = RTE_CLASS_ANY_ID, > + .vendor_id = IFCVF_VENDOR_ID, > .device_id = IFCVF_BLK_TRANSITIONAL_DEVICE_ID, > .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID, > - .subsystem_device_id = IFCVF_BLK_DEVICE_ID, > + .subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID, > }, > > { .class_id = RTE_CLASS_ANY_ID, > .vendor_id = IFCVF_VENDOR_ID, > .device_id = IFCVF_BLK_MODERN_DEVICE_ID, > .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID, > - .subsystem_device_id = IFCVF_BLK_DEVICE_ID, > + .subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID, > }, > > { .vendor_id = 0, /* sentinel */ Reviewed-by: Maxime Coquelin Thanks, Maxime