From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 016F6A0561; Thu, 27 Feb 2020 18:34:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CE3C01BFCC; Thu, 27 Feb 2020 18:34:36 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 841421BFCC; Thu, 27 Feb 2020 18:34:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2020 09:34:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,492,1574150400"; d="scan'208";a="285395334" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by FMSMGA003.fm.intel.com with ESMTP; 27 Feb 2020 09:34:32 -0800 Received: from irsmsx606.ger.corp.intel.com (163.33.146.139) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Feb 2020 17:34:32 +0000 Received: from irsmsx606.ger.corp.intel.com (163.33.146.139) by IRSMSX606.ger.corp.intel.com (163.33.146.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 27 Feb 2020 17:34:31 +0000 Received: from irsmsx606.ger.corp.intel.com ([163.33.146.139]) by IRSMSX606.ger.corp.intel.com ([163.33.146.139]) with mapi id 15.01.1713.004; Thu, 27 Feb 2020 17:34:31 +0000 From: "Laatz, Kevin" To: "Power, Ciara" CC: "dev@dpdk.org" , "Pattan, Reshma" , "stable@dpdk.org" Thread-Topic: [PATCH] telemetry: fix struct reset after value assignment Thread-Index: AQHV7ZHUNLIG/WOdQ0CKQjKKP1F8YagvTNwQ Date: Thu, 27 Feb 2020 17:34:31 +0000 Message-ID: <78ab395921c74c3293ce6f0c77419d32@intel.com> References: <20200227170456.29164-1-ciara.power@intel.com> In-Reply-To: <20200227170456.29164-1-ciara.power@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODc1ZTk1YmItYWVlNy00NzY5LThmZjItNGZlNGQ3MzFjNDY4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaks4a0k5WnRrRGk2cVFLRnBlMnlJQW5odnYxVngyK1J1aHg3RG9NTm9SRHZVTExIWmtiUGFZR04wcVwvekVYa2kifQ== dlp-product: dlpe-windows x-originating-ip: [163.33.253.164] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] telemetry: fix struct reset after value assignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > The ep struct is used to track what type of stats are required by the cli= ent. > For PORT_STATS type, it contains the lists of port and metric ids to quer= y, and > the number of ids in each list. >=20 > The ep struct has values set (num of port and metric ids) when a request = for > port stats values by name is received. However, after this value assignme= nt, > the struct is reset to all 0 values, meaning the number of port and metri= c ids > required now both show as 0, and the client will not receive the requeste= d > data in response. To fix this issue, the memset call is now moved above t= he > ep struct value assignment. >=20 > Fixes: 4080e46c8078 ("telemetry: support global metrics") > Cc: reshma.pattan@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz