Re: [dpdk-dev] [PATCH v5 2/3] ethdev: introduce Tx queue offloads API

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 9/28/2017 7:54 PM, Shahaf Shuler wrote:
> Introduce a new API to configure Tx offloads.
> 
> In the new API, offloads are divided into per-port and per-queue
> offloads. The PMD reports capability for each of them.
> Offloads are enabled using the existing DEV_TX_OFFLOAD_* flags.
> To enable per-port offload, the offload should be set on both device
> configuration and queue configuration. To enable per-queue offload, the
> offloads can be set only on queue configuration.
> 
> In addition the Tx offloads will be disabled by default and be
> enabled per application needs. This will much simplify PMD management of
> the different offloads.
> 
> Applications should set the ETH_TXQ_FLAGS_IGNORE flag on txq_flags
> field in order to move to the new API.
> 
> The old Tx offloads API is kept for the meanwhile, in order to enable a
> smooth transition for PMDs and application to the new API.
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>

<...>

> @@ -620,6 +628,15 @@ Supports packet type parsing and returns a list of supported types.
>  
>  .. _nic_features_timesync:
>  
> +Mbuf fast free
> +--------------

I think this is not one of the current tracked features. Is this
coming/planed with new patches?

I suggest removing from this patch, and if required add with another
patch that both updates default.ini and this documented.

> +
> +Supports optimization for fast release of mbufs following successful Tx.
> +Requires all mbufs to come from the same mempool and has refcnt = 1.
> +
> +* **[uses]       rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_MBUF_FAST_FREE``.
> +* **[provides]   rte_eth_dev_info**: ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_MBUF_FAST_FREE``.
> +
>  Timesync
>  --------
>  
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 9b73d2377..59756dd82 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c

<...>