From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 570815699; Fri, 10 May 2019 12:53:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2019 03:53:28 -0700 X-ExtLoop1: 1 Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.27]) ([10.237.220.27]) by fmsmga001.fm.intel.com with ESMTP; 10 May 2019 03:53:26 -0700 To: Kevin Traynor , Ferruh Yigit Cc: dev@dpdk.org, dpdk-stable References: <9119aac2903c82257a136b2cea3185a00232a203.1556119511.git.anatoly.burakov@intel.com> From: "Burakov, Anatoly" Message-ID: <78b7223c-4fc8-7f3c-d26b-0348951de438@intel.com> Date: Fri, 10 May 2019 11:53:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 May 2019 10:53:31 -0000 On 09-May-19 7:16 PM, Kevin Traynor wrote: > On 09/05/2019 18:50, Ferruh Yigit wrote: >> On 5/9/2019 6:50 PM, Ferruh Yigit wrote: >>> On 4/24/2019 4:26 PM, Anatoly Burakov wrote: >>>> In no-shconf mode, there is no need to clean runtime directory >>>> because it's not created in the first place. >>>> >>>> Fixes: 0a529578f162 ("eal: clean up unused files on initialization") >>>> >>>> Signed-off-by: Anatoly Burakov >>> >>> Is this for 18.11.x LTS? >>> cc'ed the stable mail list assuming that is the case. >> >> +Kevin >> >>> >>> Is this valid for 19.05 too? >>> > > It's already applied on 18.11 branch. The same change is also in master > courtesy of the referenced upstream commit below, so this one not needed > for master. Thanks for checking. > > commit 4c1ef6dff7230f08f90427355741f56d2faf5884 > Author: Anatoly Burakov > Date: Wed Apr 24 16:26:10 2019 +0100 > > eal: fix cleanup in no-shconf mode > > [ upstream commit 307315d4577462943d0fcb2e6b8c8f35f90698d7 ] > Yes, this was already applied at master. It was rolled into another fix, which i admittedly shouldn't have done, i don't know what i was thinking. This is only for 18.11 stable. -- Thanks, Anatoly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BA86BA0096 for ; Fri, 10 May 2019 12:53:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BED7458FE; Fri, 10 May 2019 12:53:31 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 570815699; Fri, 10 May 2019 12:53:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2019 03:53:28 -0700 X-ExtLoop1: 1 Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.27]) ([10.237.220.27]) by fmsmga001.fm.intel.com with ESMTP; 10 May 2019 03:53:26 -0700 To: Kevin Traynor , Ferruh Yigit Cc: dev@dpdk.org, dpdk-stable References: <9119aac2903c82257a136b2cea3185a00232a203.1556119511.git.anatoly.burakov@intel.com> From: "Burakov, Anatoly" Message-ID: <78b7223c-4fc8-7f3c-d26b-0348951de438@intel.com> Date: Fri, 10 May 2019 11:53:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190510105327.pnmBITGu_wdGU4AyYNEuw-G6pS6LS1a748ekCY4L9UI@z> On 09-May-19 7:16 PM, Kevin Traynor wrote: > On 09/05/2019 18:50, Ferruh Yigit wrote: >> On 5/9/2019 6:50 PM, Ferruh Yigit wrote: >>> On 4/24/2019 4:26 PM, Anatoly Burakov wrote: >>>> In no-shconf mode, there is no need to clean runtime directory >>>> because it's not created in the first place. >>>> >>>> Fixes: 0a529578f162 ("eal: clean up unused files on initialization") >>>> >>>> Signed-off-by: Anatoly Burakov >>> >>> Is this for 18.11.x LTS? >>> cc'ed the stable mail list assuming that is the case. >> >> +Kevin >> >>> >>> Is this valid for 19.05 too? >>> > > It's already applied on 18.11 branch. The same change is also in master > courtesy of the referenced upstream commit below, so this one not needed > for master. Thanks for checking. > > commit 4c1ef6dff7230f08f90427355741f56d2faf5884 > Author: Anatoly Burakov > Date: Wed Apr 24 16:26:10 2019 +0100 > > eal: fix cleanup in no-shconf mode > > [ upstream commit 307315d4577462943d0fcb2e6b8c8f35f90698d7 ] > Yes, this was already applied at master. It was rolled into another fix, which i admittedly shouldn't have done, i don't know what i was thinking. This is only for 18.11 stable. -- Thanks, Anatoly