From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 9F7DC7CDF for ; Mon, 21 Aug 2017 13:03:42 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Aug 2017 04:03:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,409,1498546800"; d="scan'208";a="302594551" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by fmsmga004.fm.intel.com with ESMTP; 21 Aug 2017 04:03:38 -0700 To: Jiayu Hu , dev@dpdk.org Cc: konstantin.ananyev@intel.com, jianfeng.tan@intel.com, thomas@monjalon.net, jingjing.wu@intel.com, lei.a.yao@intel.com References: <1502333448-75976-1-git-send-email-jiayu.hu@intel.com> <1502960892-112960-1-git-send-email-jiayu.hu@intel.com> <1502960892-112960-3-git-send-email-jiayu.hu@intel.com> From: Ferruh Yigit Message-ID: <78ba62e4-5917-3ec8-91f9-e9937ba556b7@intel.com> Date: Mon, 21 Aug 2017 12:03:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1502960892-112960-3-git-send-email-jiayu.hu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 2/2] doc: update testpmd user guide for the heavyweight mode GRO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2017 11:03:43 -0000 On 8/17/2017 10:08 AM, Jiayu Hu wrote: > This patch is to update testpmd user guide for the heavyweight mode GRO. Documentation can be part of the implementation patch. It is good to split patches logically, but I don't see the benefit of splitting patch as documentation and implementation. > > Signed-off-by: Jiayu Hu > --- <...> > > +set gro flush interval > +~~~~~~~~~~~~~~~~~~~~~~ > + > +Set the interval of flushing GROed packets from reassembly tables:: > + > + testpmd> set gro flush interval (num) > + > +In the heavyweight mode, GROed packets are stored in reassembly tables > +and need flushing from the tables manually. This command is to set the > +number of performing GRO operations between two flushing operations. > + > +The value of ``num`` should be in the range of 0 to ``GRO_MAX_FLUSH_INTERVAL``. > +``0`` means flush GROed packets from the tables when one GRO operation > +finishes. It can be good to mention default interval value is GRO_DEFAULT_FLUSH_INTERVAL if this command not issued. > + > mac_addr add > ~~~~~~~~~~~~ > >