DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] mempool: fix memory allocation in memzones during retry.
@ 2020-07-13  3:40 Zhike Wang
  2020-07-13 10:32 ` Andrew Rybchenko
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Zhike Wang @ 2020-07-13  3:40 UTC (permalink / raw)
  To: dev; +Cc: olivier.matz, arybchenko, Zhike Wang

If allocation is successful on the first attempt, typically
there is no problem since we allocated everything required and
we'll terminate the loop (if memory chunk is really sufficient
to populate required number of mempool elements).

If the first attempt fails, we try to allocate half
of mem_size and it succeed, we'll have one more iteration of
the for-loop to allocate memory for remaining elements and
should not try the next time with quarter of the mem_size.

It is wrong that max_alloc_size is divided by 2 in the
case of successful allocation as well, or invalid memory
can be allocated, and leads to population failure, then errno
other than ENOMEM may be returned.

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Signed-off-by: Zhike Wang <wangzhike@jd.com>
---
 lib/librte_mempool/rte_mempool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index a2bd249..b8f2629 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -635,7 +635,7 @@ struct pagesz_walk_arg {
 				RTE_MIN((size_t)mem_size, max_alloc_size),
 				mp->socket_id, mz_flags, align);
 
-			if (mz == NULL && rte_errno != ENOMEM)
+			if ((mz != NULL) || (mz == NULL && rte_errno != ENOMEM))
 				break;
 
 			max_alloc_size = RTE_MIN(max_alloc_size,
-- 
1.8.3.1



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-07-21 23:27 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-13  3:40 [dpdk-dev] [PATCH] mempool: fix memory allocation in memzones during retry Zhike Wang
2020-07-13 10:32 ` Andrew Rybchenko
2020-07-13 11:17 ` Burakov, Anatoly
2020-07-13 11:29   ` Andrew Rybchenko
2020-07-13 14:52     ` Burakov, Anatoly
2020-07-14  7:36       ` 王志克
2020-07-14  7:26 ` [dpdk-dev] [PATCH v2] " Zhike Wang
2020-07-14  9:32   ` Burakov, Anatoly
2020-07-21 23:27     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).