From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D80794618E; Tue, 4 Feb 2025 16:15:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B95B42D7D; Tue, 4 Feb 2025 16:12:19 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id 31401427A6 for ; Tue, 4 Feb 2025 16:12:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738681925; x=1770217925; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=flCewB9SUkQZV0I9VbVKlRUO86/EDvYuWWv+6GBqoS8=; b=HrHtHzG7aNXy2xWUVFE9xbouFPCy8zqv36ZGyWJdyEm6j7tXENqpRBnI oyDPuoQDkW1pnH8L2q2Lt+wwrmYrr4F4FdUTMPGO1p32n0AVjPi4yp07R BqlziiDo0eIOmsAyktdKdSL7j+hT2zFUdu/0Vojni80N73AzkxTmIAuT+ N5TE+TwTNRe2VZSlb5udP15hmspT0Yuik4XBGYNVlgZrJpHSXVNqKv6Lm mBK2WXyZ+WVjuASQKwQPp/ZGBOv90PaMmwbfo1YAwGhyVb+In09vg9BK9 N794PDQXsRMz+yvBwk+/ymCLQEGp6ppuHLWDULAVwUU04qhrUuJROo7Dr A==; X-CSE-ConnectionGUID: xjtmOkTDRHSaSwo2KqLHIg== X-CSE-MsgGUID: Ml5be/08RzetBq+7QFTEoQ== X-IronPort-AV: E=McAfee;i="6700,10204,11336"; a="39097145" X-IronPort-AV: E=Sophos;i="6.13,258,1732608000"; d="scan'208";a="39097145" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2025 07:12:04 -0800 X-CSE-ConnectionGUID: kRS2CxJOStuRSP97Ykb7fA== X-CSE-MsgGUID: 7e7PB07LSHWcy/g7hvwgCA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,258,1732608000"; d="scan'208";a="110792701" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by fmviesa008.fm.intel.com with ESMTP; 04 Feb 2025 07:12:03 -0800 From: Anatoly Burakov To: dev@dpdk.org Cc: bruce.richardson@intel.com Subject: [PATCH v2 29/54] net/e1000/base: workaround for packet loss Date: Tue, 4 Feb 2025 15:10:35 +0000 Message-ID: <78ce2986c131a5d5fb4584cbeafcdf29deefd870.1738681726.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Nir Efrati On some MAC types, packet loss is observed due to wake DMA clock gating. Disable wake DMA clock for some MAC types to avoid packet loss. Signed-off-by: Nir Efrati Signed-off-by: Anatoly Burakov --- drivers/net/intel/e1000/base/e1000_ich8lan.c | 7 +++++++ drivers/net/intel/e1000/base/e1000_ich8lan.h | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/intel/e1000/base/e1000_ich8lan.c b/drivers/net/intel/e1000/base/e1000_ich8lan.c index b346b95d2f..7cbbeae91c 100644 --- a/drivers/net/intel/e1000/base/e1000_ich8lan.c +++ b/drivers/net/intel/e1000/base/e1000_ich8lan.c @@ -5048,6 +5048,7 @@ STATIC s32 e1000_init_hw_ich8lan(struct e1000_hw *hw) { struct e1000_mac_info *mac = &hw->mac; u32 ctrl_ext, txdctl, snoop; + u32 mac_reg; s32 ret_val; u16 i; @@ -5108,6 +5109,12 @@ STATIC s32 e1000_init_hw_ich8lan(struct e1000_hw *hw) snoop = (u32) ~(PCIE_NO_SNOOP_ALL); e1000_set_pcie_no_snoop_generic(hw, snoop); + /* Enable workaround for packet loss issue on TGL/ADL platforms */ + if (mac->type == e1000_pch_tgp || mac->type == e1000_pch_adp) { + mac_reg = E1000_READ_REG(hw, E1000_FFLT_DBG); + mac_reg |= E1000_FFLT_DBG_DONT_GATE_WAKE_DMA_CLK; + E1000_WRITE_REG(hw, E1000_FFLT_DBG, mac_reg); + } ctrl_ext = E1000_READ_REG(hw, E1000_CTRL_EXT); ctrl_ext |= E1000_CTRL_EXT_RO_DIS; E1000_WRITE_REG(hw, E1000_CTRL_EXT, ctrl_ext); diff --git a/drivers/net/intel/e1000/base/e1000_ich8lan.h b/drivers/net/intel/e1000/base/e1000_ich8lan.h index e456e5132e..4780417bae 100644 --- a/drivers/net/intel/e1000/base/e1000_ich8lan.h +++ b/drivers/net/intel/e1000/base/e1000_ich8lan.h @@ -277,7 +277,7 @@ #define E1000_PCH_RAICC(_n) (0x05F50 + ((_n) * 4)) #define E1000_PCI_VENDOR_ID_REGISTER 0x00 - +#define E1000_FFLT_DBG_DONT_GATE_WAKE_DMA_CLK 0x1000 #define E1000_PCI_REVISION_ID_REG 0x08 void e1000_set_kmrn_lock_loss_workaround_ich8lan(struct e1000_hw *hw, bool state); -- 2.43.5